From 5d469218b817eecb8fc29ed9563beb3465bee573 Mon Sep 17 00:00:00 2001
From: Kai Michael Poppe <kai@poppe.dev>
Date: Mon, 7 Sep 2026 16:20:28 +0200
Subject: [PATCH] Change open note pin

Resolves #2882 with changing the open note pin from an "X" to an "!".
---
 app/assets/javascripts/leaflet.map.js | 2 +-
 app/views/layouts/_markers.html.erb   | 2 +-
 app/views/layouts/map.html.erb        | 2 +-
 app/views/notes/index.html.erb        | 4 ++--
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/app/assets/javascripts/leaflet.map.js b/app/assets/javascripts/leaflet.map.js
index 1087f20e7..db2bfd5e5 100644
--- a/app/assets/javascripts/leaflet.map.js
+++ b/app/assets/javascripts/leaflet.map.js
@@ -425,5 +425,5 @@ OSM.getMarker = function ({ icon = "dot", color = "var(--marker-red)", ...option
 OSM.noteMarkers = {
   "closed": OSM.getMarker({ icon: "tick", color: "var(--marker-green)" }),
   "new": OSM.getMarker({ icon: "plus", color: "var(--marker-blue)" }),
-  "open": OSM.getMarker({ icon: "cross", color: "var(--marker-red)" })
+  "open": OSM.getMarker({ icon: "exclam", color: "var(--marker-red)" })
 };
diff --git a/app/views/layouts/_markers.html.erb b/app/views/layouts/_markers.html.erb
index faa1cd9ac..b5849acf7 100644
--- a/app/views/layouts/_markers.html.erb
+++ b/app/views/layouts/_markers.html.erb
@@ -19,8 +19,8 @@
     <% markers = {
          "plus" => { :"stroke-linecap" => "round", :d => "M5.75 13h13.5m-6.75-6.75v13.5" },
          "tick" => { :"stroke-linecap" => "round", :"stroke-linejoin" => "round", :fill => "none", :d => "M7.157 14.649Q8.9 16 11.22 18.761 14.7 11.7 17.843 8.239" },
-         "cross" => { :"stroke-linecap" => "round", :d => "m7.5 8 10 10m0-10-10 10" },
          "minus" => { :"stroke-linecap" => "round", :d => "M5.75 13h13.5" },
+         "exclam" => { :"stroke-linecap" => "round", :fill => "none", :d => "M12.5 6.25V14.15m0 5.6v0" },
          "start" => { :"stroke-linejoin" => "round", :fill => "#fff", :d => "M5.5 13h7v7l5-12z" },
          "destination" => { :"stroke-linecap" => "round", :"stroke-linejoin" => "round", :fill => "#fff", :d => "M10 21 7 9c5-3 6 2 11 0l1 4c-5 2-6-3-11 0" },
          "dot" => { :"stroke-linecap" => "round", :fill => "#fff", :d => "M11.5 10a1 1 0 0 0 2 5 1 1 0 0 0-2-5" }
diff --git a/app/views/layouts/map.html.erb b/app/views/layouts/map.html.erb
index 89c77f654..55842b767 100644
--- a/app/views/layouts/map.html.erb
+++ b/app/views/layouts/map.html.erb
@@ -52,7 +52,7 @@
     <%= render :partial => "layouts/banner" %>
   </div>
 
-  <%= render :partial => "layouts/markers", :locals => { :types => %w[dot cross tick plus start destination] } %>
+  <%= render :partial => "layouts/markers", :locals => { :types => %w[dot exclam tick plus start destination] } %>
 
   <noscript>
     <div class="mt-5 p-3">
diff --git a/app/views/notes/index.html.erb b/app/views/notes/index.html.erb
index 78fb0bee1..241325c78 100644
--- a/app/views/notes/index.html.erb
+++ b/app/views/notes/index.html.erb
@@ -26,7 +26,7 @@
 <% else %>
   <%= render "notes_paging_nav", :page => @page, :next_page => @next_page, :params => @params %>
 
-  <%= render :partial => "layouts/markers", :locals => { :types => %w[cross tick minus] } %>
+  <%= render :partial => "layouts/markers", :locals => { :types => %w[exclam tick minus] } %>
 
   <table class="table table-sm note_list">
     <thead>
@@ -47,7 +47,7 @@
                          elsif note.closed?
                            { :alt_text => ".closed", :icon => "tick", :color => "var(--marker-green)" }
                          else
-                           { :alt_text => ".open", :icon => "cross", :color => "var(--marker-red)" }
+                           { :alt_text => ".open", :icon => "exclam", :color => "var(--marker-red)" }
                          end %>
         <svg width="25" height="40">
           <title><%= t note_marker[:alt_text] %></title>
-- 
2.47.3