From 5ee22cd407d836e195e3ea0d897dd015fd2f208e Mon Sep 17 00:00:00 2001
From: Anton Khorev <tony29@yandex.ru>
Date: Wed, 28 May 2025 13:01:41 +0300
Subject: [PATCH] Add social link controls using html template

---
 app/assets/javascripts/user.js   | 22 ++++++----------------
 app/views/profiles/show.html.erb |  8 ++++++++
 config/locales/en.yml            |  2 --
 3 files changed, 14 insertions(+), 18 deletions(-)

diff --git a/app/assets/javascripts/user.js b/app/assets/javascripts/user.js
index f9de24bc2..5d96ccf5f 100644
--- a/app/assets/javascripts/user.js
+++ b/app/assets/javascripts/user.js
@@ -14,22 +14,12 @@ $(function () {
   if ($("#social_links").length) {
     $("#add-social-link").click(function () {
       const newIndex = -Date.now();
-      const socialLinkForm = $(`
-        <div class="social-link-added-fields row mb-3">
-          <div class="col-sm-8">
-            <input class="form-control" type="text" name="user[social_links_attributes][${newIndex}][url]">
-          </div>
-          <button type="button" class="btn btn-outline-primary col-sm-2 align-self-start">${OSM.i18n.t("javascripts.social_links.remove")}</button>
-        </div>
-      `);
-
-      socialLinkForm.find("button").click(function () {
-        $(this).parent().remove();
-      });
-
-      $("#social_links").append(socialLinkForm);
-
-      socialLinkForm.find("input").trigger("focus");
+
+      $("#social_links template").contents().clone().appendTo("#social_links")
+        .find("input").attr("name", `user[social_links_attributes][${newIndex}][url]`).trigger("focus")
+        .end().find("button").on("click", function () {
+          $(this).parent().remove();
+        });
     });
 
     $(".social_link_destroy input[type='checkbox']").change(function () {
diff --git a/app/views/profiles/show.html.erb b/app/views/profiles/show.html.erb
index d09242024..e3e093e86 100644
--- a/app/views/profiles/show.html.erb
+++ b/app/views/profiles/show.html.erb
@@ -15,6 +15,14 @@
 
     <%= f.label t(".social_links.title"), :class => "form-label" %>
     <div id="social_links">
+      <template>
+        <div class="social-link-added-fields row mb-3">
+          <div class="col-sm-8">
+            <input class="form-control" type="text" autocomplete="off">
+          </div>
+          <button type="button" class="btn btn-outline-primary col-sm-2 align-self-start"><%= t(".social_links.remove") %></button>
+        </div>
+      </template>
       <%= f.fields_for :social_links do |social_link_form| %>
         <div class="social-link-fields row mb-3">
           <%= social_link_form.text_field :url, :hide_label => true, :wrapper_class => "col-sm-8" %>
diff --git a/config/locales/en.yml b/config/locales/en.yml
index 32d577db7..aa73fc0fc 100644
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -3343,8 +3343,6 @@ en:
       queryfeature_tooltip: Query features
       queryfeature_disabled_tooltip: Zoom in to query features
       embed_html_disabled: HTML embedding is not available for this map layer
-    social_links:
-      remove: Remove
     edit_help: Move the map and zoom in on a location you want to edit, then click here.
     directions:
       distance_in_units:
-- 
2.39.5