From 6abba8036fa753948a33144f2edaa06cd65b5b53 Mon Sep 17 00:00:00 2001 From: Anton Khorev Date: Fri, 23 May 2025 18:26:11 +0300 Subject: [PATCH] Move heatmaps controller tests --- .../users/heatmaps_controller_test.rb | 129 ++++++++++++++++++ test/controllers/users_controller_test.rb | 128 ----------------- 2 files changed, 129 insertions(+), 128 deletions(-) diff --git a/test/controllers/users/heatmaps_controller_test.rb b/test/controllers/users/heatmaps_controller_test.rb index 6d0524e95..5bbd71882 100644 --- a/test/controllers/users/heatmaps_controller_test.rb +++ b/test/controllers/users/heatmaps_controller_test.rb @@ -10,5 +10,134 @@ module Users { :controller => "users/heatmaps", :action => "show", :user_display_name => "username" } ) end + + def test_show_data + user = create(:user) + # Create two changesets + create(:changeset, :user => user, :created_at => 6.months.ago, :num_changes => 10) + create(:changeset, :user => user, :created_at => 3.months.ago, :num_changes => 20) + + get user_heatmap_path(user) + + assert_response :success + # The data should not be empty + heatmap_data = assigns(:heatmap_data) + assert_not_nil heatmap_data + assert_predicate heatmap_data[:data], :any? + # The data should be in the right format + heatmap_data[:data].each_value do |entry| + assert_equal [:date, :max_id, :total_changes], entry.keys.sort, "Heatmap data entries should have expected keys" + end + assert_equal 30, heatmap_data[:count] + end + + def test_show_data_caching + # Enable caching to be able to test + Rails.cache.clear + @original_cache_store = Rails.cache + Rails.cache = ActiveSupport::Cache::MemoryStore.new + + user = create(:user) + + # Create an initial changeset + create(:changeset, :user => user, :created_at => 6.months.ago, :num_changes => 15) + + # First request to populate the cache + get user_heatmap_path(user) + first_response_data = assigns(:heatmap_data) + assert_not_nil first_response_data, "Expected heatmap data to be assigned on the first request" + assert_equal 1, first_response_data[:data].values.count { |day| day[:total_changes].positive? }, "Expected one entry in the heatmap data" + + # Inspect cache after the first request + cached_data = Rails.cache.read("heatmap_data_of_user_#{user.id}") + assert_equal first_response_data, cached_data, "Expected the cache to contain the first response data" + + # Add a new changeset to the database + create(:changeset, :user => user, :created_at => 3.months.ago, :num_changes => 20) + + # Second request + get user_heatmap_path(user) + second_response_data = assigns(:heatmap_data) + + # Confirm that the cache is still being used + assert_equal first_response_data, second_response_data, "Expected cached data to be returned on the second request" + + # Clear the cache and make a third request to confirm new data is retrieved + Rails.cache.clear + get user_heatmap_path(user) + third_response_data = assigns(:heatmap_data) + + # Ensure the new entry is now included + assert_equal 2, third_response_data[:data].values.count { |day| day[:total_changes].positive? }, "Expected two entries in the heatmap data after clearing the cache" + + # Reset caching config to defaults + Rails.cache.clear + Rails.cache = @original_cache_store + end + + def test_show_data_no_changesets + user = create(:user) + + get user_heatmap_path(user) + + assert_response :success + assert_empty(assigns(:heatmap_data)[:data].values) + assert_select ".heatmap", :count => 0 + end + + def test_show_rendering_of_user_with_no_changesets + user_without_changesets = create(:user) + + get user_heatmap_path(user_without_changesets) + + assert_response :success + assert_select ".heatmap", 0 + end + + def test_show_rendering_of_user_with_changesets + user = create(:user) + changeset39 = create(:changeset, :user => user, :created_at => 4.months.ago.beginning_of_day, :num_changes => 39) + _changeset5 = create(:changeset, :user => user, :created_at => 3.months.ago.beginning_of_day, :num_changes => 5) + changeset11 = create(:changeset, :user => user, :created_at => 3.months.ago.beginning_of_day, :num_changes => 11) + + get user_heatmap_path(user) + + assert_response :success + assert_select ".heatmap a", 2 + + history_path = user_history_path(user) + assert_select ".heatmap a[data-date='#{4.months.ago.to_date}'][data-count='39'][href='#{history_path}?before=#{changeset39.id + 1}']" + assert_select ".heatmap a[data-date='#{3.months.ago.to_date}'][data-count='16'][href='#{history_path}?before=#{changeset11.id + 1}']" + assert_select ".heatmap [data-date='#{5.months.ago.to_date}']:not([data-count])" + end + + def test_headline_changeset_zero + user = create(:user) + + get user_heatmap_path(user) + + assert_response :success + assert_select "h2.text-body-secondary.fs-5", :count => 0 + end + + def test_headline_changeset_singular + user = create(:user) + create(:changeset, :user => user, :created_at => 4.months.ago.beginning_of_day, :num_changes => 1) + + get user_heatmap_path(user) + + assert_response :success + assert_select "h2.text-body-secondary.fs-5", :text => "1 contribution in the last year" + end + + def test_headline_changeset_plural + user = create(:user) + create(:changeset, :user => user, :created_at => 4.months.ago.beginning_of_day, :num_changes => 12) + + get user_heatmap_path(user) + + assert_response :success + assert_select "h2.text-body-secondary.fs-5", :text => "12 contributions in the last year" + end end end diff --git a/test/controllers/users_controller_test.rb b/test/controllers/users_controller_test.rb index 620435ec1..d0ad6c848 100644 --- a/test/controllers/users_controller_test.rb +++ b/test/controllers/users_controller_test.rb @@ -330,134 +330,6 @@ class UsersControllerTest < ActionDispatch::IntegrationTest assert_redirected_to login_path end - def test_show_heatmap_data - user = create(:user) - # Create two changesets - create(:changeset, :user => user, :created_at => 6.months.ago, :num_changes => 10) - create(:changeset, :user => user, :created_at => 3.months.ago, :num_changes => 20) - - get user_heatmap_path(user) - assert_response :success - # The data should not be empty - heatmap_data = assigns(:heatmap_data) - assert_not_nil heatmap_data - assert_predicate heatmap_data[:data], :any? - # The data should be in the right format - heatmap_data[:data].each_value do |entry| - assert_equal [:date, :max_id, :total_changes], entry.keys.sort, "Heatmap data entries should have expected keys" - end - assert_equal 30, heatmap_data[:count] - end - - def test_show_heatmap_data_caching - # Enable caching to be able to test - Rails.cache.clear - @original_cache_store = Rails.cache - Rails.cache = ActiveSupport::Cache::MemoryStore.new - - user = create(:user) - - # Create an initial changeset - create(:changeset, :user => user, :created_at => 6.months.ago, :num_changes => 15) - - # First request to populate the cache - get user_heatmap_path(user) - first_response_data = assigns(:heatmap_data) - assert_not_nil first_response_data, "Expected heatmap data to be assigned on the first request" - assert_equal 1, first_response_data[:data].values.count { |day| day[:total_changes].positive? }, "Expected one entry in the heatmap data" - - # Inspect cache after the first request - cached_data = Rails.cache.read("heatmap_data_of_user_#{user.id}") - assert_equal first_response_data, cached_data, "Expected the cache to contain the first response data" - - # Add a new changeset to the database - create(:changeset, :user => user, :created_at => 3.months.ago, :num_changes => 20) - - # Second request - get user_heatmap_path(user) - second_response_data = assigns(:heatmap_data) - - # Confirm that the cache is still being used - assert_equal first_response_data, second_response_data, "Expected cached data to be returned on the second request" - - # Clear the cache and make a third request to confirm new data is retrieved - Rails.cache.clear - get user_heatmap_path(user) - third_response_data = assigns(:heatmap_data) - - # Ensure the new entry is now included - assert_equal 2, third_response_data[:data].values.count { |day| day[:total_changes].positive? }, "Expected two entries in the heatmap data after clearing the cache" - - # Reset caching config to defaults - Rails.cache.clear - Rails.cache = @original_cache_store - end - - def test_show_heatmap_data_no_changesets - user = create(:user) - - get user_heatmap_path(user) - - assert_response :success - assert_empty(assigns(:heatmap_data)[:data].values) - assert_select ".heatmap", :count => 0 - end - - def test_show_heatmap_rendering_of_user_with_no_changesets - user_without_changesets = create(:user) - - get user_heatmap_path(user_without_changesets) - - assert_response :success - assert_select ".heatmap", 0 - end - - def test_show_heatmap_rendering_of_user_with_changesets - user = create(:user) - changeset39 = create(:changeset, :user => user, :created_at => 4.months.ago.beginning_of_day, :num_changes => 39) - _changeset5 = create(:changeset, :user => user, :created_at => 3.months.ago.beginning_of_day, :num_changes => 5) - changeset11 = create(:changeset, :user => user, :created_at => 3.months.ago.beginning_of_day, :num_changes => 11) - - get user_heatmap_path(user) - - assert_response :success - assert_select ".heatmap a", 2 - - history_path = user_history_path(user) - assert_select ".heatmap a[data-date='#{4.months.ago.to_date}'][data-count='39'][href='#{history_path}?before=#{changeset39.id + 1}']" - assert_select ".heatmap a[data-date='#{3.months.ago.to_date}'][data-count='16'][href='#{history_path}?before=#{changeset11.id + 1}']" - assert_select ".heatmap [data-date='#{5.months.ago.to_date}']:not([data-count])" - end - - def test_heatmap_headline_changset_zero - user = create(:user) - - get user_heatmap_path(user) - - assert_response :success - assert_select "h2.text-body-secondary.fs-5", :count => 0 - end - - def test_heatmap_headline_changeset_singular - user = create(:user) - create(:changeset, :user => user, :created_at => 4.months.ago.beginning_of_day, :num_changes => 1) - - get user_heatmap_path(user) - - assert_response :success - assert_select "h2.text-body-secondary.fs-5", :text => "1 contribution in the last year" - end - - def test_heatmap_headline_changeset_plural - user = create(:user) - create(:changeset, :user => user, :created_at => 4.months.ago.beginning_of_day, :num_changes => 12) - - get user_heatmap_path(user) - - assert_response :success - assert_select "h2.text-body-secondary.fs-5", :text => "12 contributions in the last year" - end - def test_show_profile_diaries user = create(:user) create(:language, :code => "en") -- 2.39.5