From 6fb502aff437c67155fc861fa3d6110c5be51670 Mon Sep 17 00:00:00 2001 From: Marwin Hochfelsner <50826859+hlfan@users.noreply.github.com> Date: Wed, 11 Feb 2026 18:58:15 +0000 Subject: [PATCH] Use double quotes for HTML atttribute values --- .herb.yml | 2 - app/views/accounts/terms/show.html.erb | 2 +- app/views/browse/_tag.html.erb | 4 +- app/views/browse/_tag_details.html.erb | 4 +- .../changeset_subscriptions/_heading.html.erb | 4 +- app/views/changesets/show.html.erb | 6 +-- app/views/confirmations/confirm.html.erb | 4 +- app/views/dashboards/_contact.html.erb | 6 +-- app/views/dashboards/show.html.erb | 4 +- app/views/diary_entries/_diary_entry.html.erb | 4 +- .../_diary_entry_heading.html.erb | 4 +- app/views/directions/show.html.erb | 2 +- app/views/elements/show.html.erb | 2 +- app/views/layouts/_header.html.erb | 20 +++++----- app/views/messages/show.html.erb | 2 +- app/views/notes/show.html.erb | 4 +- app/views/old_elements/_actions.html.erb | 2 +- app/views/old_elements/index.html.erb | 2 +- app/views/searches/queries/create.html.erb | 2 +- app/views/site/_any_questions.html.erb | 2 +- app/views/site/about.html.erb | 12 +++--- app/views/site/export.html.erb | 6 +-- app/views/site/fixthemap.html.erb | 12 +++--- app/views/site/help.html.erb | 12 +++--- app/views/site/id.html.erb | 2 +- app/views/site/welcome.html.erb | 22 +++++------ app/views/users/show.html.erb | 38 +++++++++---------- 27 files changed, 92 insertions(+), 94 deletions(-) diff --git a/.herb.yml b/.herb.yml index cec6f1173..5bf06ca3f 100644 --- a/.herb.yml +++ b/.herb.yml @@ -2,7 +2,5 @@ version: 0.8.9 linter: rules: - html-attribute-double-quotes: - enabled: false html-anchor-require-href: enabled: false diff --git a/app/views/accounts/terms/show.html.erb b/app/views/accounts/terms/show.html.erb index 29860535b..44ca46b14 100644 --- a/app/views/accounts/terms/show.html.erb +++ b/app/views/accounts/terms/show.html.erb @@ -4,7 +4,7 @@ <% content_for :heading_class, "pb-0" %> <% content_for :heading do %> -
+

<%= t ".heading" %>

<% end %> diff --git a/app/views/browse/_tag.html.erb b/app/views/browse/_tag.html.erb index f2e34d879..145d7e2fe 100644 --- a/app/views/browse/_tag.html.erb +++ b/app/views/browse/_tag.html.erb @@ -1,4 +1,4 @@ - <%= format_key(tag[0]) %> - <%= format_value(tag[0], tag[1]) %> + <%= format_key(tag[0]) %> + <%= format_value(tag[0], tag[1]) %> diff --git a/app/views/browse/_tag_details.html.erb b/app/views/browse/_tag_details.html.erb index cb876198c..24ac618d3 100644 --- a/app/views/browse/_tag_details.html.erb +++ b/app/views/browse/_tag_details.html.erb @@ -1,7 +1,7 @@ <% unless tag_details.empty? %>

<%= t ".tags" %>

-
- +
+
<%= render :partial => "browse/tag", :collection => tag_details.sort %>
diff --git a/app/views/changeset_subscriptions/_heading.html.erb b/app/views/changeset_subscriptions/_heading.html.erb index a1a2f7da1..9814556a7 100644 --- a/app/views/changeset_subscriptions/_heading.html.erb +++ b/app/views/changeset_subscriptions/_heading.html.erb @@ -1,5 +1,5 @@ <% title = changeset.comment || t(".title", :id => changeset.id) -%> -
+
<%= user_thumbnail changeset.user %> @@ -9,7 +9,7 @@
- + <%= t(".created_by_html", :link_user => link_to(changeset.user.display_name, changeset.user), :created => l(changeset.created_at, :format => :blog)) %>
diff --git a/app/views/changesets/show.html.erb b/app/views/changesets/show.html.erb index d3b42072e..1b0c65c44 100644 --- a/app/views/changesets/show.html.erb +++ b/app/views/changesets/show.html.erb @@ -39,7 +39,7 @@ <% @comments.each do |comment| %> <% next unless comment.visible || current_user&.moderator? %>
- + <%= comment_by_options = { :time_ago => friendly_date_ago(comment.created_at), :user => link_to(comment.author.display_name, comment.author) } comment.visible ? t(".comment_by_html", **comment_by_options) : t(".hidden_comment_by_html", **comment_by_options) %> @@ -101,14 +101,14 @@ <% end %>
-
+
<%= link_to t(".changesetxml"), api_changeset_path(@changeset) %> · <%= link_to t(".osmchangexml"), api_changeset_download_path(@changeset) %>
<% if @next_by_user || @prev_by_user %> -
+
<% if @prev_by_user %> <%= link_to @prev_by_user, :class => "icon-link" do %> <%= previous_page_svg_tag :height => 11 %> diff --git a/app/views/confirmations/confirm.html.erb b/app/views/confirmations/confirm.html.erb index edb0ec324..2472cfbd9 100644 --- a/app/views/confirmations/confirm.html.erb +++ b/app/views/confirmations/confirm.html.erb @@ -1,6 +1,6 @@ <% content_for :heading_class, "pb-0" %> <% content_for :heading do %> -
+

<%= t ".heading" %>

<% end %> @@ -28,7 +28,7 @@ -

+

<%= t ".if_need_resend" %>

<%= bootstrap_form_tag :url => url_for(:action => "confirm_resend") do |f| %> diff --git a/app/views/dashboards/_contact.html.erb b/app/views/dashboards/_contact.html.erb index 302e29f9d..f4cf79716 100644 --- a/app/views/dashboards/_contact.html.erb +++ b/app/views/dashboards/_contact.html.erb @@ -9,7 +9,7 @@ <%= user_thumbnail contact %>
-

+

<%= link_to contact.display_name, contact %> <% if current_user.home_location? and contact.home_location? %> <% distance = current_user.distance(contact) %> @@ -31,8 +31,8 @@ <% end %>

-