From 75d0e75ba0e9d1efea8222c1e5b2622f6aaa911e Mon Sep 17 00:00:00 2001 From: Anton Khorev Date: Wed, 30 Apr 2025 06:26:16 +0300 Subject: [PATCH] Update api changeset close test for non-creator --- .../api/changesets/closes_controller_test.rb | 21 +++++++++---------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/test/controllers/api/changesets/closes_controller_test.rb b/test/controllers/api/changesets/closes_controller_test.rb index 1bf187b6a..1fc845356 100644 --- a/test/controllers/api/changesets/closes_controller_test.rb +++ b/test/controllers/api/changesets/closes_controller_test.rb @@ -32,28 +32,27 @@ module Api assert_predicate changeset.reload, :open? end - def test_update_by_changeset_creator + def test_update_by_changeset_non_creator user = create(:user) - changeset = create(:changeset, :user => user) + changeset = create(:changeset) auth_header = bearer_authorization_header user put api_changeset_close_path(changeset), :headers => auth_header - assert_response :success - assert_not_predicate changeset.reload, :open? + assert_response :conflict + assert_equal "The user doesn't own that changeset", @response.body + assert_predicate changeset.reload, :open? end - ## - # test that a different user can't close another user's changeset - def test_update_invalid + def test_update_by_changeset_creator user = create(:user) - changeset = create(:changeset) - + changeset = create(:changeset, :user => user) auth_header = bearer_authorization_header user put api_changeset_close_path(changeset), :headers => auth_header - assert_response :conflict - assert_equal "The user doesn't own that changeset", @response.body + + assert_response :success + assert_not_predicate changeset.reload, :open? end ## -- 2.39.5