From 7c06f2b47e1ba7ec67e657c233a4add502493e6c Mon Sep 17 00:00:00 2001
From: Tom MacWright <tom@macwright.org>
Date: Mon, 10 Jun 2013 14:10:18 -0700
Subject: [PATCH] More refactoring of map js

---
 app/assets/javascripts/browse.js  | 14 +++++++-------
 app/assets/javascripts/map.js.erb | 20 ++++----------------
 2 files changed, 11 insertions(+), 23 deletions(-)

diff --git a/app/assets/javascripts/browse.js b/app/assets/javascripts/browse.js
index c459b77a5..02b54a8ed 100644
--- a/app/assets/javascripts/browse.js
+++ b/app/assets/javascripts/browse.js
@@ -34,9 +34,10 @@ $(document).ready(function () {
   });
 
   var params = $("#small_map").data();
+  var object, bbox;
   if (params.type == "changeset") {
-    var bbox = L.latLngBounds([params.minlat, params.minlon],
-                              [params.maxlat, params.maxlon]);
+    bbox = L.latLngBounds([params.minlat, params.minlon],
+        [params.maxlat, params.maxlon]);
 
     map.fitBounds(bbox);
 
@@ -55,13 +56,13 @@ $(document).ready(function () {
 
     updatelinks(map.getCenter(), 16, null, params.minlon, params.minlat, params.maxlon, params.maxlat);
   } else if (params.type == "note") {
-    var object = {type: params.type, id: params.id};
+    object = {type: params.type, id: params.id};
 
     map.setView([params.lat, params.lon], 16);
 
     L.marker([params.lat, params.lon], { icon: getUserIcon() }).addTo(map);
 
-    var bbox = map.getBounds();
+    bbox = map.getBounds();
 
     $("#loading").hide();
     $("#browse_map .geolink").show();
@@ -75,10 +76,9 @@ $(document).ready(function () {
                 bbox.getEast(), bbox.getNorth(),
                 object);
   } else {
-    $("#object_larger_map").hide();
-    $("#object_edit").hide();
+    $("#object_larger_map, #object_edit").hide();
 
-    var object = {type: params.type, id: params.id};
+    object = {type: params.type, id: params.id};
 
     if (!params.visible) {
       object.version = params.version - 1;
diff --git a/app/assets/javascripts/map.js.erb b/app/assets/javascripts/map.js.erb
index a7e9f6f50..1882fe4f4 100644
--- a/app/assets/javascripts/map.js.erb
+++ b/app/assets/javascripts/map.js.erb
@@ -59,13 +59,8 @@ function getUserIcon(url) {
 }
 
 function addObjectToMap(object, map, options) {
-  if (objectLoader) {
-    objectLoader.abort();
-  }
-
-  if (objectLayer) {
-    map.removeLayer(objectLayer);
-  }
+  if (objectLoader) objectLoader.abort();
+  if (objectLayer) map.removeLayer(objectLayer);
 
   objectLoader = $.ajax({
     url: OSM.apiUrl(object),
@@ -93,15 +88,8 @@ function addObjectToMap(object, map, options) {
 
       objectLayer.addData(xml);
 
-      var bounds = objectLayer.getBounds();
-
-      if (options.zoom) {
-        map.fitBounds(bounds);
-      }
-
-      if (options.callback) {
-        options.callback(bounds);
-      }
+      if (options.zoom) map.fitBounds(objectLayer.getBounds());
+      if (options.callback) options.callback(objectLayer.getBounds());
 
       objectLayer.addTo(map);
     }
-- 
2.43.2