From 91bd0b4b12469746a6e867332262907e35b2a013 Mon Sep 17 00:00:00 2001 From: Simon Legner Date: Thu, 27 Aug 2015 20:50:05 +0200 Subject: [PATCH 1/1] Display number of comments in changeset list --- app/assets/images/sprite.png | Bin 1926 -> 3371 bytes app/assets/images/sprite.svg | 8 +++++++- app/assets/stylesheets/common.scss | 10 ++++++++++ app/controllers/changeset_controller.rb | 2 +- app/views/changeset/_changeset.html.erb | 4 ++++ 5 files changed, 22 insertions(+), 2 deletions(-) diff --git a/app/assets/images/sprite.png b/app/assets/images/sprite.png index d5577d4b7121a50486799d697e50f189dcfc835f..c511bd90fbc7db6e940d6abce045033eca31df44 100644 GIT binary patch literal 3371 zcmeHJ`B#%!(gqbp6t!DKg=T3X$i9W8fd&RqGo##}+6_3mE za!PViQd07O^F=QyDQSI)Jt%una(m5A`%2US^aa32Rw5a)QFkQ%VU%+KT9VKC&yl{M zU2#+LcsBWxf3kNHA{iTgBU%cJ#Tp_Luc0HuQPGA;H)1M;zbZ*d9eoU3bnv-Zxx&l5 z8{~WT&FXCHltHaxAW_lbXI_&-MkA)-pl*cxf%biI5gfd>l4DF@pHQ*Db$~Q(e^XqK5+YaXz*AC_w>>P+x2_J**Ecp zojZD(!Rmr&uv$Z)24)!{se}>ziz*Sb-*_}ERa>!;1Hg@t&qlp;nm{Q$x=r2Qe?xmzPrB z8!VpPwd>Hpey<}H@}2kENmv5caXq-W2wp%W5|i{43wv=7a3U`t_~UF(#M7;c3_E+y zF`q6U=08aqpz8hP@Xo!LsISfsvw%fg*$2lK`>i`dPY8Pkc&)+^S=ukEy|_<8Bdk~j z+^Y`@#RKqvsiSuP{* zLg15&bJ%Z2z1~ywV=cC~pYQ0%Eq==as1K4|aPhY_ySel%d%sLNJx)dxyM3XTKQ}jL z1)b7DYL^ZL;ms%^JRUE!Ok@I-S5}grQvuH$2oP$6Rl~Q1GDpBHVr_@HmSEc0^(wOw zu^Cm)_q@hXgiXk2R1;QKmX-qXBM33zWl_Q7a5x2A;O_@A=8-s55BhudRUSC_JFo2vAt3^k6|0 zWB>MvH0aJ_!o3Ra*pnTspJumXe<%9|+(#p!TXTd?kEfRX0)@7A6N!;kG-`2bk-5&& z1B>jyMpk)KgqfBt(Hic5xXEgmp3h7quC+|6og41Zd5o@fl!H&K$1_Zf0i~lMrZmH? zX5}J-HxCwjY?U6qe)Fc-Ir=xZa3j*sdVVcIOTy4Qh4|e`z_v})aGr4pP>A5t`?LwOIM{1di$Vos3hhE<)vdV-IPPh_@StLpP8yMg#*pi z)zxWmzuZT)tnu-27ME+aAZ)meJnrG?DHciyrt3Fd%RHJ9C`yny-vD}6a8-`1erw;y zwgumFxd9vdRRX^6KICt~-&*q&ORF*J(2o1_kItYAR9=;c(7-HCR7(@PmYcRZKm(QR z4nk}fgm~BO;D=(q0MmfT=g_KKpl4nl+wX^R8&CtoL zQyzoG@{g%lC%2N;U!{11hPJ2=eLhvJ_&=ocUR|nN8d-)O+4zL6rZ_n{*~K6@`Gq^= zZQqx#z>p~p2V46Ztq=QRdruS36T8AGwH2lQBK45ZdQO0E#yc&#K8F0JxYuRtG3f`u zMj^S|PD=on2{jLR()`ay3I9sv?M6U%t_Jm_y=}2iLe9DfaKr6uY?w)3hz{%2OQBHc z0I=X4ml~rmI^BMD?sIBHSw%3!{g<6${ru&w!DEqcQ`%a0#r=4Gz_7I>rRn>eHhA2aeHBLoaYQzScOVGG7O*MyX zF>1sch}E6It9yB1$O%KcID|dWnn^55C+g+mXxTG#Mc1^39Oze~9OIMaKpRB1n3F!z@8YypC~tCs8{Gih!OHOVRxKoqmV)Q zXac467Nr4ky|-95X9gVf@S6UBSKXC6s!6Spu)GU(_rtZV0C zQSgW|v{h{GKf?v9l?_!bTJ6ofLLAq=W*F9trhh8I{KJ|ttdLRgUZZ#il49u_~7{x34|g}J2i!HVh9 zhzix?Ss18F;?A8zej8<}U;ccbh0WG>)9c#d3A3^?hJ2TB)>kxH&Y9)Gd#xq3B$QZw z)#@aUWhZ?tDk=(9oqKBW!^fnka5Pd%YkGz536 z>xE^>1k#_6YUhP9+DBpG?DFx@^H1kFHf;FQ2}N{QM`3>U&AT^LbhWC-Gq(kd{Nr)@ zz7uO+{m)cC9a%3DOMny1%H-@udOZbx_6FHzhFmizNQ;*%8$qtRVP zw%=|B(giav2gvN_bFTcvf~u28RvJ1w#Ia}EdQP@1dYvIpXNvoC4^chR9S>T{m*v3z zxc@hZbn`N9pe^+`ba^a}benV5tayR<48u!D%(bnJO@c5|r&%RY9@w@<2_)jzj6FNt z?A?9{uXK1mZsu#_OHAHLL>Cej7O{0lFf<;F>Cq&ZMHl{#7pC!WE2a(Uu46Cbq)W9h zn&l_W|F(}I+ccy}1T`_ZQZr!07yXRHo+j>S7 zB&CEs**#D;%D1GYhkWF}p*ty@9S4*7pFe+&28O4eriDE|7Yl&&?(CZz>;cPKS;$^_ z4q@J_jCUjX@M+cDmGe)kY_Qc$ze{i4Q??9gj~T6QX>4q?wZ?21vp7l^vg(<|?=1Ic zk>Y&1d`t_FvR@9lnN`q=T{BdWlQcEPl#suWoMgU_{W4Ml1h(3qAIy#4Y(m}I{X8)- zk?;J@CDUv2Xt;F8D1mJ4Ay F{|3A#F=hY& literal 1926 zcmb7Fdo+}J7@o<9tV=~~G=v?OL8z0;Q0})aBC5eK#kgO~5K>l>T!)xp3bB%F>ylwi zl(5u{A(pb`GB%QN%dL!LfBMdu)7k&_Ip=%7=l8zP^S;0L`(x(zXLS z;MfyPC#c*=nazWtyuQcb>P@ zIr?NGQipUC#l7V{cg=OBUY^$jRk_|XEt(id7Hy27`7Y4s#G;HYJ$>Dwav>|Ow%EP0w%v2%-J84}Tl*fv;*T((Ux4gcBpWe7uchK{NEZUunM3-P~ z$PCq|bVScC4^<|az_=7htgd<|v@eJ^yyT{iVlKd6!4Tp+uW^OLcVftuF&)u)eW<~> zY>r=9-9Bt3uYiU5>>d~)tt~0pC5t?KBiETGf{S$1h}F2h{3M;7LHOjpq>0dzLHQ@6 z{FxtD9kBj59agZ_#ArfU!dl1M-prM+`Ix+h!aJJG%)R?u!XFvXh#c?y&%=bB1j8zs zkzbAR=JwuN^`2Tfs=(CGQgC?>+9!4N$C6ICzd~I2;F0&$pbzpD;w$k0j9K$uS7Xd z?ELQ87Af$w>U(#O5L{=esnxYqcv+n*c9ms)_Co9B`VSfpoq`9%xJ?`>04;9)G8Km#fsrRjLP`eRN=ccKN6}{&K&+piNt06n- za%oOgBFR^EWAt%}r7cfrtkzY1&xg~xrxHol!!5K2xHW%H$dZChbJEcw+fYw*(ff;m zT)Wxn`m7bkV|e4V>VxCQk4)AM!ZY5YLj*f$2Y9Y!^V*gv_EdUePG?Mav#^hcOE7wc zTc3Ey{xzm8rlZ*jpS-pn-i|xlk7$f)UJs*@l}F6n=5xs0@VP1hwZ{VqIg&BWcGGMk zgH|uSc}V5{NYB#)E5XsBC&54CGo7xdT%6=9guFcXS^Gce)h(tcv! IOz?640?rxung9R* diff --git a/app/assets/images/sprite.svg b/app/assets/images/sprite.svg index b50b969e9..92350301d 100644 --- a/app/assets/images/sprite.svg +++ b/app/assets/images/sprite.svg @@ -13,7 +13,7 @@ height="200" id="svg2" version="1.1" - inkscape:version="0.48.4 r9939" + inkscape:version="0.91 r13725" inkscape:export-filename="/home/tom/rails/app/assets/images/sprite.png" inkscape:export-xdpi="90" inkscape:export-ydpi="90" @@ -280,5 +280,11 @@ id="tspan3023" x="264.8125" y="869.62622">? + diff --git a/app/assets/stylesheets/common.scss b/app/assets/stylesheets/common.scss index 6706aa6ed..009082e28 100644 --- a/app/assets/stylesheets/common.scss +++ b/app/assets/stylesheets/common.scss @@ -175,6 +175,7 @@ small, aside { .icon.close:hover { background-position: -200px -20px; } .icon.check { background-position: -220px 0; } .icon.note { background-position: -240px 0; } +.icon.note.grey { background-position: -240px -20px; } .icon.query { background-position: -260px 0; } /* Rules for links */ @@ -1059,6 +1060,15 @@ tr.turn:hover { color: #000; } } + + .comments { + float: right; + color: #999; + } + + .comments-0 { + opacity: 0.5; + } } /* Rules for the browse sidebar */ diff --git a/app/controllers/changeset_controller.rb b/app/controllers/changeset_controller.rb index 2ce024c76..5b55980e3 100644 --- a/app/controllers/changeset_controller.rb +++ b/app/controllers/changeset_controller.rb @@ -294,7 +294,7 @@ class ChangesetController < ApplicationController changesets = changesets.where("changesets.id <= ?", params[:max_id]) end - @edits = changesets.order("changesets.id DESC").limit(20).preload(:user, :changeset_tags) + @edits = changesets.order("changesets.id DESC").limit(20).preload(:user, :changeset_tags, :comments) render :action => :list, :layout => false end diff --git a/app/views/changeset/_changeset.html.erb b/app/views/changeset/_changeset.html.erb index cbc60695b..f27b0bc91 100644 --- a/app/views/changeset/_changeset.html.erb +++ b/app/views/changeset/_changeset.html.erb @@ -18,6 +18,10 @@ <%= changeset.tags['comment'].to_s.presence || t('browse.no_comment') %> +
+ <%= changeset.comments.length %> + +
<%= changeset_details(changeset) %> · -- 2.43.2