From 94062a17b3e2ee1984b7bc2b744945d5aa7bf2e9 Mon Sep 17 00:00:00 2001 From: Herve Saint-Amand Date: Fri, 30 Dec 2016 23:45:32 +0000 Subject: [PATCH] Cleaned up HTML Removed some cargo-cult HTML attributes and CSS. Styling HTML for email clients is trickier than for browsers, I'm trying to keep the code as succinct but also as compatible as possible. --- .../changeset_comment_notification.html.erb | 33 ++++++++++--------- 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/app/views/notifier/changeset_comment_notification.html.erb b/app/views/notifier/changeset_comment_notification.html.erb index 3aaf9fb9e..752f6c0f4 100644 --- a/app/views/notifier/changeset_comment_notification.html.erb +++ b/app/views/notifier/changeset_comment_notification.html.erb @@ -3,18 +3,18 @@ - - + +

- +

+ - -

<%= image_tag attachments["osm_logo_30x30.png"].url, alt: "OpenStreetMap logo", title: "OpenStreetMap", height: "30", width: "30", border: "0" %>

OpenStreetMap

@@ -22,10 +22,10 @@

- +

- @@ -59,10 +59,11 @@ -

<% if @owner %> <%= t "notifier.changeset_comment_notification.commented.your_changeset_html", :commenter => @commenter, :commenter_url => @commenter_url, :time => @time %> <% else %> @@ -37,18 +37,18 @@ <%= t "notifier.changeset_comment_notification.commented.partial_changeset_without_comment" %> <% end %>

- +

- -

<%= image_tag attachments["avatar.png"].url, alt: @commenter %>

<%= @comment.to_html %>

<%= raw t 'notifier.changeset_comment_notification.details_html', :url => link_to(@changeset_url, @changeset_url) %>

+ <%= raw t 'notifier.changeset_comment_notification.details_html', :url => link_to(@changeset_url, @changeset_url) %>

- Unsubscribe - from updates to this changeset + To unsubscribe from updates to this changeset, visit + <%= @changeset_url %> + and click 'Unsubscribe'

OpenStreetMap.org -- 2.43.2