From 9db613369105d051eda5af3cfc33358c8313f77a Mon Sep 17 00:00:00 2001 From: Anton Khorev Date: Wed, 2 Apr 2025 06:57:27 +0300 Subject: [PATCH] Style load more changesets buttons like pagination links --- app/assets/javascripts/index/history.js | 2 +- app/views/changesets/index.html.erb | 16 ++++++++++++---- config/locales/en.yml | 3 ++- test/system/history_test.rb | 10 +++++----- 4 files changed, 20 insertions(+), 11 deletions(-) diff --git a/app/assets/javascripts/index/history.js b/app/assets/javascripts/index/history.js index a23a198df..76a2e9b4b 100644 --- a/app/assets/javascripts/index/history.js +++ b/app/assets/javascripts/index/history.js @@ -173,7 +173,7 @@ OSM.History = function (map) { const div = $(this).parents(".changeset_more"); - $(this).hide(); + $(this).closest(".pagination").hide(); div.find(".loader").show(); const data = new URLSearchParams(); diff --git a/app/views/changesets/index.html.erb b/app/views/changesets/index.html.erb index d6b074461..865d88043 100644 --- a/app/views/changesets/index.html.erb +++ b/app/views/changesets/index.html.erb @@ -1,6 +1,10 @@ <% if @newer_changesets_id %> -
- <%= link_to t(".load_more"), url_for(:after => @newer_changesets_id), :class => "btn btn-primary" %> +
+
    +
  • + <%= link_to t(".newer_changesets"), url_for(:after => @newer_changesets_id), :class => "page-link" %> +
  • +
<%= t("browse.start_rjs.loading") %> @@ -20,8 +24,12 @@

<%= params[:before] ? t(".no_more") : t(".empty") %>

<% end %> <% if @older_changesets_id -%> -
- <%= link_to t(".load_more"), url_for(:before => @older_changesets_id), :class => "btn btn-primary" %> +
+
    +
  • + <%= link_to t(".older_changesets"), url_for(:before => @older_changesets_id), :class => "page-link" %> +
  • +
<%= t("browse.start_rjs.loading") %> diff --git a/config/locales/en.yml b/config/locales/en.yml index a2b15d754..16b967ead 100644 --- a/config/locales/en.yml +++ b/config/locales/en.yml @@ -494,7 +494,8 @@ en: no_more: "No more changesets found." no_more_area: "No more changesets in this area." no_more_user: "No more changesets by this user." - load_more: "Load more" + older_changesets: Older Changesets + newer_changesets: Newer Changesets feed: title: "Changeset %{id}" title_comment: "Changeset %{id} - %{comment}" diff --git a/test/system/history_test.rb b/test/system/history_test.rb index be7700c3b..37b5cd0aa 100644 --- a/test/system/history_test.rb +++ b/test/system/history_test.rb @@ -35,21 +35,21 @@ class HistoryTest < ApplicationSystemTestCase changesets.assert_no_text "bottom-changeset-in-batch-2" changesets.assert_no_text "first-changeset-in-history" changesets.assert_selector "ol", :count => 1 - changesets.assert_selector "li", :count => PAGE_SIZE + changesets.assert_selector "li[data-changeset]", :count => PAGE_SIZE - changesets.find(".changeset_more a.btn").click + click_on "Older Changesets" changesets.assert_text "bottom-changeset-in-batch-1" changesets.assert_text "bottom-changeset-in-batch-2" changesets.assert_no_text "first-changeset-in-history" changesets.assert_selector "ol", :count => 1 - changesets.assert_selector "li", :count => 2 * PAGE_SIZE + changesets.assert_selector "li[data-changeset]", :count => 2 * PAGE_SIZE - changesets.find(".changeset_more a.btn").click + click_on "Older Changesets" changesets.assert_text "bottom-changeset-in-batch-1" changesets.assert_text "bottom-changeset-in-batch-2" changesets.assert_text "first-changeset-in-history" changesets.assert_selector "ol", :count => 1 - changesets.assert_selector "li", :count => (2 * PAGE_SIZE) + 1 + changesets.assert_selector "li[data-changeset]", :count => (2 * PAGE_SIZE) + 1 end end -- 2.39.5