From a0666021d9d251a9d9cf5a8ee1ddcd3527937368 Mon Sep 17 00:00:00 2001 From: Marwin Hochfelsner <50826859+hlfan@users.noreply.github.com> Date: Fri, 18 Jul 2025 16:38:16 +0200 Subject: [PATCH] Inline social link icons --- app/assets/images/social_link_icons/bluesky.svg | 2 +- app/assets/images/social_link_icons/discord.svg | 2 +- app/assets/images/social_link_icons/facebook.svg | 2 +- app/assets/images/social_link_icons/flickr.svg | 2 +- app/assets/images/social_link_icons/github.svg | 2 +- app/assets/images/social_link_icons/gitlab.svg | 2 +- app/assets/images/social_link_icons/hdyc.svg | 6 +++--- app/assets/images/social_link_icons/hot.svg | 8 ++++---- app/assets/images/social_link_icons/instagram.svg | 2 +- app/assets/images/social_link_icons/line.svg | 2 +- app/assets/images/social_link_icons/linkedin.svg | 2 +- app/assets/images/social_link_icons/mapillary.svg | 2 +- app/assets/images/social_link_icons/mastodon.svg | 2 +- app/assets/images/social_link_icons/medium.svg | 2 +- app/assets/images/social_link_icons/ogf.svg | 2 +- app/assets/images/social_link_icons/quora.svg | 2 +- app/assets/images/social_link_icons/reddit.svg | 2 +- app/assets/images/social_link_icons/slack.svg | 2 +- app/assets/images/social_link_icons/snapchat.svg | 2 +- app/assets/images/social_link_icons/stackoverflow.svg | 2 +- app/assets/images/social_link_icons/strava.svg | 2 +- app/assets/images/social_link_icons/substack.svg | 2 +- app/assets/images/social_link_icons/telegram.svg | 2 +- app/assets/images/social_link_icons/threads.svg | 2 +- app/assets/images/social_link_icons/tiktok.svg | 2 +- app/assets/images/social_link_icons/twitch.svg | 2 +- app/assets/images/social_link_icons/twitter_x.svg | 2 +- app/assets/images/social_link_icons/vimeo.svg | 2 +- app/assets/images/social_link_icons/website.svg | 2 +- app/assets/images/social_link_icons/whatsapp.svg | 2 +- app/assets/images/social_link_icons/wikidata.svg | 2 +- app/assets/images/social_link_icons/wikimedia.svg | 4 ++-- app/assets/images/social_link_icons/wikipedia.svg | 2 +- app/assets/images/social_link_icons/wikivoyage.svg | 2 +- app/assets/images/social_link_icons/youtube.svg | 2 +- app/assets/stylesheets/common.scss | 8 -------- app/views/social_links/_show.html.erb | 6 +++--- test/controllers/profiles/links_controller_test.rb | 2 +- 38 files changed, 45 insertions(+), 53 deletions(-) diff --git a/app/assets/images/social_link_icons/bluesky.svg b/app/assets/images/social_link_icons/bluesky.svg index 0cbe91f4d..f24529db2 100644 --- a/app/assets/images/social_link_icons/bluesky.svg +++ b/app/assets/images/social_link_icons/bluesky.svg @@ -1,4 +1,4 @@ - + \ No newline at end of file diff --git a/app/assets/images/social_link_icons/discord.svg b/app/assets/images/social_link_icons/discord.svg index 5f5bdd6aa..f051baff4 100644 --- a/app/assets/images/social_link_icons/discord.svg +++ b/app/assets/images/social_link_icons/discord.svg @@ -1,3 +1,3 @@ - + \ No newline at end of file diff --git a/app/assets/images/social_link_icons/facebook.svg b/app/assets/images/social_link_icons/facebook.svg index e9e796354..17c6a9774 100644 --- a/app/assets/images/social_link_icons/facebook.svg +++ b/app/assets/images/social_link_icons/facebook.svg @@ -1,3 +1,3 @@ - + \ No newline at end of file diff --git a/app/assets/images/social_link_icons/flickr.svg b/app/assets/images/social_link_icons/flickr.svg index 54b080805..d8484d117 100644 --- a/app/assets/images/social_link_icons/flickr.svg +++ b/app/assets/images/social_link_icons/flickr.svg @@ -1,4 +1,4 @@ - + \ No newline at end of file diff --git a/app/assets/images/social_link_icons/github.svg b/app/assets/images/social_link_icons/github.svg index 51b1a8001..adb2392a7 100644 --- a/app/assets/images/social_link_icons/github.svg +++ b/app/assets/images/social_link_icons/github.svg @@ -1,3 +1,3 @@ - + \ No newline at end of file diff --git a/app/assets/images/social_link_icons/gitlab.svg b/app/assets/images/social_link_icons/gitlab.svg index 760ea7c6c..5c3671598 100644 --- a/app/assets/images/social_link_icons/gitlab.svg +++ b/app/assets/images/social_link_icons/gitlab.svg @@ -1,3 +1,3 @@ - + \ No newline at end of file diff --git a/app/assets/images/social_link_icons/hdyc.svg b/app/assets/images/social_link_icons/hdyc.svg index 0cbce4526..11602ed22 100644 --- a/app/assets/images/social_link_icons/hdyc.svg +++ b/app/assets/images/social_link_icons/hdyc.svg @@ -1,7 +1,7 @@ diff --git a/app/assets/images/social_link_icons/hot.svg b/app/assets/images/social_link_icons/hot.svg index f90d3bee8..0b1c97c14 100644 --- a/app/assets/images/social_link_icons/hot.svg +++ b/app/assets/images/social_link_icons/hot.svg @@ -1,8 +1,8 @@ diff --git a/app/assets/images/social_link_icons/instagram.svg b/app/assets/images/social_link_icons/instagram.svg index 2724fbd5b..1efe3a17d 100644 --- a/app/assets/images/social_link_icons/instagram.svg +++ b/app/assets/images/social_link_icons/instagram.svg @@ -1,3 +1,3 @@ - + \ No newline at end of file diff --git a/app/assets/images/social_link_icons/line.svg b/app/assets/images/social_link_icons/line.svg index 3808c88e2..f1525f24a 100644 --- a/app/assets/images/social_link_icons/line.svg +++ b/app/assets/images/social_link_icons/line.svg @@ -1,3 +1,3 @@ - + \ No newline at end of file diff --git a/app/assets/images/social_link_icons/linkedin.svg b/app/assets/images/social_link_icons/linkedin.svg index 59f2e4533..b1033787d 100644 --- a/app/assets/images/social_link_icons/linkedin.svg +++ b/app/assets/images/social_link_icons/linkedin.svg @@ -1,3 +1,3 @@ - + \ No newline at end of file diff --git a/app/assets/images/social_link_icons/mapillary.svg b/app/assets/images/social_link_icons/mapillary.svg index 20e6b022c..12a3c0b00 100644 --- a/app/assets/images/social_link_icons/mapillary.svg +++ b/app/assets/images/social_link_icons/mapillary.svg @@ -1,4 +1,4 @@ - + diff --git a/app/assets/images/social_link_icons/mastodon.svg b/app/assets/images/social_link_icons/mastodon.svg index 44a2730f3..71db7c7bc 100644 --- a/app/assets/images/social_link_icons/mastodon.svg +++ b/app/assets/images/social_link_icons/mastodon.svg @@ -1,3 +1,3 @@ - + \ No newline at end of file diff --git a/app/assets/images/social_link_icons/medium.svg b/app/assets/images/social_link_icons/medium.svg index b0c359ec8..dca096087 100644 --- a/app/assets/images/social_link_icons/medium.svg +++ b/app/assets/images/social_link_icons/medium.svg @@ -1,3 +1,3 @@ - + \ No newline at end of file diff --git a/app/assets/images/social_link_icons/ogf.svg b/app/assets/images/social_link_icons/ogf.svg index 27d7a5bc8..d3cb6dc2d 100644 --- a/app/assets/images/social_link_icons/ogf.svg +++ b/app/assets/images/social_link_icons/ogf.svg @@ -1,5 +1,5 @@ - + diff --git a/app/assets/images/social_link_icons/quora.svg b/app/assets/images/social_link_icons/quora.svg index e18e02e3f..c32bec83a 100644 --- a/app/assets/images/social_link_icons/quora.svg +++ b/app/assets/images/social_link_icons/quora.svg @@ -1,3 +1,3 @@ - + \ No newline at end of file diff --git a/app/assets/images/social_link_icons/reddit.svg b/app/assets/images/social_link_icons/reddit.svg index dba2cb3f4..d0dd512e4 100644 --- a/app/assets/images/social_link_icons/reddit.svg +++ b/app/assets/images/social_link_icons/reddit.svg @@ -1,4 +1,4 @@ - + \ No newline at end of file diff --git a/app/assets/images/social_link_icons/slack.svg b/app/assets/images/social_link_icons/slack.svg index 469831447..e6215ddb5 100644 --- a/app/assets/images/social_link_icons/slack.svg +++ b/app/assets/images/social_link_icons/slack.svg @@ -1,3 +1,3 @@ - + \ No newline at end of file diff --git a/app/assets/images/social_link_icons/snapchat.svg b/app/assets/images/social_link_icons/snapchat.svg index a19a51993..ce91c576a 100644 --- a/app/assets/images/social_link_icons/snapchat.svg +++ b/app/assets/images/social_link_icons/snapchat.svg @@ -1,3 +1,3 @@ - + \ No newline at end of file diff --git a/app/assets/images/social_link_icons/stackoverflow.svg b/app/assets/images/social_link_icons/stackoverflow.svg index 24aaca0ac..39a70dc90 100644 --- a/app/assets/images/social_link_icons/stackoverflow.svg +++ b/app/assets/images/social_link_icons/stackoverflow.svg @@ -1,4 +1,4 @@ - + \ No newline at end of file diff --git a/app/assets/images/social_link_icons/strava.svg b/app/assets/images/social_link_icons/strava.svg index 8e8625c16..7f472f879 100644 --- a/app/assets/images/social_link_icons/strava.svg +++ b/app/assets/images/social_link_icons/strava.svg @@ -1,3 +1,3 @@ - + \ No newline at end of file diff --git a/app/assets/images/social_link_icons/substack.svg b/app/assets/images/social_link_icons/substack.svg index d0d6d6d3a..0bfc641cc 100644 --- a/app/assets/images/social_link_icons/substack.svg +++ b/app/assets/images/social_link_icons/substack.svg @@ -1,3 +1,3 @@ - + \ No newline at end of file diff --git a/app/assets/images/social_link_icons/telegram.svg b/app/assets/images/social_link_icons/telegram.svg index 1b77dce2a..a301d8b8e 100644 --- a/app/assets/images/social_link_icons/telegram.svg +++ b/app/assets/images/social_link_icons/telegram.svg @@ -1,3 +1,3 @@ - + \ No newline at end of file diff --git a/app/assets/images/social_link_icons/threads.svg b/app/assets/images/social_link_icons/threads.svg index 99ec96289..f05f71473 100644 --- a/app/assets/images/social_link_icons/threads.svg +++ b/app/assets/images/social_link_icons/threads.svg @@ -1,3 +1,3 @@ - + \ No newline at end of file diff --git a/app/assets/images/social_link_icons/tiktok.svg b/app/assets/images/social_link_icons/tiktok.svg index 18f99ae1e..d38ae4e58 100644 --- a/app/assets/images/social_link_icons/tiktok.svg +++ b/app/assets/images/social_link_icons/tiktok.svg @@ -1,3 +1,3 @@ - + \ No newline at end of file diff --git a/app/assets/images/social_link_icons/twitch.svg b/app/assets/images/social_link_icons/twitch.svg index 8e3ac6fbf..5f956e3cc 100644 --- a/app/assets/images/social_link_icons/twitch.svg +++ b/app/assets/images/social_link_icons/twitch.svg @@ -1,4 +1,4 @@ - + \ No newline at end of file diff --git a/app/assets/images/social_link_icons/twitter_x.svg b/app/assets/images/social_link_icons/twitter_x.svg index d51006674..e570b4552 100644 --- a/app/assets/images/social_link_icons/twitter_x.svg +++ b/app/assets/images/social_link_icons/twitter_x.svg @@ -1,3 +1,3 @@ - + \ No newline at end of file diff --git a/app/assets/images/social_link_icons/vimeo.svg b/app/assets/images/social_link_icons/vimeo.svg index 13c9fcf58..5b496a935 100644 --- a/app/assets/images/social_link_icons/vimeo.svg +++ b/app/assets/images/social_link_icons/vimeo.svg @@ -1,3 +1,3 @@ - + \ No newline at end of file diff --git a/app/assets/images/social_link_icons/website.svg b/app/assets/images/social_link_icons/website.svg index b78b4c73d..cb6337b3b 100644 --- a/app/assets/images/social_link_icons/website.svg +++ b/app/assets/images/social_link_icons/website.svg @@ -1,3 +1,3 @@ - + \ No newline at end of file diff --git a/app/assets/images/social_link_icons/whatsapp.svg b/app/assets/images/social_link_icons/whatsapp.svg index e24000ea4..5a6fb3b41 100644 --- a/app/assets/images/social_link_icons/whatsapp.svg +++ b/app/assets/images/social_link_icons/whatsapp.svg @@ -1,3 +1,3 @@ - + \ No newline at end of file diff --git a/app/assets/images/social_link_icons/wikidata.svg b/app/assets/images/social_link_icons/wikidata.svg index 546a06ae1..78dee2950 100644 --- a/app/assets/images/social_link_icons/wikidata.svg +++ b/app/assets/images/social_link_icons/wikidata.svg @@ -1,5 +1,5 @@ - + diff --git a/app/assets/images/social_link_icons/wikimedia.svg b/app/assets/images/social_link_icons/wikimedia.svg index 6a06c2cd4..c18530417 100644 --- a/app/assets/images/social_link_icons/wikimedia.svg +++ b/app/assets/images/social_link_icons/wikimedia.svg @@ -1,5 +1,5 @@ - + @@ -12,7 +12,7 @@ - + \ No newline at end of file diff --git a/app/assets/images/social_link_icons/wikipedia.svg b/app/assets/images/social_link_icons/wikipedia.svg index bbfc4659d..312d7b183 100644 --- a/app/assets/images/social_link_icons/wikipedia.svg +++ b/app/assets/images/social_link_icons/wikipedia.svg @@ -1,3 +1,3 @@ - + \ No newline at end of file diff --git a/app/assets/images/social_link_icons/wikivoyage.svg b/app/assets/images/social_link_icons/wikivoyage.svg index f9367b03c..0a777c755 100644 --- a/app/assets/images/social_link_icons/wikivoyage.svg +++ b/app/assets/images/social_link_icons/wikivoyage.svg @@ -1,6 +1,6 @@ - + diff --git a/app/assets/images/social_link_icons/youtube.svg b/app/assets/images/social_link_icons/youtube.svg index 38b2704b0..dbac5cf4f 100644 --- a/app/assets/images/social_link_icons/youtube.svg +++ b/app/assets/images/social_link_icons/youtube.svg @@ -1,3 +1,3 @@ - + \ No newline at end of file diff --git a/app/assets/stylesheets/common.scss b/app/assets/stylesheets/common.scss index 31a4188b8..ced3ef44a 100644 --- a/app/assets/stylesheets/common.scss +++ b/app/assets/stylesheets/common.scss @@ -970,14 +970,6 @@ img.trace_image { } } -/* Rules for the social links */ - -@include color-mode(dark) { - .social_links img { - filter: invert(1); - } -} - /* Rules for the heatmap */ .heatmap { diff --git a/app/views/social_links/_show.html.erb b/app/views/social_links/_show.html.erb index f54ac6377..68ff0bdcf 100644 --- a/app/views/social_links/_show.html.erb +++ b/app/views/social_links/_show.html.erb @@ -2,9 +2,9 @@ <% social_links.each do |social_link| %>
  • <%= link_to social_link.parsed[:url], :class => "icon-link mw-100 text-body-secondary mb-2", :rel => "nofollow me" do %> - <%= image_tag "social_link_icons/#{social_link.parsed[:platform].nil? ? 'website' : social_link.parsed[:platform]}.svg", - :alt => social_link.parsed[:platform].nil? ? t(".website") : social_link.parsed[:platform], - :size => "16" %> + <%= inline_svg_tag "social_link_icons/#{social_link.parsed[:platform] || 'website'}.svg", + :title => social_link.parsed[:platform] || t(".website"), + :class => "flex-shrink-0" %> <%= social_link.parsed[:name] %> diff --git a/test/controllers/profiles/links_controller_test.rb b/test/controllers/profiles/links_controller_test.rb index 97830e27b..3c0788d16 100644 --- a/test/controllers/profiles/links_controller_test.rb +++ b/test/controllers/profiles/links_controller_test.rb @@ -42,7 +42,7 @@ module Profiles assert_response :success assert_template :show assert_dom ".alert-success", :text => "Profile links updated." - assert_dom "a", "test.com/test" + assert_dom "a[href*='test.com/test'] span", "test.com/test" end def test_update_empty_social_link -- 2.39.5