From a6cfa6f93d5a8b72d6774e6aa85ca93f6bd071ad Mon Sep 17 00:00:00 2001
From: Anton Khorev <tony29@yandex.ru>
Date: Sun, 15 Jun 2025 15:33:09 +0300
Subject: [PATCH] Remove event listener duplication on units buttons

---
 .../javascripts/index/directions-route-output.js     | 12 +++---------
 app/views/directions/show.html.erb                   |  6 +++---
 2 files changed, 6 insertions(+), 12 deletions(-)

diff --git a/app/assets/javascripts/index/directions-route-output.js b/app/assets/javascripts/index/directions-route-output.js
index 3d3773331..f3de773e1 100644
--- a/app/assets/javascripts/index/directions-route-output.js
+++ b/app/assets/javascripts/index/directions-route-output.js
@@ -122,13 +122,8 @@ OSM.DirectionsRouteOutput = function (map) {
     writeSummary(route);
     writeSteps(route);
 
-    $("#directions_distance_units_km").off().on("change", () => {
-      distanceUnits = "km";
-      writeSummary(route);
-      writeSteps(route);
-    });
-    $("#directions_distance_units_mi").off().on("change", () => {
-      distanceUnits = "mi";
+    $("#directions_distance_units_settings input").off().on("change", function () {
+      distanceUnits = this.value;
       writeSummary(route);
       writeSteps(route);
     });
@@ -156,8 +151,7 @@ OSM.DirectionsRouteOutput = function (map) {
       .removeLayer(popup)
       .removeLayer(polyline);
 
-    $("#directions_distance_units_km").off();
-    $("#directions_distance_units_mi").off();
+    $("#directions_distance_units_settings input").off();
 
     $("#directions_route_steps").empty();
 
diff --git a/app/views/directions/show.html.erb b/app/views/directions/show.html.erb
index ff6109483..a55efd426 100644
--- a/app/views/directions/show.html.erb
+++ b/app/views/directions/show.html.erb
@@ -89,12 +89,12 @@
 <div id="directions_error" hidden></div>
 
 <div id="directions_route" hidden>
-  <div>
+  <div id="directions_distance_units_settings">
     <div class="btn-group btn-group-sm w-100">
-      <input type="radio" class="btn-check" name="directions_distance_units" id="directions_distance_units_km" autocomplete="off" checked>
+      <input type="radio" class="btn-check" name="directions_distance_units" value="km" id="directions_distance_units_km" autocomplete="off" checked>
       <label class="btn btn-outline-secondary p-0 px-1" for="directions_distance_units_km"><%= t ".kilometers" %></label>
 
-      <input type="radio" class="btn-check" name="directions_distance_units" id="directions_distance_units_mi" autocomplete="off">
+      <input type="radio" class="btn-check" name="directions_distance_units" value="mi" id="directions_distance_units_mi" autocomplete="off">
       <label class="btn btn-outline-secondary p-0 px-1" for="directions_distance_units_mi"><%= t ".miles_feet" %></label>
     </div>
   </div>
-- 
2.39.5