From ae8f2e9bb0d3c1ff083d375491ef0498d3560b68 Mon Sep 17 00:00:00 2001 From: Andy Allan Date: Wed, 14 Jan 2026 11:31:27 +0000 Subject: [PATCH] Update rubocop_todo.yml --- .rubocop_todo.yml | 85 ++++++++++++++++++++--------------------------- 1 file changed, 36 insertions(+), 49 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 93c040086..a416804f9 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,19 +1,16 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2024-08-27 18:01:13 UTC using RuboCop version 1.65.1. +# on 2026-01-14 11:29:44 UTC using RuboCop version 1.82.1. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 13 -# Configuration parameters: Include, MaxAmount. -# Include: **/*_spec.rb, **/spec/**/*, **/test/**/*, **/features/support/factories/**/*.rb +# Offense count: 14 +# Configuration parameters: MaxAmount. FactoryBot/ExcessiveCreateList: Exclude: - - 'test/controllers/api/changeset_comments_controller_test.rb' - 'test/controllers/api/messages/inboxes_controller_test.rb' - - 'test/controllers/api/messages/outboxes_controller_test.rb' - 'test/controllers/changesets_controller_test.rb' - 'test/controllers/diary_entries_controller_test.rb' - 'test/controllers/notes_controller_test.rb' @@ -23,14 +20,7 @@ FactoryBot/ExcessiveCreateList: - 'test/controllers/users/received_blocks_controller_test.rb' - 'test/system/users_test.rb' -# Offense count: 635 -# This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns. -# URISchemes: http, https -Layout/LineLength: - Max: 234 - -# Offense count: 23 +# Offense count: 19 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: AllowSafeAssignment. Lint/AssignmentInCondition: @@ -47,12 +37,12 @@ Lint/AssignmentInCondition: - 'lib/osm.rb' - 'script/deliver-message' -# Offense count: 762 +# Offense count: 851 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes. Metrics/AbcSize: - Max: 189 + Max: 186 -# Offense count: 37 +# Offense count: 55 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns. # AllowedMethods: refine Metrics/BlockLength: @@ -63,58 +53,47 @@ Metrics/BlockLength: Metrics/BlockNesting: Max: 5 -# Offense count: 26 +# Offense count: 23 # Configuration parameters: CountComments, CountAsOne. Metrics/ClassLength: - Max: 350 + Max: 341 -# Offense count: 58 +# Offense count: 72 # Configuration parameters: AllowedMethods, AllowedPatterns. Metrics/CyclomaticComplexity: - Max: 25 + Max: 22 -# Offense count: 844 +# Offense count: 989 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns. Metrics/MethodLength: Max: 179 -# Offense count: 1 +# Offense count: 2 # Configuration parameters: CountKeywordArgs, MaxOptionalParameters. Metrics/ParameterLists: Max: 6 -# Offense count: 58 +# Offense count: 66 # Configuration parameters: AllowedMethods, AllowedPatterns. Metrics/PerceivedComplexity: Max: 26 -# Offense count: 2784 +# Offense count: 2711 # This cop supports safe autocorrection (--autocorrect). Minitest/EmptyLineBeforeAssertionMethods: Enabled: false -# Offense count: 695 +# Offense count: 890 Minitest/MultipleAssertions: - Max: 60 - -# Offense count: 2 -# Configuration parameters: Include. -# Include: app/models/**/*.rb -Rails/HasAndBelongsToMany: - Exclude: - - 'app/models/changeset.rb' - - 'app/models/user.rb' + Max: 55 # Offense count: 3 -# Configuration parameters: Include. -# Include: app/helpers/**/*.rb Rails/HelperInstanceVariable: Exclude: - 'app/helpers/title_helper.rb' -# Offense count: 17 -# Configuration parameters: IgnoreScopes, Include. -# Include: app/models/**/*.rb +# Offense count: 19 +# Configuration parameters: IgnoreScopes. Rails/InverseOf: Exclude: - 'app/models/changeset.rb' @@ -125,16 +104,13 @@ Rails/InverseOf: - 'app/models/user.rb' # Offense count: 1 -# Configuration parameters: Include. -# Include: app/controllers/**/*.rb, app/mailers/**/*.rb Rails/LexicallyScopedActionFilter: Exclude: - 'app/controllers/oauth2_applications_controller.rb' # Offense count: 5 -# Configuration parameters: Database, Include. +# Configuration parameters: Database. # SupportedDatabases: mysql -# Include: db/**/*.rb Rails/NotNullColumn: Exclude: - 'db/migrate/002_cleanup_osm_db.rb' @@ -143,7 +119,7 @@ Rails/NotNullColumn: - 'db/migrate/025_add_end_time_to_changesets.rb' - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb' -# Offense count: 7 +# Offense count: 9 Rails/OutputSafety: Exclude: - 'app/helpers/application_helper.rb' @@ -152,8 +128,6 @@ Rails/OutputSafety: - 'test/helpers/application_helper_test.rb' # Offense count: 16 -# Configuration parameters: Include. -# Include: db/**/*.rb Rails/ThreeStateBooleanColumn: Exclude: - 'db/migrate/001_create_osm_db.rb' @@ -162,7 +136,7 @@ Rails/ThreeStateBooleanColumn: - 'db/migrate/054_refactor_map_bug_tables.rb' - 'db/migrate/20140507110937_create_changeset_comments.rb' -# Offense count: 6 +# Offense count: 5 # This cop supports safe autocorrection (--autocorrect). Rake/Desc: Exclude: @@ -170,8 +144,21 @@ Rake/Desc: - 'lib/tasks/subscribe_diary_authors.rake' - 'lib/tasks/subscribe_old_changesets.rake' -# Offense count: 78 +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Style/IfUnlessModifier: + Exclude: + - 'app/controllers/api/notes_controller.rb' + +# Offense count: 101 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: Strict, AllowedNumbers, AllowedPatterns. Style/NumericLiterals: MinDigits: 15 + +# Offense count: 690 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AllowHeredoc, AllowURI, AllowQualifiedName, URISchemes, AllowRBSInlineAnnotation, AllowCopDirectives, AllowedPatterns, SplitStrings. +# URISchemes: http, https +Layout/LineLength: + Max: 261 -- 2.39.5