From bac37f29d249b94386bc93d2f933f9fef07b1d1c Mon Sep 17 00:00:00 2001 From: Tom Hughes Date: Tue, 7 Aug 2007 17:29:27 +0000 Subject: [PATCH 1/1] Cope with the OSM NameFinder returning a result with no nearby places. --- app/controllers/geocoder_controller.rb | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/app/controllers/geocoder_controller.rb b/app/controllers/geocoder_controller.rb index 9349eaca4..480dc5419 100644 --- a/app/controllers/geocoder_controller.rb +++ b/app/controllers/geocoder_controller.rb @@ -91,11 +91,16 @@ private place = named.elements["place/named"] || named.elements["nearestplaces/named"] type = named.attributes["info"].to_s.capitalize name = named.attributes["name"].to_s - distance = format_distance(place.attributes["approxdistance"].to_i) - direction = format_direction(place.attributes["direction"].to_i) - placename = place.attributes["name"].to_s - results.push({:lat => lat, :lon => lon, :zoom => zoom, - :description => "#{type} #{name}, #{distance} #{direction} of #{placename}"}) + if place + distance = format_distance(place.attributes["approxdistance"].to_i) + direction = format_direction(place.attributes["direction"].to_i) + placename = place.attributes["name"].to_s + results.push({:lat => lat, :lon => lon, :zoom => zoom, + :description => "#{type} #{name}, #{distance} #{direction} of #{placename}"}) + else + results.push({:lat => lat, :lon => lon, :zoom => zoom, + :description => "#{type} #{name}"}) + end end return { :source => "OpenStreetMap Namefinder", :url => "http://www.frankieandshadow.com/osm/", :results => results } -- 2.43.2