From bbde77e900f145be1cb4129cd8848846b1bc8cd1 Mon Sep 17 00:00:00 2001
From: Marwin Hochfelsner <50826859+hlfan@users.noreply.github.com>
Date: Sun, 22 Mar 2026 15:55:09 +0000
Subject: [PATCH] Use shared loader partial

---
 app/views/browse/_relation.html.erb        |  6 +-----
 app/views/changesets/history.html.erb      |  6 +-----
 app/views/changesets/index.html.erb        | 12 ++----------
 app/views/directions/show.html.erb         |  6 +-----
 app/views/feature_queries/show.html.erb    | 12 ++----------
 app/views/layouts/_header.html.erb         |  6 +-----
 app/views/layouts/map.html.erb             |  6 +-----
 app/views/searches/queries/create.html.erb |  6 +-----
 app/views/searches/show.html.erb           |  6 +-----
 app/views/shared/_loader.html.erb          |  5 +++++
 app/views/shared/_richtext_field.html.erb  |  6 +-----
 config/locales/en.yml                      |  1 -
 12 files changed, 17 insertions(+), 61 deletions(-)
 create mode 100644 app/views/shared/_loader.html.erb

diff --git a/app/views/browse/_relation.html.erb b/app/views/browse/_relation.html.erb
index 2df05f6cb..8d06b2150 100644
--- a/app/views/browse/_relation.html.erb
+++ b/app/views/browse/_relation.html.erb
@@ -34,11 +34,7 @@
             <% src_path = relation_members_path(relation) %>
           <% end %>
           <turbo-frame id="member_relation_<%= relation.id %>" src="<%= src_path %>">
-            <div class="text-center my-2">
-              <div class="spinner-border spinner-border-sm text-primary" role="status">
-                <span class="visually-hidden"><%= t("browse.start_rjs.loading") %></span>
-              </div>
-            </div>
+            <div class="text-center my-2"><%= render "shared/loader" %></div>
           </turbo-frame>
         <% else %>
           <ul class="list-unstyled browse-element-list">
diff --git a/app/views/changesets/history.html.erb b/app/views/changesets/history.html.erb
index 8c77c5b3c..b9245581d 100644
--- a/app/views/changesets/history.html.erb
+++ b/app/views/changesets/history.html.erb
@@ -14,9 +14,5 @@
                      end %>
 
 <div class="changesets mx-n3">
-  <div class="text-center loader">
-    <div class="spinner-border" role="status">
-      <span class="visually-hidden"><%= t("browse.start_rjs.loading") %></span>
-    </div>
-  </div>
+  <div class="text-center loader"><%= render "shared/loader" %></div>
 </div>
diff --git a/app/views/changesets/index.html.erb b/app/views/changesets/index.html.erb
index e265d661e..b3b7b3f95 100644
--- a/app/views/changesets/index.html.erb
+++ b/app/views/changesets/index.html.erb
@@ -1,10 +1,6 @@
 <% if @changesets.newer_items_cursor %>
   <div class="changeset_more my-3">
-    <div class="text-center position-absolute start-0 end-0" hidden>
-      <div class="spinner-border" role="status">
-        <span class="visually-hidden"><%= t("browse.start_rjs.loading") %></span>
-      </div>
-    </div>
+    <div class="text-center position-absolute start-0 end-0" hidden><%= render "shared/loader" %></div>
     <ul class="pagination justify-content-center">
       <li class="page-item">
         <%= link_to t(".newer_changesets"), url_for(:after => @changesets.newer_items_cursor), :class => "page-link" %>
@@ -25,11 +21,7 @@
 <% end %>
 <% if @changesets.older_items_cursor -%>
   <div class="changeset_more my-3">
-    <div class="text-center position-absolute start-0 end-0" hidden>
-      <div class="spinner-border" role="status">
-        <span class="visually-hidden"><%= t("browse.start_rjs.loading") %></span>
-      </div>
-    </div>
+    <div class="text-center position-absolute start-0 end-0" hidden><%= render "shared/loader" %></div>
     <ul class="pagination justify-content-center">
       <li class="page-item">
         <%= link_to t(".older_changesets"), url_for(:before => @changesets.older_items_cursor), :class => "page-link" %>
diff --git a/app/views/directions/show.html.erb b/app/views/directions/show.html.erb
index 2353a69fd..36eb0d919 100644
--- a/app/views/directions/show.html.erb
+++ b/app/views/directions/show.html.erb
@@ -16,11 +16,7 @@
 <%= render "sidebar_header", :title => t(".title") %>
 
 <div id="directions_loader" hidden>
-  <div class="text-center loader">
-    <div class="spinner-border" role="status">
-      <span class="visually-hidden"><%= t("browse.start_rjs.loading") %></span>
-    </div>
-  </div>
+  <div class="text-center loader"><%= render "shared/loader" %></div>
 </div>
 
 <div id="directions_error" hidden></div>
diff --git a/app/views/feature_queries/show.html.erb b/app/views/feature_queries/show.html.erb
index 25b0cac14..2b0225421 100644
--- a/app/views/feature_queries/show.html.erb
+++ b/app/views/feature_queries/show.html.erb
@@ -8,11 +8,7 @@
 
 <div id="query-nearby" class="query-results">
   <h3><%= t(".nearby") %></h3>
-  <div class="text-center loader">
-    <div class="spinner-border" role="status">
-      <span class="visually-hidden"><%= t("browse.start_rjs.loading") %></span>
-    </div>
-  </div>
+  <div class="text-center loader"><%= render "shared/loader" %></div>
   <div class="mx-n3">
     <ul class="query-results-list list-group list-group-flush"></ul>
   </div>
@@ -20,11 +16,7 @@
 
 <div id="query-isin" class="query-results">
   <h3><%= t(".enclosing") %></h3>
-  <div class="text-center loader">
-    <div class="spinner-border" role="status">
-      <span class="visually-hidden"><%= t("browse.start_rjs.loading") %></span>
-    </div>
-  </div>
+  <div class="text-center loader"><%= render "shared/loader" %></div>
   <div class="mx-n3">
     <ul class="query-results-list list-group list-group-flush"></ul>
   </div>
diff --git a/app/views/layouts/_header.html.erb b/app/views/layouts/_header.html.erb
index b5dc3448b..6eeb27fe5 100644
--- a/app/views/layouts/_header.html.erb
+++ b/app/views/layouts/_header.html.erb
@@ -92,11 +92,7 @@
       </div>
       <div class="modal-body px-1">
         <turbo-frame id="select_language_list" src="<%= languages_pane_path %>?source=<%= ERB::Util.url_encode(request.fullpath) %>" loading="lazy">
-          <div class="text-center py-3">
-            <div class="spinner-border text-secondary" role="status">
-              <span class="visually-hidden"><%= t ".loading" %></span>
-            </div>
-          </div>
+          <div class="text-center py-3"><%= render "shared/loader" %></div>
         </turbo-frame>
       </div>
     </div>
diff --git a/app/views/layouts/map.html.erb b/app/views/layouts/map.html.erb
index 9d6b9878b..2f47931bb 100644
--- a/app/views/layouts/map.html.erb
+++ b/app/views/layouts/map.html.erb
@@ -20,11 +20,7 @@
 
     <%= render :partial => "layouts/sidebar_close" %>
 
-    <div id="sidebar_loader" class="my-3 text-center loader" hidden>
-      <div class="spinner-border" role="status">
-        <span class="visually-hidden"><%= t("browse.start_rjs.loading") %></span>
-      </div>
-    </div>
+    <div id="sidebar_loader" class="my-3 text-center loader" hidden><%= render "shared/loader" %></div>
 
     <div id="sidebar_content" class="p-3 position-relative z-n1">
       <%= yield %>
diff --git a/app/views/searches/queries/create.html.erb b/app/views/searches/queries/create.html.erb
index 2fdc5899c..24d2678b5 100644
--- a/app/views/searches/queries/create.html.erb
+++ b/app/views/searches/queries/create.html.erb
@@ -13,11 +13,7 @@
   <% if @more_params %>
     <div class="search_more text-center my-3">
       <%= link_to t(".more_results"), url_for(@more_params), :class => "btn btn-primary" %>
-      <div class="text-center loader" hidden>
-        <div class="spinner-border" role="status">
-          <span class="visually-hidden"><%= t("browse.start_rjs.loading") %></span>
-        </div>
-      </div>
+      <div class="text-center loader" hidden><%= render "shared/loader" %></div>
     </div>
   <% end %>
 <% end %>
diff --git a/app/views/searches/show.html.erb b/app/views/searches/show.html.erb
index b734c07e1..513c49990 100644
--- a/app/views/searches/show.html.erb
+++ b/app/views/searches/show.html.erb
@@ -7,10 +7,6 @@
     <%= link_to t(".title.#{source[:name]}"), source[:url].to_s %>
   </h4>
   <div class="search_results_entry mx-n3" data-href="<%= source[:fetch_url] %>">
-    <div class="text-center loader">
-      <div class="spinner-border" role="status">
-        <span class="visually-hidden"><%= t("browse.start_rjs.loading") %></span>
-      </div>
-    </div>
+    <div class="text-center loader"><%= render "shared/loader" %></div>
   </div>
 <% end %>
diff --git a/app/views/shared/_loader.html.erb b/app/views/shared/_loader.html.erb
new file mode 100644
index 000000000..96376e29a
--- /dev/null
+++ b/app/views/shared/_loader.html.erb
@@ -0,0 +1,5 @@
+<%# locals: () %>
+
+<div class="spinner-border" role="status">
+  <span class="visually-hidden"><%= t("browse.start_rjs.loading") %></span>
+</div>
diff --git a/app/views/shared/_richtext_field.html.erb b/app/views/shared/_richtext_field.html.erb
index 9461f2d0b..7de81c844 100644
--- a/app/views/shared/_richtext_field.html.erb
+++ b/app/views/shared/_richtext_field.html.erb
@@ -18,11 +18,7 @@
         <%= builder.text_area(attribute, options.merge(:wrapper => false, "data-preview-url" => preview_url(:type => type))) %>
       </div>
       <div id="<%= id %>_preview" class="tab-pane">
-        <div class="richtext_placeholder text-center py-5" hidden>
-          <div class="spinner-border" role="status">
-            <span class="visually-hidden"><%= t("browse.start_rjs.loading") %></span>
-          </div>
-        </div>
+        <div class="richtext_placeholder text-center py-5" hidden><%= render "shared/loader" %></div>
         <div class="richtext text-break"></div>
       </div>
       <div id="<%= id %>_help" class="tab-pane">
diff --git a/config/locales/en.yml b/config/locales/en.yml
index 9c83338db..4985bb666 100644
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -1858,7 +1858,6 @@ en:
       history: History
       home: Go to Home Location
       issues: Issues
-      loading: Loading...
       log_out: Log Out
       log_in: Log In
       more: More
-- 
2.39.5