From bc31329da1c98f99d52a6f37ac8bb256012eb4f6 Mon Sep 17 00:00:00 2001
From: Tom Hughes <tom@compton.nu>
Date: Fri, 18 Jan 2013 00:37:44 +0000
Subject: [PATCH 1/1] Improve testing of the trace list view

---
 app/views/trace/list.html.erb            | 14 ++++--
 test/functional/trace_controller_test.rb | 60 +++++++++++++++++++++++-
 2 files changed, 68 insertions(+), 6 deletions(-)

diff --git a/app/views/trace/list.html.erb b/app/views/trace/list.html.erb
index c600df110..dae4c89f6 100644
--- a/app/views/trace/list.html.erb
+++ b/app/views/trace/list.html.erb
@@ -26,11 +26,15 @@
   <%= render :partial => 'trace_paging_nav' %>
 
   <table id="trace_list" cellpadding="3">
-    <tr>
-      <th></th>
-      <th></th>
-    </tr>
-    <%= render :partial => 'trace', :collection => @traces unless @traces.nil? %>
+    <thead>
+      <tr>
+        <th></th>
+        <th></th>
+      </tr>
+    </thead>
+    <tbody>
+      <%= render :partial => 'trace', :collection => @traces unless @traces.nil? %>
+    </tbody>
   </table>
 
   <%= render :partial => 'trace_paging_nav' %>
diff --git a/test/functional/trace_controller_test.rb b/test/functional/trace_controller_test.rb
index 8ff29c437..d0afcc587 100644
--- a/test/functional/trace_controller_test.rb
+++ b/test/functional/trace_controller_test.rb
@@ -154,7 +154,8 @@ class TraceControllerTest < ActionController::TestCase
   def test_list
     get :list
     assert_response :success
-    assert_template 'list'
+    assert_template "list"
+    check_trace_list Trace.public
   end
 
   # Check that I can get mine
@@ -168,6 +169,43 @@ class TraceControllerTest < ActionController::TestCase
     # Now try when logged in
     get :mine, {}, {:user => users(:public_user).id}
     assert_redirected_to :controller => 'trace', :action => 'list', :display_name => users(:public_user).display_name
+
+    # Fetch the actual list
+    get :list, {:display_name => users(:public_user).display_name}, {:user => users(:public_user).id}
+    assert_response :success
+    assert_template "list"
+    check_trace_list users(:public_user).traces
+  end
+
+  # Check the list of changesets for a specific user
+  def test_list_user
+    # Test a user with no traces
+    get :list, :display_name => users(:second_public_user).display_name
+    assert_response :success
+    assert_template "list"
+    check_trace_list users(:second_public_user).traces.public
+
+    # Test a user with some traces - should see only public ones
+    get :list, :display_name => users(:public_user).display_name
+    assert_response :success
+    assert_template "list"
+    check_trace_list users(:public_user).traces.public
+
+    @request.cookies["_osm_username"] = users(:normal_user).display_name
+
+    # Should still see only public ones when authenticated as another user
+    get :list, {:display_name => users(:public_user).display_name}, {:user => users(:normal_user).id}
+    assert_response :success
+    assert_template "list"
+    check_trace_list users(:public_user).traces.public
+
+    @request.cookies["_osm_username"] = users(:public_user).display_name
+
+    # Should see all traces when authenticated as the target user
+    get :list, {:display_name => users(:public_user).display_name}, {:user => users(:public_user).id}
+    assert_response :success
+    assert_template "list"
+    check_trace_list users(:public_user).traces
   end
 
   # Check that the rss loads
@@ -307,4 +345,24 @@ class TraceControllerTest < ActionController::TestCase
     delete :api_delete, :id => gpx_files(:public_trace_file).id
     assert_response :not_found
   end
+
+private
+
+  def check_trace_list(traces)
+    traces = traces.visible.order("timestamp DESC")
+    
+    if traces.count > 0
+      assert_select "table#trace_list tbody", :count => 1 do
+        assert_select "tr", :count => traces.count do |rows|
+          traces.zip(rows).each do |trace,row|
+            assert_select row, "span.trace_summary", Regexp.new(Regexp.escape("(#{trace.size} points)"))
+            assert_select row, "td", Regexp.new(Regexp.escape(trace.description))
+            assert_select row, "td", Regexp.new(Regexp.escape("by #{trace.user.display_name}"))
+          end
+        end
+      end
+    else
+      assert_select "h4", /Nothing here yet/
+    end
+  end
 end
-- 
2.43.2