From bf8ed3745036721d8ea2a3a0c56b42014340f410 Mon Sep 17 00:00:00 2001 From: Anton Khorev Date: Wed, 30 Apr 2025 03:05:26 +0300 Subject: [PATCH] Add outlines to in-viewport changeset bboxes --- .../index/history-changesets-layer.js | 18 ++++++++++++++++++ app/assets/stylesheets/common.scss | 1 + 2 files changed, 19 insertions(+) diff --git a/app/assets/javascripts/index/history-changesets-layer.js b/app/assets/javascripts/index/history-changesets-layer.js index ef051a001..1a53ab5f4 100644 --- a/app/assets/javascripts/index/history-changesets-layer.js +++ b/app/assets/javascripts/index/history-changesets-layer.js @@ -35,6 +35,17 @@ OSM.HistoryChangesetBboxAreaLayer = OSM.HistoryChangesetBboxLayer.extend({ } }); +OSM.HistoryChangesetBboxOutlineLayer = OSM.HistoryChangesetBboxLayer.extend({ + _getChangesetStyle: function (changeset) { + return { + weight: 4, + color: "var(--changeset-outline-color)", + fill: false, + className: this._getSidebarRelativeClassName(changeset) + }; + } +}); + OSM.HistoryChangesetBboxBorderLayer = OSM.HistoryChangesetBboxLayer.extend({ _getChangesetStyle: function (changeset) { return { @@ -138,6 +149,12 @@ OSM.HistoryChangesetsLayer = L.FeatureGroup.extend({ } } + for (const changeset of this._changesets.values()) { + if (changeset.sidebarRelativePosition === 0) { + this._outlineLayer.addChangesetLayer(changeset); + } + } + for (const changeset of this._changesets.values()) { if (changeset.sidebarRelativePosition === 0) { this._borderLayer.addChangesetLayer(changeset); @@ -168,6 +185,7 @@ OSM.HistoryChangesetsLayer.addInitHook(function () { this._bboxLayers = [ this._areaLayer = new OSM.HistoryChangesetBboxAreaLayer().addTo(this), + this._outlineLayer = new OSM.HistoryChangesetBboxOutlineLayer().addTo(this), this._borderLayer = new OSM.HistoryChangesetBboxBorderLayer().addTo(this), this._highlightLayer = new OSM.HistoryChangesetBboxHighlightLayer().addTo(this) ]; diff --git a/app/assets/stylesheets/common.scss b/app/assets/stylesheets/common.scss index ec5b22396..f07cef846 100644 --- a/app/assets/stylesheets/common.scss +++ b/app/assets/stylesheets/common.scss @@ -613,6 +613,7 @@ tr.turn { --changeset-border-color: #FF6600; } --changeset-fill-color: #FFFFAF; + --changeset-outline-color: #FFFFFF; } .changeset-below-sidebar-viewport { --changeset-border-color: #8888AA; -- 2.39.5