From d85fac567be1e2a64fe5737ce1673eca131680af Mon Sep 17 00:00:00 2001 From: Tom Hughes Date: Wed, 16 Oct 2013 00:46:20 +0100 Subject: [PATCH] Add tests for trace#data --- test/functional/trace_controller_test.rb | 86 +++++++++++++++++++++++ test/traces/1.gpx | 25 +++++++ test/traces/2.gpx | 24 +++++++ test/traces/4.gpx | Bin 0 -> 371 bytes 4 files changed, 135 insertions(+) create mode 100644 test/traces/1.gpx create mode 100644 test/traces/2.gpx create mode 100644 test/traces/4.gpx diff --git a/test/functional/trace_controller_test.rb b/test/functional/trace_controller_test.rb index a5f3c5a3d..57d6f4916 100644 --- a/test/functional/trace_controller_test.rb +++ b/test/functional/trace_controller_test.rb @@ -4,6 +4,16 @@ class TraceControllerTest < ActionController::TestCase fixtures :users, :gpx_files set_fixture_class :gpx_files => 'Trace' + def setup + @gpx_trace_dir = Object.send("remove_const", "GPX_TRACE_DIR") + Object.const_set("GPX_TRACE_DIR", File.dirname(__FILE__) + "/../traces") + end + + def teardown + Object.send("remove_const", "GPX_TRACE_DIR") + Object.const_set("GPX_TRACE_DIR", @gpx_trace_dir) + end + ## # test all routes which lead to this controller def test_routes @@ -278,6 +288,76 @@ class TraceControllerTest < ActionController::TestCase assert_redirected_to :action => :list end + # Test downloading a trace + def test_data + # First with no auth, which should work since the trace is public + get :data, {:display_name => users(:normal_user).display_name, :id => gpx_files(:public_trace_file).id} + check_trace_data gpx_files(:public_trace_file) + + @request.cookies["_osm_username"] = users(:public_user).display_name + + # Now with some other user, which should work since the trace is public + get :data, {:display_name => users(:normal_user).display_name, :id => gpx_files(:public_trace_file).id}, {:user => users(:public_user).id} + check_trace_data gpx_files(:public_trace_file) + + @request.cookies["_osm_username"] = users(:normal_user).display_name + + # And finally we should be able to do it with the owner of the trace + get :data, {:display_name => users(:normal_user).display_name, :id => gpx_files(:public_trace_file).id}, {:user => users(:normal_user).id} + check_trace_data gpx_files(:public_trace_file) + end + + # Test downloading a compressed trace + def test_data_compressed + # First get the data as is + get :data, {:display_name => users(:public_user).display_name, :id => gpx_files(:identifiable_trace_file).id} + check_trace_data gpx_files(:identifiable_trace_file), "application/x-gzip", "gpx.gz" + + # Now ask explicitly for XML format + get :data, {:display_name => users(:public_user).display_name, :id => gpx_files(:identifiable_trace_file).id, :format => "xml"} + check_trace_data gpx_files(:identifiable_trace_file), "application/xml", "xml" + + # Now ask explicitly for GPX format + get :data, {:display_name => users(:public_user).display_name, :id => gpx_files(:identifiable_trace_file).id, :format => "gpx"} + check_trace_data gpx_files(:identifiable_trace_file) + end + + # Check an anonymous trace can't be downloaded by another user + def test_data_anon + # First with no auth + get :data, {:display_name => users(:public_user).display_name, :id => gpx_files(:anon_trace_file).id} + assert_response :not_found + + @request.cookies["_osm_username"] = users(:normal_user).display_name + + # Now with some other user, which should work since the trace is anon + get :data, {:display_name => users(:public_user).display_name, :id => gpx_files(:anon_trace_file).id}, {:user => users(:normal_user).id} + assert_response :not_found + + @request.cookies["_osm_username"] = users(:public_user).display_name + + # And finally we should be able to do it with the owner of the trace + get :data, {:display_name => users(:public_user).display_name, :id => gpx_files(:anon_trace_file).id}, {:user => users(:public_user).id} + check_trace_data gpx_files(:anon_trace_file) + end + + # Test downloading a trace that doesn't exist + def test_data_not_found + # First with no auth, which should work since the trace is public + get :data, {:display_name => users(:public_user).display_name, :id => 0} + assert_response :not_found + + @request.cookies["_osm_username"] = users(:public_user).display_name + + # Now with some other user, which should work since the trace is public + get :data, {:display_name => users(:public_user).display_name, :id => 0}, {:user => users(:public_user).id} + assert_response :not_found + + # And finally we should be able to do it with the owner of the trace + get :data, {:display_name => users(:public_user).display_name, :id => 5}, {:user => users(:public_user).id} + assert_response :not_found + end + # Test fetching the edit page for a trace def test_edit_get # First with no auth @@ -549,4 +629,10 @@ private assert_select "td", trace.description end end + + def check_trace_data(trace, content_type = "application/gpx+xml", extension = "gpx") + assert_response :success + assert_equal content_type, @response.content_type + assert_equal "attachment; filename=\"#{trace.id}.#{extension}\"", @response.header["Content-Disposition"] + end end diff --git a/test/traces/1.gpx b/test/traces/1.gpx new file mode 100644 index 000000000..401d7a66d --- /dev/null +++ b/test/traces/1.gpx @@ -0,0 +1,25 @@ + + + + + + + + 134.0 + + 112.430000 + 0.072022 + 3d + 4 + 2.400000 + 2.600000 + 3.600000 + + + + diff --git a/test/traces/2.gpx b/test/traces/2.gpx new file mode 100644 index 000000000..44713988b --- /dev/null +++ b/test/traces/2.gpx @@ -0,0 +1,24 @@ + + + + + + + + + 112.430000 + 0.072022 + 3d + 4 + 2.400000 + 2.600000 + 3.600000 + + + + diff --git a/test/traces/4.gpx b/test/traces/4.gpx new file mode 100644 index 0000000000000000000000000000000000000000..8cafa32c62b46534147c7d4e0792cdfcc9b00b75 GIT binary patch literal 371 zcmV-(0gV11iwFp`&RtRf12isYaCiWXQO$3HFciP@S2VrT4?x`r)MSTwafyj8S$3&ez2GnS?_bgI<Br2*n?7 z>uq%q9gkaSESHtI=I%09Y1Q=ns~u6LI=tF^V2Z;?u6u4mi?yn_4bwghf`<<57Jx=m zL$?dtc7nNapJTF!Q?jFrJe%i)AVSDzfrA_sdv%hv0bMJP+?H@g(TpZAU_TQ