From dac517ebd3cbe0e72c1864ef64b0df2e368e3889 Mon Sep 17 00:00:00 2001
From: Marwin Hochfelsner <50826859+hlfan@users.noreply.github.com>
Date: Fri, 3 Apr 2026 12:40:38 +0200
Subject: [PATCH] Fix new Herb offenses

---
 .herb.yml                                    | 4 ----
 app/views/layers_panes/show.html.erb         | 4 ++--
 app/views/legend_panes/show.html.erb         | 9 ++++-----
 app/views/traces/feeds/_description.html.erb | 2 +-
 4 files changed, 7 insertions(+), 12 deletions(-)

diff --git a/.herb.yml b/.herb.yml
index a0f1f3125..04b786d64 100644
--- a/.herb.yml
+++ b/.herb.yml
@@ -4,14 +4,10 @@ linter:
   rules:
     erb-no-unused-expressions:
       enabled: false
-    erb-prefer-direct-output:
-      enabled: false
     erb-strict-locals-required:
       enabled: true
     html-anchor-require-href:
       enabled: false
-    html-img-require-alt:
-      enabled: false
     html-no-space-in-tag:
       enabled: true
     html-no-title-attribute:
diff --git a/app/views/layers_panes/show.html.erb b/app/views/layers_panes/show.html.erb
index 5c7c5c199..374fd4461 100644
--- a/app/views/layers_panes/show.html.erb
+++ b/app/views/layers_panes/show.html.erb
@@ -23,10 +23,10 @@
          options = { :data => layer, :class => "form-check" }
          options[:title] = t(".map_#{layer[:name]}_zoom_in_tooltip") if layer[:max_area] %>
       <%= tag.div(**options) do %>
-        <label id="<%= "label-layers-#{layer[:name]}" %>" class="form-check-label">
+        <%= tag.label :id => "label-layers-#{layer[:name]}", :class => "form-check-label" do %>
           <input type="checkbox" class="form-check-input">
           <%= t "javascripts.map.layers.#{layer[:name]}" %>
-        </label>
+        <% end %>
       <% end %>
     <% end %>
   </div>
diff --git a/app/views/legend_panes/show.html.erb b/app/views/legend_panes/show.html.erb
index 9c4315c9f..9551bb63e 100644
--- a/app/views/legend_panes/show.html.erb
+++ b/app/views/legend_panes/show.html.erb
@@ -3,16 +3,15 @@
     <% @legend.each do |layer_name, layer_data| %>
       <% layer_data["entries"].each do |entry| %>
         <%= tag.tr :data => { :layer => layer_name, :zoom_min => entry["min_zoom"], :zoom_max => entry["max_zoom"] } do %>
+          <% description = entry["name"].map { |feature_name| t ".entries.#{feature_name}" }.join(" · ") %>
           <td>
             <% if entry["image"] %>
-              <%= image_tag "legend/#{layer_name}/#{entry['image']}", :class => "filtered-image d-block mx-auto" %>
+              <%= image_tag "legend/#{layer_name}/#{entry['image']}", :class => "filtered-image d-block mx-auto", :alt => description %>
             <% else %>
-              <%= legend_svg_tag :class => "filtered-image d-block mx-auto", **entry %>
+              <%= legend_svg_tag :class => "filtered-image d-block mx-auto", **entry, :title => description %>
             <% end %>
           </td>
-          <td>
-            <%= entry["name"].map { |feature_name| t ".entries.#{feature_name}" }.join(" · ") %>
-          </td>
+          <td><%= description %></td>
         <% end %>
       <% end %>
     <% end %>
diff --git a/app/views/traces/feeds/_description.html.erb b/app/views/traces/feeds/_description.html.erb
index 29dacc688..20799c854 100644
--- a/app/views/traces/feeds/_description.html.erb
+++ b/app/views/traces/feeds/_description.html.erb
@@ -1,6 +1,6 @@
 <%# locals: (trace:) %>
 
-<%= image_tag trace_icon_url(trace.user, trace) %>
+<%= image_tag trace_icon_url(trace.user, trace), :alt => "" %>
 <% if trace.size -%>
 <%= t ".description_with_count", :count => trace.size, :user => trace.user.display_name %>
 <% else -%>
-- 
2.39.5