From e6a1003509f3bdcfbc2af2b21ed80ff5febb2e3e Mon Sep 17 00:00:00 2001 From: Tom Hughes Date: Sat, 23 Mar 2013 18:38:49 +0000 Subject: [PATCH] Avoid reading nodes twice in WayController#full --- app/controllers/way_controller.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/controllers/way_controller.rb b/app/controllers/way_controller.rb index c3ffe3c0f..9f797d1d8 100644 --- a/app/controllers/way_controller.rb +++ b/app/controllers/way_controller.rb @@ -64,6 +64,7 @@ class WayController < ApplicationController way = Way.includes(:nodes => :node_tags).find(params[:id]) if way.visible + visible_nodes = {} changeset_cache = {} user_display_name_cache = {} @@ -71,9 +72,10 @@ class WayController < ApplicationController way.nodes.uniq.each do |node| if node.visible doc.root << node.to_xml_node(changeset_cache, user_display_name_cache) + visible_nodes[node.id] = node end end - doc.root << way.to_xml_node(nil, changeset_cache, user_display_name_cache) + doc.root << way.to_xml_node(visible_nodes, changeset_cache, user_display_name_cache) render :text => doc.to_s, :content_type => "text/xml" else -- 2.43.2