From e9086622f99d4aa9e671273552b14c10f21d7e95 Mon Sep 17 00:00:00 2001 From: Anton Khorev Date: Fri, 30 May 2025 19:18:21 +0300 Subject: [PATCH] Make sure that all map control buttons have labels --- app/assets/javascripts/leaflet.key.js | 2 +- app/assets/javascripts/leaflet.note.js | 1 + app/assets/javascripts/leaflet.query.js | 1 + app/assets/javascripts/leaflet.sidebar-pane.js | 5 +---- 4 files changed, 4 insertions(+), 5 deletions(-) diff --git a/app/assets/javascripts/leaflet.key.js b/app/assets/javascripts/leaflet.key.js index 3e5f7f325..1b623371a 100644 --- a/app/assets/javascripts/leaflet.key.js +++ b/app/assets/javascripts/leaflet.key.js @@ -1,5 +1,5 @@ L.OSM.key = function (options) { - const control = L.OSM.sidebarPane(options, "key", null, "javascripts.key.title"); + const control = L.OSM.sidebarPane(options, "key", "javascripts.key.title", "javascripts.key.title"); control.onAddPane = function (map, button, $ui) { const $section = $("
") diff --git a/app/assets/javascripts/leaflet.note.js b/app/assets/javascripts/leaflet.note.js index 38048abab..841e2a03e 100644 --- a/app/assets/javascripts/leaflet.note.js +++ b/app/assets/javascripts/leaflet.note.js @@ -8,6 +8,7 @@ L.OSM.note = function (options) { const link = $("") .attr("class", "control-button") .attr("href", "#") + .attr("title", OSM.i18n.t("javascripts.site.createnote_tooltip")) .appendTo($container); $(L.SVG.create("svg")) diff --git a/app/assets/javascripts/leaflet.query.js b/app/assets/javascripts/leaflet.query.js index e882854c8..5611b2d18 100644 --- a/app/assets/javascripts/leaflet.query.js +++ b/app/assets/javascripts/leaflet.query.js @@ -8,6 +8,7 @@ L.OSM.query = function (options) { const link = $("") .attr("class", "control-button") .attr("href", "#") + .attr("title", OSM.i18n.t("javascripts.site.queryfeature_tooltip")) .appendTo($container); $(L.SVG.create("svg")) diff --git a/app/assets/javascripts/leaflet.sidebar-pane.js b/app/assets/javascripts/leaflet.sidebar-pane.js index 21a61d3a5..9d2af2a25 100644 --- a/app/assets/javascripts/leaflet.sidebar-pane.js +++ b/app/assets/javascripts/leaflet.sidebar-pane.js @@ -8,6 +8,7 @@ L.OSM.sidebarPane = function (options, uiClass, buttonTitle, paneTitle) { const button = $("") .attr("class", "control-button") .attr("href", "#") + .attr("title", OSM.i18n.t(buttonTitle)) .on("click", toggle); $(L.SVG.create("svg")) @@ -15,10 +16,6 @@ L.OSM.sidebarPane = function (options, uiClass, buttonTitle, paneTitle) { .attr("class", "h-100 w-100") .appendTo(button); - if (buttonTitle) { - button.attr("title", OSM.i18n.t(buttonTitle)); - } - button.appendTo($container); const $ui = $("
") -- 2.39.5