From e9c6e57bcccc2a47bde53670d4effa4a5827a295 Mon Sep 17 00:00:00 2001
From: John Firebaugh <john.firebaugh@gmail.com>
Date: Thu, 14 Nov 2013 15:38:28 -0800
Subject: [PATCH] Eliminate HTML5 elements

IE8, *sigh*
---
 app/assets/javascripts/application.js  |  6 ++--
 app/assets/javascripts/index.js        |  2 +-
 app/assets/stylesheets/common.css.scss | 17 +++++------
 app/assets/stylesheets/print.css       |  2 +-
 app/assets/stylesheets/small.css.scss  | 11 ++++---
 app/views/layouts/_header.html.erb     | 40 +++++++++++++-------------
 6 files changed, 39 insertions(+), 39 deletions(-)

diff --git a/app/assets/javascripts/application.js b/app/assets/javascripts/application.js
index 2c186c909..c1f6af004 100644
--- a/app/assets/javascripts/application.js
+++ b/app/assets/javascripts/application.js
@@ -132,10 +132,10 @@ $(document).ready(function () {
 
   $("#menu-icon").on("click", function(e) {
     e.preventDefault();
-    $("header").toggleClass("closed");
+    $("#header").toggleClass("closed");
   });
 
-  $("nav.primary li a").on("click", function() {
-    $("header").toggleClass("closed");
+  $(".nav.primary li a").on("click", function() {
+    $("#header").toggleClass("closed");
   });
 });
diff --git a/app/assets/javascripts/index.js b/app/assets/javascripts/index.js
index 6fc870a4c..9514fd5f0 100644
--- a/app/assets/javascripts/index.js
+++ b/app/assets/javascripts/index.js
@@ -263,7 +263,7 @@ $(document).ready(function () {
 
   $(".search_form").on("submit", function(e) {
     e.preventDefault();
-    $("header").addClass("closed");
+    $("#header").addClass("closed");
     var query = $(this).find("input[name=query]").val();
     if (query) {
       OSM.route("/search?query=" + encodeURIComponent(query) + OSM.formatHash(map));
diff --git a/app/assets/stylesheets/common.css.scss b/app/assets/stylesheets/common.css.scss
index f88e0d1d2..d456e0685 100644
--- a/app/assets/stylesheets/common.css.scss
+++ b/app/assets/stylesheets/common.css.scss
@@ -244,13 +244,13 @@ table {
   opacity: 0.6;
 }
 
-header {
+#header {
   height: $headerHeight;
   position: relative;
   z-index: 1001;
   font-size: 13px;
 
-  h1, nav, nav > ul, nav > ul > li, .dropdown {
+  h1, .nav, .nav > ul, .nav > ul > li, .user-menu {
     display: inline-block;
   }
 
@@ -259,7 +259,7 @@ header {
     padding: $lineheight/2;
   }
 
-  h1, nav.primary {
+  h1, .nav.primary {
     float: left;
   }
 
@@ -284,7 +284,7 @@ header {
   }
 }
 
-nav.primary {
+.nav.primary {
   > ul {
     $border: 1px solid $green;
 
@@ -347,11 +347,12 @@ nav.primary {
   }
 }
 
-nav.secondary {
+.nav.secondary {
   position: absolute;
   right: 0;
 
-  > ul {
+  > ul,
+  > #compact-secondary-nav {
     vertical-align: middle;
     a, .dropdown-toggle {
       display: inline-block;
@@ -455,7 +456,7 @@ nav.secondary {
     display: inline-block;
   }
   .compact-hide {
-    display: none;
+    display: none !important;
   }
 }
 
@@ -900,7 +901,7 @@ nav.secondary {
 
 /* Rules for the search box */
 
-header .search_form {
+#header .search_form {
   display: none;
 }
 
diff --git a/app/assets/stylesheets/print.css b/app/assets/stylesheets/print.css
index fa04314b1..5186f8c58 100644
--- a/app/assets/stylesheets/print.css
+++ b/app/assets/stylesheets/print.css
@@ -1,4 +1,4 @@
-header,
+#header,
 #sidebar,
 #permalink,
 .leaflet-control {
diff --git a/app/assets/stylesheets/small.css.scss b/app/assets/stylesheets/small.css.scss
index 39b946af0..06acc4da7 100644
--- a/app/assets/stylesheets/small.css.scss
+++ b/app/assets/stylesheets/small.css.scss
@@ -15,15 +15,14 @@ input[type="text"] {
   display: inline-block !important;
 }
 
-nav.primary,
-nav.secondary {
+.nav {
   float: none !important;
   position: relative;
   display: block;
   clear: both;
 }
 
-header {
+#header {
   height: auto;
   min-height: $headerHeight;
   background: #fff;
@@ -32,7 +31,7 @@ header {
     padding-bottom: 15px;
   }
 
-  &.closed nav {
+  &.closed .nav {
     display: none;
   }
 
@@ -47,7 +46,7 @@ header {
   display: none;
 }
 
-nav.primary {
+.nav.primary {
   padding: 0;
 
   ul, li {
@@ -71,7 +70,7 @@ nav.primary {
   }
 }
 
-nav.secondary {
+.nav.secondary {
   border-bottom: 1px solid #eee;
 
   .user-menu {
diff --git a/app/views/layouts/_header.html.erb b/app/views/layouts/_header.html.erb
index dbb9966b6..35cc0578c 100644
--- a/app/views/layouts/_header.html.erb
+++ b/app/views/layouts/_header.html.erb
@@ -1,4 +1,4 @@
-<header class="closed">
+<div id="header" class="closed">
   <h1>
     <a href="<%= root_path %>" class="geolink">
       <%= image_tag "osm_logo.png", :alt => t('layouts.logo.alt_text'), :class => 'logo' %>
@@ -6,7 +6,7 @@
     </a>
   </h1>
   <a href="#" id="menu-icon"></a>
-  <nav class='primary'>
+  <div class='nav primary'>
     <%= content_for :header %>
     <ul>
       <li id="edit_tab" class="dropdown <%= current_page_class(edit_path) %>">
@@ -32,23 +32,23 @@
         <%= link_to t('layouts.export'), export_path, :class => 'tab geolink' %>
       </li>
     </ul>
-  </nav>
-  <nav class='secondary'>
-    <ul>
-      <li class="compact-hide <%= current_page_class(traces_path) %>"><%= link_to t('layouts.gps_traces'), traces_path %></li>
-      <li class="compact-hide <%= current_page_class(diary_path) %>"><%= link_to t('layouts.user_diaries'), diary_path %></li>
-      <li class="compact-hide <%= current_page_class(help_path) %>"><%= link_to t('layouts.help'), help_path %></li>
-      <li class="compact-hide <%= current_page_class(about_path) %>"><%= link_to t('layouts.about'), about_path %></li>
-      <li id="compact-secondary-nav" class="dropdown">
-        <a class="dropdown-toggle" data-toggle="dropdown" href="#">More <b class="caret"></b></a>
-        <ul class="dropdown-menu">
-          <li class="<%= current_page_class(traces_path) %>"><%= link_to t('layouts.gps_traces'), traces_path %></li>
-          <li class="<%= current_page_class(diary_path) %>"><%= link_to t('layouts.user_diaries'), diary_path %></li>
-          <li class="<%= current_page_class(help_path) %>"><%= link_to t('layouts.help'), help_path %></li>
-          <li class="<%= current_page_class(about_path) %>"><%= link_to t('layouts.about'), about_path %></li>
-        </ul>
-      </li>
+  </div>
+  <div class='nav secondary'>
+    <ul class="compact-hide">
+      <li class="<%= current_page_class(traces_path) %>"><%= link_to t('layouts.gps_traces'), traces_path %></li>
+      <li class="<%= current_page_class(diary_path) %>"><%= link_to t('layouts.user_diaries'), diary_path %></li>
+      <li class="<%= current_page_class(help_path) %>"><%= link_to t('layouts.help'), help_path %></li>
+      <li class="<%= current_page_class(about_path) %>"><%= link_to t('layouts.about'), about_path %></li>
     </ul>
+    <div id="compact-secondary-nav" class="dropdown">
+      <a class="dropdown-toggle" data-toggle="dropdown" href="#">More <b class="caret"></b></a>
+      <ul class="dropdown-menu">
+        <li class="<%= current_page_class(traces_path) %>"><%= link_to t('layouts.gps_traces'), traces_path %></li>
+        <li class="<%= current_page_class(diary_path) %>"><%= link_to t('layouts.user_diaries'), diary_path %></li>
+        <li class="<%= current_page_class(help_path) %>"><%= link_to t('layouts.help'), help_path %></li>
+        <li class="<%= current_page_class(about_path) %>"><%= link_to t('layouts.about'), about_path %></li>
+      </ul>
+    </div>
     <% if @user %>
       <div class='dropdown user-menu logged-in'>
         <a class='dropdown-toggle' data-toggle='dropdown' href="#">
@@ -85,5 +85,5 @@
         <li><%= link_to t('layouts.sign_up'), user_new_path %></li>
       </ul>
     <% end %>
-  </nav>
-</header>
+  </div>
+</div>
-- 
2.43.2