From ee6e0d5c0baf90c1464b8f0301cfbafed6685f98 Mon Sep 17 00:00:00 2001
From: John Firebaugh <john.firebaugh@gmail.com>
Date: Sun, 25 Nov 2012 15:14:47 -0400
Subject: [PATCH] Remove unused parameter

---
 app/controllers/api_controller.rb      | 2 +-
 app/controllers/relation_controller.rb | 8 ++------
 app/controllers/search_controller.rb   | 2 +-
 app/models/relation.rb                 | 2 +-
 4 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/app/controllers/api_controller.rb b/app/controllers/api_controller.rb
index 602b79d69..455c05491 100644
--- a/app/controllers/api_controller.rb
+++ b/app/controllers/api_controller.rb
@@ -203,7 +203,7 @@ class ApiController < ApplicationController
     # this "uniq" may be slightly inefficient; it may be better to first collect and output
     # all node-related relations, then find the *not yet covered* way-related ones etc.
     relations.uniq.each do |relation|
-      doc.root << relation.to_xml_node(nil, changeset_cache, user_display_name_cache)
+      doc.root << relation.to_xml_node(changeset_cache, user_display_name_cache)
     end
 
     response.headers["Content-Disposition"] = "attachment; filename=\"map.osm\""
diff --git a/app/controllers/relation_controller.rb b/app/controllers/relation_controller.rb
index 0b989d11e..af3c0753e 100644
--- a/app/controllers/relation_controller.rb
+++ b/app/controllers/relation_controller.rb
@@ -97,7 +97,6 @@ class RelationController < ApplicationController
       # create XML.
       doc = OSM::API.new.get_xml_doc
       visible_nodes = {}
-      visible_members = { "Node" => {}, "Way" => {}, "Relation" => {} }
       changeset_cache = {}
       user_display_name_cache = {}
       
@@ -105,23 +104,20 @@ class RelationController < ApplicationController
         if node.visible? # should be unnecessary if data is consistent.
           doc.root << node.to_xml_node(changeset_cache, user_display_name_cache)
           visible_nodes[node.id] = node
-          visible_members["Node"][node.id] = true
         end
       end
       ways.each do |way|
         if way.visible? # should be unnecessary if data is consistent.
           doc.root << way.to_xml_node(visible_nodes, changeset_cache, user_display_name_cache)
-          visible_members["Way"][way.id] = true
         end
       end
       relations.each do |rel|
         if rel.visible? # should be unnecessary if data is consistent.
-          doc.root << rel.to_xml_node(nil, changeset_cache, user_display_name_cache)
-          visible_members["Relation"][rel.id] = true
+          doc.root << rel.to_xml_node(changeset_cache, user_display_name_cache)
         end
       end
       # finally add self and output
-      doc.root << relation.to_xml_node(visible_members, changeset_cache, user_display_name_cache)
+      doc.root << relation.to_xml_node(changeset_cache, user_display_name_cache)
       render :text => doc.to_s, :content_type => "text/xml"
       
     else
diff --git a/app/controllers/search_controller.rb b/app/controllers/search_controller.rb
index 622ebb1ce..78becc24b 100644
--- a/app/controllers/search_controller.rb
+++ b/app/controllers/search_controller.rb
@@ -90,7 +90,7 @@ class SearchController < ApplicationController
     end
 
     relations.each do |rel|
-      doc.root << rel.to_xml_node(nil, changeset_cache, user_display_name_cache)
+      doc.root << rel.to_xml_node(changeset_cache, user_display_name_cache)
     end
 
     render :text => doc.to_s, :content_type => "text/xml"
diff --git a/app/models/relation.rb b/app/models/relation.rb
index 028d6024c..abe014311 100644
--- a/app/models/relation.rb
+++ b/app/models/relation.rb
@@ -105,7 +105,7 @@ class Relation < ActiveRecord::Base
     return doc
   end
 
-  def to_xml_node(visible_members = nil, changeset_cache = {}, user_display_name_cache = {})
+  def to_xml_node(changeset_cache = {}, user_display_name_cache = {})
     el1 = XML::Node.new 'relation'
     el1['id'] = self.id.to_s
     el1['visible'] = self.visible.to_s
-- 
2.43.2