From f64baf3db520e11c98d783fdae38c1cecc390216 Mon Sep 17 00:00:00 2001
From: Anton Khorev <tony29@yandex.ru>
Date: Mon, 7 Jul 2025 21:33:08 +0300
Subject: [PATCH] Make invalid type member test similar to create relation
 tests

---
 .../api/relations_controller_test.rb          | 45 +++++++++----------
 1 file changed, 20 insertions(+), 25 deletions(-)

diff --git a/test/controllers/api/relations_controller_test.rb b/test/controllers/api/relations_controller_test.rb
index 098e0a4bd..922e5d756 100644
--- a/test/controllers/api/relations_controller_test.rb
+++ b/test/controllers/api/relations_controller_test.rb
@@ -418,6 +418,26 @@ module Api
       end
     end
 
+    def test_create_with_invalid_member_type
+      node = create(:node)
+
+      with_unchanging_request do |headers, changeset|
+        osm = <<~OSM
+          <osm>
+            <relation changeset='#{changeset.id}'>
+              <member type='type' ref='#{node.id}' role=''/>
+            </relation>
+          </osm>
+        OSM
+
+        post api_relations_path, :params => osm, :headers => headers
+
+        assert_response :bad_request
+        assert_match(/Cannot parse valid relation from xml string/, @response.body)
+        assert_match(/The type is not allowed only, /, @response.body)
+      end
+    end
+
     def test_create_and_show
       user = create(:user)
       changeset = create(:changeset, :user => user)
@@ -459,31 +479,6 @@ module Api
       assert_response :bad_request
     end
 
-    # -------------------------------------
-    # Test creating a relation, with some invalid XML
-    # -------------------------------------
-    def test_create_invalid_xml
-      user = create(:user)
-      changeset = create(:changeset, :user => user)
-      node = create(:node)
-
-      auth_header = bearer_authorization_header user
-
-      # create some xml that should return an error
-      xml = <<~OSM
-        <osm>
-          <relation changeset='#{changeset.id}'>
-            <member type='type' ref='#{node.id}' role=''/>
-          </relation>
-        </osm>
-      OSM
-      post api_relations_path, :params => xml, :headers => auth_header
-      # expect failure
-      assert_response :bad_request
-      assert_match(/Cannot parse valid relation from xml string/, @response.body)
-      assert_match(/The type is not allowed only, /, @response.body)
-    end
-
     # -------------------------------------
     # Test deleting relations.
     # -------------------------------------
-- 
2.39.5