From f9b0490afcf5cbcb279b6ba504995214a86619c6 Mon Sep 17 00:00:00 2001
From: Andy Allan <git@gravitystorm.co.uk>
Date: Wed, 10 Feb 2021 15:09:29 +0000
Subject: [PATCH] Update terms form to use bootstrap

---
 app/assets/stylesheets/common.scss |  9 -----
 app/views/users/terms.html.erb     | 62 ++++++++++++++++--------------
 2 files changed, 34 insertions(+), 37 deletions(-)

diff --git a/app/assets/stylesheets/common.scss b/app/assets/stylesheets/common.scss
index c010691c6..481025d81 100644
--- a/app/assets/stylesheets/common.scss
+++ b/app/assets/stylesheets/common.scss
@@ -4,8 +4,6 @@
 
 /* Styles common to large and small screens */
 
-.fillL { background-color: white; }
-
 /* Default rules for the body of every page */
 
 body {
@@ -1319,13 +1317,6 @@ tr.turn:hover {
       list-style-type: lower-alpha;
     }
   }
-
-  #decline {
-    background: $lightblue;
-    &:hover {
-      background: darken($lightblue, $hovercolor);
-    }
-  }
 }
 
 /* Rules for the account settings page */
diff --git a/app/views/users/terms.html.erb b/app/views/users/terms.html.erb
index b3e42189b..99af8b841 100644
--- a/app/views/users/terms.html.erb
+++ b/app/views/users/terms.html.erb
@@ -7,22 +7,21 @@
   <div class='header-illustration new-user-terms'></div>
 <% end %>
 
-<%= form_tag({ :action => "save" }, { :class => "standard-form fillL" }) do %>
+<%= form_tag({ :action => "save" }) do %>
   <!-- legale is <%= @legale %> -->
   <p class="text-muted"><%= t ".read and accept with tou" %></p>
   <h4>
     <%= t ".heading_ct" %>
   </h4>
-  <div class='standard-form-row horizontal-list clearfix'>
-    <p class="text-muted"><%= t ".contributor_terms_explain" %></p>
-    <label class="standard-label">
-      <%= t ".legale_select" %>
-    </label>
-
+  <p class="text-muted"><%= t ".contributor_terms_explain" %></p>
+  <label>
+    <%= t ".legale_select" %>
+  </label>
+  <div class="form-group">
     <% [%w[france FR], %w[italy IT], %w[rest_of_world GB]].each do |name, legale| %>
-      <div class="standard-form-row">
-        <label for="legale_<%= legale %>">
-          <%= radio_button_tag "legale", legale, @legale == legale, :data => { :url => url_for(:legale => legale) } %>
+      <div class="form-check form-check-inline">
+        <%= radio_button_tag "legale", legale, @legale == legale, :data => { :url => url_for(:legale => legale) }, :class => "form-check-input" %>
+        <label for="legale_<%= legale %>" class="form-check-label">
           <%= t(".legale_names.#{name}") %>
         </label>
       </div>
@@ -40,35 +39,42 @@
             :translations => "https://www.osmfoundation.org/wiki/License/Contributor_Terms/Informal_Translations" %>
     </p>
   </div>
-  <div class="standard-form-row">
-    <label for="read_ct">
-      <%= check_box_tag "read_ct" %>
-      <%= t ".read_ct" %>
-    </label>
+  <div class="form-group">
+    <div class="form-check">
+      <%= check_box_tag "read_ct", "1", false, :class => "form-check-input" %>
+      <label for="read_ct" class="form-check-label">
+        <%= t ".read_ct" %>
+      </label>
+    </div>
   </div>
 
   <h4>
     <%= t "layouts.tou" %>
   </h4>
   <p class="text-muted"><%= t ".tou_explain_html", :tou_link => link_to(t("layouts.tou"), "https://wiki.osmfoundation.org/wiki/Terms_of_Use", :target => :new) %></p>
-  <div class="standard-form-row">
-    <label for="read_tou">
-      <%= check_box_tag "read_tou" %>
-      <%= t ".read_tou" %>
-    </label>
-
-    <%= hidden_field_tag("referer", h(params[:referer])) unless params[:referer].nil? %>
 
-    <div class="buttons standard-form-row py-3 clearfix">
-      <%= submit_tag("Continue", :name => "continue", :id => "continue", :disabled => true) %>
-      <%= submit_tag("Cancel", :name => "decline", :id => "decline") %>
+  <div class="form-group">
+    <div class="form-check">
+      <%= check_box_tag "read_tou", "1", false, :class => "form-check-input" %>
+      <label for="read_tou" class="form-check-label">
+        <%= t ".read_tou" %>
+      </label>
     </div>
+  </div>
+
+  <%= hidden_field_tag("referer", h(params[:referer])) unless params[:referer].nil? %>
 
-    <label for="user_consider_pd">
-      <%= check_box("user", "consider_pd") %>
+  <div class="form-group">
+    <%= submit_tag("Continue", :name => "continue", :id => "continue", :disabled => true, :class => "btn btn-primary") %>
+    <%= submit_tag("Cancel", :name => "decline", :id => "decline", :class => "btn btn-outline-secondary") %>
+  </div>
+
+  <div class="form-group">
+    <div class="form-check">
+      <%= check_box("user", "consider_pd", :class => "form-check-input") %>
+    <label for="user_consider_pd" class="form-check-label">
       <%= t ".consider_pd" %>
     </label>
     <span class="minorNote">(<%= link_to(t(".consider_pd_why"), t(".consider_pd_why_url"), :target => :new) %>)</span>
-
   </div>
 <% end %>
-- 
2.45.1