From fd61706e4cc2d6909d424a1d0b147fc688ebd005 Mon Sep 17 00:00:00 2001 From: Andy Allan Date: Wed, 26 Jun 2019 18:24:57 +0200 Subject: [PATCH] Split some extremely long strings over multiple lines using squiggly heredocs I'm not entirely convinced that testing walls of text like this is useful anyway, but at least this approach makes the lines significantly less long. --- .rubocop_todo.yml | 2 +- test/helpers/user_roles_helper_test.rb | 96 +++++++++++++++++++++++--- 2 files changed, 89 insertions(+), 9 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 26b5aa64b..4d772ed6e 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -193,4 +193,4 @@ Style/NumericLiterals: # Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. # URISchemes: http, https Metrics/LineLength: - Max: 1073 + Max: 307 diff --git a/test/helpers/user_roles_helper_test.rb b/test/helpers/user_roles_helper_test.rb index 058d6abd4..26c303cfa 100644 --- a/test/helpers/user_roles_helper_test.rb +++ b/test/helpers/user_roles_helper_test.rb @@ -10,7 +10,13 @@ class UserRolesHelperTest < ActionView::TestCase assert_dom_equal "", icon icon = role_icon(create(:moderator_user), "moderator") - assert_dom_equal 'This user is a moderator', icon + expected = <<~HTML.delete("\n") + + + This user is a moderator + + HTML + assert_dom_equal expected, icon end def test_role_icon_administrator @@ -18,11 +24,27 @@ class UserRolesHelperTest < ActionView::TestCase user = create(:user) icon = role_icon(user, "moderator") - assert_dom_equal %(Grant moderator access), icon + expected = <<~HTML.delete("\n") + + + + Grant moderator access + + + HTML + assert_dom_equal expected, icon moderator_user = create(:moderator_user) icon = role_icon(moderator_user, "moderator") - assert_dom_equal %(Revoke moderator access), icon + expected = <<~HTML.delete("\n") + + + + Revoke moderator access + + + HTML + assert_dom_equal expected, icon end def test_role_icons_normal @@ -32,10 +54,26 @@ class UserRolesHelperTest < ActionView::TestCase assert_dom_equal " ", icons icons = role_icons(create(:moderator_user)) - assert_dom_equal ' This user is a moderator', icons + expected = " " + <<~HTML.delete("\n") + + + This user is a moderator + + HTML + assert_dom_equal expected, icons icons = role_icons(create(:super_user)) - assert_dom_equal ' This user is an administrator This user is a moderator', icons + expected = " " + <<~HTML.delete("\n") + + + This user is an administrator + + + + This user is a moderator + + HTML + assert_dom_equal expected, icons end def test_role_icons_administrator @@ -43,14 +81,56 @@ class UserRolesHelperTest < ActionView::TestCase user = create(:user) icons = role_icons(user) - assert_dom_equal %( Grant administrator access Grant moderator access), icons + expected = " " + <<~HTML.delete("\n") + + + + Grant administrator access + + + + + + Grant moderator access + + + HTML + assert_dom_equal expected, icons moderator_user = create(:moderator_user) icons = role_icons(moderator_user) - assert_dom_equal %( Grant administrator access Revoke moderator access), icons + expected = " " + <<~HTML.delete("\n") + + + + Grant administrator access + + + + + + Revoke moderator access + + + HTML + assert_dom_equal expected, icons super_user = create(:super_user) icons = role_icons(super_user) - assert_dom_equal %( Revoke administrator access Revoke moderator access), icons + expected = " " + <<~HTML.delete("\n") + + + + Revoke administrator access + + + + + + Revoke moderator access + + + HTML + assert_dom_equal expected, icons end end -- 2.43.2