Remove hidden comments test from controller tests

diff --git a/app/views/browse/changeset.html.erb b/app/views/browse/changeset.html.erb
index 1190423f680e35f0e64c7f507e5a5be3fa9c857a..ef30f8214f9e39bd1c55b5f4ea1092c852bbbda6 100644 (file)
--- a/app/views/browse/changeset.html.erb
+++ b/app/views/browse/changeset.html.erb
@@ -27,41 +27,39 @@
   </div>
 
   <% if @comments.length > 0 %>
-    <div class='changeset-comments'>
-      <form action="#">
-        <ul class="list-unstyled">
-          <% @comments.each do |comment| %>
-            <% if comment.visible %>
-              <li id="c<%= comment.id %>">
-                <small class='text-muted'>
-                  <%= t(".comment_by_html",
-                        :time_ago => friendly_date_ago(comment.created_at),
-                        :user => link_to(comment.author.display_name, user_path(comment.author))) %>
-                  <% if current_user and current_user.moderator? %>
-                    — <button class="btn btn-sm small btn-link link-secondary p-0 align-baseline" data-method="POST" data-url="<%= changeset_comment_hide_url(comment.id) %>"><%= t("javascripts.changesets.show.hide_comment") %></button>
-                  <% end %>
+    <form action="#">
+      <ul class="list-unstyled">
+        <% @comments.each do |comment| %>
+          <% if comment.visible %>
+            <li id="c<%= comment.id %>">
+              <small class='text-muted'>
+                <%= t(".comment_by_html",
+                      :time_ago => friendly_date_ago(comment.created_at),
+                      :user => link_to(comment.author.display_name, user_path(comment.author))) %>
+                <% if current_user and current_user.moderator? %>
+                  — <button class="btn btn-sm small btn-link link-secondary p-0 align-baseline" data-method="POST" data-url="<%= changeset_comment_hide_url(comment.id) %>"><%= t("javascripts.changesets.show.hide_comment") %></button>
+                <% end %>
+              </small>
+              <div class="mx-2">
+                <%= comment.body.to_html %>
+              </div>
+            </li>
+          <% elsif current_user and current_user.moderator? %>
+            <li id="c<%= comment.id %>">
+              <small class='text-muted'>
+                <%= t(".hidden_comment_by_html",
+                      :time_ago => friendly_date_ago(comment.created_at),
+                      :user => link_to(comment.author.display_name, user_path(comment.author))) %>
+                — <button class="btn btn-sm small btn-link link-secondary p-0 align-baseline" data-method="POST" data-url="<%= changeset_comment_unhide_url(comment.id) %>"><%= t("javascripts.changesets.show.unhide_comment") %></button>
                 </small>
-                <div class="mx-2">
-                  <%= comment.body.to_html %>
-                </div>
-              </li>
-            <% elsif current_user and current_user.moderator? %>
-              <li id="c<%= comment.id %>">
-                <small class='text-muted'>
-                  <%= t(".hidden_comment_by_html",
-                        :time_ago => friendly_date_ago(comment.created_at),
-                        :user => link_to(comment.author.display_name, user_path(comment.author))) %>
-                  — <button class="btn btn-sm small btn-link link-secondary p-0 align-baseline" data-method="POST" data-url="<%= changeset_comment_unhide_url(comment.id) %>"><%= t("javascripts.changesets.show.unhide_comment") %></button>
-                 </small>
-                <div class="mx-2">
-                  <%= comment.body.to_html %>
-                </div>
-              </li>
-            <% end %>
+              <div class="mx-2">
+                <%= comment.body.to_html %>
+              </div>
+            </li>
           <% end %>
-        </ul>
-      </form>
-    </div>
+        <% end %>
+      </ul>
+    </form>
   <% end %>
 
   <% unless current_user %>

diff --git a/test/controllers/browse_controller_test.rb b/test/controllers/browse_controller_test.rb
index 7df246c5781c65e609737be9f151c9eff7a4e875..0709d544e8e938739bc00d4a19632d2b8d938ad0 100644 (file)
--- a/test/controllers/browse_controller_test.rb
+++ b/test/controllers/browse_controller_test.rb
@@ -142,20 +142,6 @@ class BrowseControllerTest < ActionDispatch::IntegrationTest
     browse_check :changeset_path, changeset.id, "browse/changeset"
   end
 
-  def test_read_changeset_hidden_comments
-    changeset = create(:changeset)
-    create_list(:changeset_comment, 3, :changeset => changeset)
-    create(:changeset_comment, :visible => false, :changeset => changeset)
-
-    browse_check :changeset_path, changeset.id, "browse/changeset"
-    assert_select "div.changeset-comments ul li", :count => 3
-
-    session_for(create(:moderator_user))
-
-    browse_check :changeset_path, changeset.id, "browse/changeset"
-    assert_select "div.changeset-comments ul li", :count => 4
-  end
-
   ##
   #  Methods to check redaction.
   #