Make all factory-generated users 'normal'
authorAndy Allan <git@gravitystorm.co.uk>
Wed, 22 Feb 2017 18:14:53 +0000 (18:14 +0000)
committerAndy Allan <git@gravitystorm.co.uk>
Wed, 22 Feb 2017 18:26:03 +0000 (18:26 +0000)
commit91f3339b6a5290b5fbbf58f57ef4f623ab7a8c56
treee0c04d11ea2facca0ccc940fb689d6b4db69dd83
parent91e33f50bcd8c6b30693cde347ad0626ad52ff21
Make all factory-generated users 'normal'

The use of create(:normal_user) makes the tests needlessly harder to
understand and reason about, particularly when we start using
associations in the factories.
test/controllers/amf_controller_test.rb
test/controllers/api_controller_test.rb
test/controllers/diary_entry_controller_test.rb
test/controllers/notes_controller_test.rb
test/factories/user.rb