Updates `sass-embedded` from 1.108.1 to 1.108.2
- [Commits](https://github.com/sass-contrib/sass-embedded-host-ruby/compare/v1.108.1...v1.108.2)
Updates `omniauth` from 2.3.1 to 2.4.1
- [Release notes](https://github.com/omniauth/omniauth/releases)
- [Changelog](https://github.com/omniauth/omniauth/blob/master/CHANGELOG.md)
- [Commits](https://github.com/omniauth/omniauth/compare/v2.3.1...v2.4.1)
Updates `dalli` from 5.3.2 to 5.3.3
- [Release notes](https://github.com/petergoldstein/dalli/releases)
- [Changelog](https://github.com/petergoldstein/dalli/blob/main/CHANGELOG.md)
- [Commits](https://github.com/petergoldstein/dalli/compare/v5.3.2...v5.3.3)
Updates `opentelemetry-instrumentation-all` from 0.100.0 to 0.101.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-ruby-contrib/releases)
- [Commits](https://github.com/open-telemetry/opentelemetry-ruby-contrib/compare/opentelemetry-instrumentation-all/v0.100.0...opentelemetry-instrumentation-all/v0.101.0)
Updates `aws-sdk-s3` from 1.239.0 to 1.242.0
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases)
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-ruby/commits)
Updates `i18n-tasks` from 1.2.0 to 1.2.1
- [Release notes](https://github.com/glebm/i18n-tasks/releases)
- [Changelog](https://github.com/glebm/i18n-tasks/blob/main/CHANGES.md)
- [Commits](https://github.com/glebm/i18n-tasks/compare/v1.2.0...v1.2.1)
Updates `overcommit` from 0.75.0 to 0.76.0
- [Release notes](https://github.com/sds/overcommit/releases)
- [Changelog](https://github.com/sds/overcommit/blob/main/CHANGELOG.md)
- [Commits](https://github.com/sds/overcommit/compare/v0.75.0...v0.76.0)
Updates `puma` from 8.0.2 to 8.1.1
- [Release notes](https://github.com/puma/puma/releases)
- [Changelog](https://github.com/puma/puma/blob/main/History.md)
- [Commits](https://github.com/puma/puma/compare/v8.0.2...v8.1.1)
Updates `aws-partitions` from 1.1305.0 to 1.1308.0
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases)
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-partitions/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-ruby/commits)
Updates `aws-sdk-core` from 3.268.0 to 3.270.0
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases)
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-core/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-ruby/commits)
Updates `aws-sdk-kms` from 1.143.0 to 1.145.0
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases)
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-kms/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-ruby/commits)
Updates `brotli` from 0.9.2 to 0.9.3
- [Commits](https://github.com/miyucy/brotli/compare/v0.9.2...v0.9.3)
Updates `opentelemetry-instrumentation-action_pack` from 0.18.1 to 0.19.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-ruby-contrib/releases)
- [Commits](https://github.com/open-telemetry/opentelemetry-ruby-contrib/compare/opentelemetry-instrumentation-action_pack/v0.18.1...opentelemetry-instrumentation-action_pack/v0.19.0)
Updates `opentelemetry-instrumentation-anthropic` from 0.5.0 to 0.6.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-ruby-contrib/releases)
- [Commits](https://github.com/open-telemetry/opentelemetry-ruby-contrib/compare/opentelemetry-instrumentation-anthropic/v0.5.0...opentelemetry-instrumentation-anthropic/v0.6.0)
Updates `opentelemetry-instrumentation-grape` from 0.7.2 to 0.7.3
- [Release notes](https://github.com/open-telemetry/opentelemetry-ruby-contrib/releases)
- [Commits](https://github.com/open-telemetry/opentelemetry-ruby-contrib/compare/opentelemetry-instrumentation-grape/v0.7.2...opentelemetry-instrumentation-grape/v0.7.3)
Updates `opentelemetry-semantic_conventions` from 1.44.0 to 1.45.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-ruby/releases)
- [Commits](https://github.com/open-telemetry/opentelemetry-ruby/compare/opentelemetry-semantic_conventions/v1.44.0...opentelemetry-semantic_conventions/v1.45.0)
Updates `process_executer` from 4.1.1 to 4.1.3
- [Release notes](https://github.com/main-branch/process_executer/releases)
- [Changelog](https://github.com/main-branch/process_executer/blob/main/CHANGELOG.md)
- [Commits](https://github.com/main-branch/process_executer/compare/v4.1.1...v4.1.3)
Updates `rack-protection` from 4.2.1 to 4.2.2
- [Changelog](https://github.com/sinatra/sinatra/blob/main/CHANGELOG.md)
- [Commits](https://github.com/sinatra/sinatra/compare/v4.2.1...v4.2.2)
Updates `leaflet.locatecontrol` from 0.90.1 to 0.91.0
- [Changelog](https://github.com/domoritz/leaflet-locatecontrol/blob/gh-pages/CHANGELOG.md)
- [Commits](https://github.com/domoritz/leaflet-locatecontrol/compare/v0.90.1...v0.91.0)
Updates `maplibre-gl` from 5.24.0 to 5.24.1
- [Release notes](https://github.com/maplibre/maplibre-gl-js/releases)
- [Changelog](https://github.com/maplibre/maplibre-gl-js/blob/v5.24.1/CHANGELOG.md)
- [Commits](https://github.com/maplibre/maplibre-gl-js/compare/v5.24.0...v5.24.1)
Updates `osm-community-index` from 6.2.0 to 7.0.0
- [Release notes](https://github.com/osmlab/osm-community-index/releases)
- [Changelog](https://github.com/osmlab/osm-community-index/blob/main/CHANGELOG.md)
- [Commits](https://github.com/osmlab/osm-community-index/compare/v6.2.0...v7.0.0)
Updates `terra-draw` from 1.39.0 to 1.40.0
- [Release notes](https://github.com/JamesLMilner/terra-draw/releases)
- [Changelog](https://github.com/JamesLMilner/terra-draw/blob/main/release.js)
- [Commits](https://github.com/JamesLMilner/terra-draw/compare/terra-draw@1.39.0...terra-draw@1.40.0)
Updates `@stylistic/eslint-plugin` from 5.10.0 to 6.0.0
- [Release notes](https://github.com/eslint-stylistic/eslint-stylistic/releases)
- [Commits](https://github.com/eslint-stylistic/eslint-stylistic/commits/v6.0.0/packages/eslint-plugin)
Updates `eslint` from 10.14.0 to 10.15.0
- [Release notes](https://github.com/eslint/eslint/releases)
- [Commits](https://github.com/eslint/eslint/compare/v10.14.0...v10.15.0)
Updates `activerecord-postgis` from 0.6.1 to 0.6.2
- [Release notes](https://github.com/seuros/activerecord-postgis/releases)
- [Changelog](https://github.com/seuros/activerecord-postgis/blob/master/CHANGELOG.md)
- [Commits](https://github.com/seuros/activerecord-postgis/compare/activerecord-postgis/v0.6.1...activerecord-postgis/v0.6.2)
Updates `sass-embedded` from 1.107.1 to 1.108.1
- [Commits](https://github.com/sass-contrib/sass-embedded-host-ruby/compare/v1.107.1...v1.108.1)
Updates `sanitize` from 7.0.1 to 7.0.2
- [Release notes](https://github.com/rgrove/sanitize/releases)
- [Changelog](https://github.com/rgrove/sanitize/blob/main/CHANGELOG.md)
- [Commits](https://github.com/rgrove/sanitize/compare/v7.0.1...v7.0.2)
Updates `dalli` from 5.2.5 to 5.3.2
- [Release notes](https://github.com/petergoldstein/dalli/releases)
- [Changelog](https://github.com/petergoldstein/dalli/blob/main/CHANGELOG.md)
- [Commits](https://github.com/petergoldstein/dalli/compare/v5.2.5...v5.3.2)
Updates `opentelemetry-instrumentation-all` from 0.99.0 to 0.100.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-ruby-contrib/releases)
- [Commits](https://github.com/open-telemetry/opentelemetry-ruby-contrib/compare/opentelemetry-instrumentation-all/v0.99.0...opentelemetry-instrumentation-all/v0.100.0)
Updates `aws-sdk-s3` from 1.237.0 to 1.239.0
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases)
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-ruby/commits)
Updates `noticed` from 3.1.0 to 3.1.1
- [Release notes](https://github.com/excid3/noticed/releases)
- [Changelog](https://github.com/excid3/noticed/blob/main/CHANGELOG.md)
- [Commits](https://github.com/excid3/noticed/compare/v3.1.0...v3.1.1)
Updates `herb` from 0.11.1 to 0.11.2
- [Release notes](https://github.com/marcoroth/herb/releases)
- [Commits](https://github.com/marcoroth/herb/compare/v0.11.1...v0.11.2)
Updates `i18n-tasks` from 1.1.2 to 1.2.0
- [Release notes](https://github.com/glebm/i18n-tasks/releases)
- [Changelog](https://github.com/glebm/i18n-tasks/blob/main/CHANGES.md)
- [Commits](https://github.com/glebm/i18n-tasks/compare/v1.1.2...v1.2.0)
Updates `overcommit` from 0.74.0 to 0.75.0
- [Release notes](https://github.com/sds/overcommit/releases)
- [Changelog](https://github.com/sds/overcommit/blob/main/CHANGELOG.md)
- [Commits](https://github.com/sds/overcommit/compare/v0.74.0...v0.75.0)
Updates `minitest` from 6.0.6 to 6.1.0
- [Changelog](https://github.com/minitest/minitest/blob/master/History.rdoc)
- [Commits](https://github.com/minitest/minitest/compare/v6.0.6...v6.1.0)
Updates `aws-partitions` from 1.1301.0 to 1.1305.0
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases)
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-partitions/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-ruby/commits)
Updates `aws-sdk-core` from 3.264.0 to 3.268.0
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases)
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-core/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-ruby/commits)
Updates `aws-sdk-kms` from 1.139.0 to 1.143.0
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases)
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-kms/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-ruby/commits)
Updates `faraday-http-cache` from 2.8.0 to 3.0.0
- [Release notes](https://github.com/plataformatec/faraday-http-cache/releases)
- [Changelog](https://github.com/sourcelevel/faraday-http-cache/blob/master/CHANGELOG.md)
- [Commits](https://github.com/plataformatec/faraday-http-cache/compare/v2.8.0...v3.0.0)
Updates `googleapis-common-protos-types` from 1.24.0 to 1.25.0
- [Release notes](https://github.com/googleapis/common-protos-ruby/releases)
- [Commits](https://github.com/googleapis/common-protos-ruby/compare/googleapis-common-protos-types/v1.24.0...googleapis-common-protos-types/v1.25.0)
Updates `hashdiff` from 1.2.1 to 1.2.2
- [Changelog](https://github.com/liufengyun/hashdiff/blob/master/changelog.md)
- [Commits](https://github.com/liufengyun/hashdiff/compare/v1.2.1...v1.2.2)
Updates `irb` from 1.18.0 to 1.19.0
- [Release notes](https://github.com/ruby/irb/releases)
- [Commits](https://github.com/ruby/irb/compare/v1.18.0...v1.19.0)
Updates `nap` from 1.1.1 to 1.2.0
- [Release notes](https://github.com/Fingertips/nap/releases)
- [Commits](https://github.com/Fingertips/nap/compare/v1.1.1...v1.2.0)
Updates `oauth` from 1.1.8 to 1.1.9
- [Release notes](https://github.com/ruby-oauth/oauth/releases)
- [Changelog](https://github.com/ruby-oauth/oauth/blob/main/CHANGELOG.md)
- [Commits](https://github.com/ruby-oauth/oauth/compare/v1.1.8...v1.1.9)
Updates `opentelemetry-instrumentation-net_http` from 0.29.2 to 0.30.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-ruby-contrib/releases)
- [Commits](https://github.com/open-telemetry/opentelemetry-ruby-contrib/compare/opentelemetry-instrumentation-net_http/v0.29.2...opentelemetry-instrumentation-net_http/v0.30.0)
Updates `prism` from 1.9.0 to 2.1.0
- [Release notes](https://github.com/ruby/prism/releases)
- [Changelog](https://github.com/ruby/prism/blob/main/CHANGELOG.md)
- [Commits](https://github.com/ruby/prism/compare/v1.9.0...v2.1.0)
Andy Allan [Wed, 28 Oct 2026 16:05:15 +0000 (16:05 +0000)]
Restrict avatar uploads to types we can safely resize
SVG avatars don't need resizing, but can be arbitrarily complex to render.
BMP, ICO, PSD (and SVG) avatars pass the processable_file validation.
However they can't be resized, since libvips can only load them with
untrusted loaders and these loaders are blocked. Unresized avatars are not a good idea
so we need to block these types too.
Only accept PNG, JPEG, GIF, WebP, TIFF, HEIC/HEIF and AVIF, which have trusted
libvips loaders, and limit uploads to 5 MB. Variants of the types that aren't
considered as web images are automatically converted to PNG by ActiveStorage.
HEIC and AVIF are decoded by libheif plugins. On Debian 13, which the
production web servers run, libheif1 depends on both decoder plugins,
but Ubuntu doesn't install the HEIC one by default, and so the tests only
check that these types are accepted without trying to resize them.
The checks only apply to new uploads, so existing avatars are unaffected.
Andy Allan [Wed, 28 Oct 2026 17:03:49 +0000 (17:03 +0000)]
Fix avatars attached to notification emails
Downloading a variant that hasn't been processed yet returns nil,
so emails could get an empty avatar unless the 50x50 variant already
existed. Instead, ensure the variant is processed before downloading it.
Variants of types that aren't web images are converted to PNG, but the
attachment was named after the original type. For example an avatar that
was originally a TIFF was attached as avatar.tif, despite having been
resized to a png. Instead, we name the attachment after the type
of the image actually attached.
helloigig [Wed, 4 Nov 2026 00:49:09 +0000 (00:49 +0000)]
Keep the map context menu inside the map on short screens
When the map is short, for example on a phone with a near-square
screen, the context menu could open where there wasn't enough room
either below or above the click. It then ran off the bottom of the
map and the lower items couldn't be reached.
Let Popper shift the menu vertically to keep it inside the map, and
limit its height to the height of the map so that it scrolls when
the map is shorter than the menu.
Andy Allan [Thu, 5 Nov 2026 09:57:53 +0000 (09:57 +0000)]
Move exim email checks into a DeliverableEmailValidator
The exim local part restrictions aren't really character validation, so
move them out of CharactersValidator into a dedicated email validator.
This runs the validates_email_format_of RFC checks first, and only applies
the exim restrictions to addresses that pass them, so users see a single
relevant error message.
Andy Allan [Thu, 5 Nov 2026 09:50:34 +0000 (09:50 +0000)]
Install only runtime packages in CI workflows
Install libvips42t64 instead of libvips-dev, as ruby-vips loads the
library via FFI and doesn't need the headers, and skip recommended
packages. This avoids installing 202 unneeded packages (development
headers, ImageMagick, mkdocs and other Python tools etc.) on every job.
Updates `sass-embedded` from 1.106.1 to 1.107.1
- [Commits](https://github.com/sass-contrib/sass-embedded-host-ruby/compare/v1.106.1...v1.107.1)
Updates `bootsnap` from 1.26.0 to 1.26.1
- [Release notes](https://github.com/rails/bootsnap/releases)
- [Changelog](https://github.com/rails/bootsnap/blob/main/CHANGELOG.md)
- [Commits](https://github.com/rails/bootsnap/compare/v1.26.0...v1.26.1)
Updates `activerecord-import` from 3.0.0 to 3.0.1
- [Changelog](https://github.com/zdennis/activerecord-import/blob/master/CHANGELOG.md)
- [Commits](https://github.com/zdennis/activerecord-import/compare/v3.0.0...v3.0.1)
Updates `addressable` from 2.9.0 to 2.9.2
- [Changelog](https://github.com/sporkmonger/addressable/blob/main/CHANGELOG.md)
- [Commits](https://github.com/sporkmonger/addressable/compare/addressable-2.9.0...addressable-2.9.2)
Updates `faraday` from 2.15.0 to 2.15.1
- [Release notes](https://github.com/lostisland/faraday/releases)
- [Changelog](https://github.com/lostisland/faraday/blob/main/CHANGELOG.md)
- [Commits](https://github.com/lostisland/faraday/compare/v2.15.0...v2.15.1)
Updates `rotp` from 6.3.0 to 6.4.0
- [Release notes](https://github.com/mdp/rotp/releases)
- [Changelog](https://github.com/mdp/rotp/blob/main/CHANGELOG.md)
- [Commits](https://github.com/mdp/rotp/compare/v6.3.0...v6.4.0)
Updates `dalli` from 5.2.2 to 5.2.5
- [Release notes](https://github.com/petergoldstein/dalli/releases)
- [Changelog](https://github.com/petergoldstein/dalli/blob/main/CHANGELOG.md)
- [Commits](https://github.com/petergoldstein/dalli/compare/v5.2.2...v5.2.5)
Updates `sentry-delayed_job` from 7.1.0 to 7.2.0
- [Release notes](https://github.com/getsentry/sentry-ruby/releases)
- [Changelog](https://github.com/getsentry/sentry-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/getsentry/sentry-ruby/compare/7.1.0...7.2.0)
Updates `sentry-rails` from 7.1.0 to 7.2.0
- [Release notes](https://github.com/getsentry/sentry-ruby/releases)
- [Changelog](https://github.com/getsentry/sentry-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/getsentry/sentry-ruby/compare/7.1.0...7.2.0)
Updates `sentry-ruby` from 7.1.0 to 7.2.0
- [Release notes](https://github.com/getsentry/sentry-ruby/releases)
- [Changelog](https://github.com/getsentry/sentry-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/getsentry/sentry-ruby/compare/7.1.0...7.2.0)
Updates `aws-sdk-s3` from 1.235.0 to 1.237.0
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases)
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-ruby/commits)
Updates `git` from 5.6.0 to 5.7.1
- [Release notes](https://github.com/ruby-git/ruby-git/releases)
- [Changelog](https://github.com/ruby-git/ruby-git/blob/v5.7.1/CHANGELOG.md)
- [Commits](https://github.com/ruby-git/ruby-git/compare/v5.6.0...v5.7.1)
Updates `overcommit` from 0.73.0 to 0.74.0
- [Release notes](https://github.com/sds/overcommit/releases)
- [Changelog](https://github.com/sds/overcommit/blob/main/CHANGELOG.md)
- [Commits](https://github.com/sds/overcommit/compare/v0.73.0...v0.74.0)
Updates `prosopite` from 2.2.0 to 2.5.0
- [Release notes](https://github.com/charkost/prosopite/releases)
- [Changelog](https://github.com/charkost/prosopite/blob/main/CHANGELOG.md)
- [Commits](https://github.com/charkost/prosopite/compare/2.2.0...2.5.0)
Updates `selenium-webdriver` from 4.51.0 to 4.52.0
- [Release notes](https://github.com/SeleniumHQ/selenium/releases)
- [Changelog](https://github.com/SeleniumHQ/selenium/blob/trunk/rb/CHANGES)
- [Commits](https://github.com/SeleniumHQ/selenium/compare/selenium-4.51.0...selenium-4.52.0)
Updates `annotaterb` from 4.25.0 to 4.26.0
- [Changelog](https://github.com/drwl/annotaterb/blob/main/CHANGELOG.md)
- [Commits](https://github.com/drwl/annotaterb/compare/v4.25.0...v4.26.0)
Updates `database_consistency` from 3.1.1 to 3.1.2
- [Changelog](https://github.com/djezzzl/database_consistency/blob/master/CHANGELOG.md)
- [Commits](https://github.com/djezzzl/database_consistency/compare/v3.1.1...v3.1.2)
Updates `aws-partitions` from 1.1299.1 to 1.1301.0
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases)
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-partitions/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-ruby/commits)
Updates `aws-sdk-core` from 3.262.0 to 3.264.0
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases)
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-core/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-ruby/commits)
Updates `aws-sdk-kms` from 1.137.0 to 1.139.0
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases)
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-kms/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-ruby/commits)
Updates `ffi-compiler` from 1.4.2 to 1.4.3
- [Release notes](https://github.com/ffi/ffi-compiler/releases)
- [Commits](https://github.com/ffi/ffi-compiler/compare/1.4.2...1.4.3)
Updates `msgpack` from 1.8.5 to 1.8.7
- [Changelog](https://github.com/msgpack/msgpack-ruby/blob/master/ChangeLog)
- [Commits](https://github.com/msgpack/msgpack-ruby/compare/v1.8.5...v1.8.7)
Updates `nap` from 1.1.0 to 1.1.1
- [Release notes](https://github.com/Fingertips/nap/releases)
- [Commits](https://github.com/Fingertips/nap/compare/v1.1.0...v1.1.1)
Updates `pstore` from 0.2.1 to 0.3.0
- [Release notes](https://github.com/ruby/pstore/releases)
- [Commits](https://github.com/ruby/pstore/compare/v0.2.1...v0.3.0)
Updates `rack` from 3.2.7 to 3.2.8
- [Release notes](https://github.com/rack/rack/releases)
- [Changelog](https://github.com/rack/rack/blob/main/CHANGELOG.md)
- [Commits](https://github.com/rack/rack/compare/v3.2.7...v3.2.8)
dependabot[bot] [Wed, 4 Nov 2026 23:13:08 +0000 (23:13 +0000)]
Bump the dependencies group with 3 updates
Bumps the dependencies group with 3 updates: [terra-draw](https://github.com/JamesLMilner/terra-draw), [eslint](https://github.com/eslint/eslint) and [globals](https://github.com/sindresorhus/globals).
Updates `terra-draw` from 1.38.0 to 1.39.0
- [Release notes](https://github.com/JamesLMilner/terra-draw/releases)
- [Changelog](https://github.com/JamesLMilner/terra-draw/blob/main/release.js)
- [Commits](https://github.com/JamesLMilner/terra-draw/compare/terra-draw@1.38.0...terra-draw@1.39.0)
Updates `eslint` from 10.13.0 to 10.14.0
- [Release notes](https://github.com/eslint/eslint/releases)
- [Commits](https://github.com/eslint/eslint/compare/v10.13.0...v10.14.0)
Updates `globals` from 17.13.0 to 17.14.0
- [Release notes](https://github.com/sindresorhus/globals/releases)
- [Commits](https://github.com/sindresorhus/globals/compare/v17.13.0...v17.14.0)
Pablo Brasero [Wed, 4 Nov 2026 16:10:10 +0000 (16:10 +0000)]
Consistent strip of leading/trailing spaces
We apply `#strip` to both the username and email when attempting a log in.
However we apply it in two different places in a way that seems to suggest
that usernames can have leading/trailing spaces, but actually is not the case.
Andy Allan [Wed, 4 Nov 2026 16:17:37 +0000 (16:17 +0000)]
Reject email addresses that exim relays will reject
Exim's default configuration, which OSMF's mail servers use, rejects
recipients on remote domains whose local part starts with ".", "/" or
"|", contains "@", "%" or "!", or contains "/../". Those addresses are
valid by RFC 5322 so they pass format validation. Emails to such
addresses fail in exim with "550 Restricted characters in address".
Extend the existing percent-character check to cover the whole exim rule,
but applied to the local part only.
Show a preview of the tags when uploading or editing a trace
The help for the tags field says that they are comma delimited, but
if there aren't any commas they are split on spaces instead, so
"Foo Bar" gives two tags rather than one.
Rather than trying to explain that in the help, show the tags that
will be created after it as they are typed, split in the same way as
Trace#tagstring= does, and change the help to say whether they are
comma or space delimited. The help is left as it was unless there
would be more than one tag.
Pablo Brasero [Wed, 28 Oct 2026 17:37:03 +0000 (17:37 +0000)]
Use existing helpers. Make them more flexible where useful
It seems that we added the `session_for` helper but missed a couple
of places where it could be used. I have added them, as well as
added a new option `:referer` for the one case where we specifically
need it in our tests.
If we integrate a third-party library to handle authentication
(eg: Devise), the precise way to log in may change and we'll probably
get new authentication test helpers. If we normalize all these
interactions in advance, a potential upcoming PR will be less
traumatic.
Pablo Brasero [Thu, 29 Oct 2026 18:09:55 +0000 (18:09 +0000)]
Ensure that password does upgrade during login procedure
This was only tested at the level of the `PasswordHash` library, which
I find insufficient. We know that the underlying library works, but
does the code that integrates it do the right thing?
Pablo Brasero [Wed, 28 Oct 2026 16:28:11 +0000 (16:28 +0000)]
Ensure correct behaviour when the user is unknown
This is not a big deal for us, since in this codebase it's equivalent
to the password being wrong, etc. However:
- We should be testing all potential behaviours, irrespective of how we
implement things under the hood.
- If we integrate a third-party solution for authentication, this
may be different. It's indeed a different code path in Devise,
so this PR reduces the size of a potential future Devise PR.
Pablo Brasero [Thu, 29 Oct 2026 17:28:20 +0000 (17:28 +0000)]
Test realistic scenarios. Plus weird ones are ok too
This was testing the behaviour of logging out, but without
being logged in first. For our current code this might not
matter, but it does matter with other solutions such as Devise.
We should test the different interactions more carefully.