rails.git
11 years agofinished Rails-friendly amf_controller. Note that this requires Tom's patched composi...
Richard Fairhurst [Fri, 14 Nov 2008 17:36:38 +0000 (17:36 +0000)]
finished Rails-friendly amf_controller. Note that this requires Tom's patched composite_primary_keys to work unless you tell Potlatch to use SQL reads

11 years agoMore unit test stubs
Shaun McDonald [Fri, 14 Nov 2008 17:28:16 +0000 (17:28 +0000)]
More unit test stubs

11 years agoUnit tests work again. Fixed the set fixture class that I should. Adding 2 length...
Shaun McDonald [Fri, 14 Nov 2008 16:26:56 +0000 (16:26 +0000)]
Unit tests work again. Fixed the set fixture class that I should. Adding 2 length checks to the user preference controller.

11 years agoAdding some more unit test stubs that need filling out. Adding changeset tags fixture...
Shaun McDonald [Fri, 14 Nov 2008 02:06:04 +0000 (02:06 +0000)]
Adding some more unit test stubs that need filling out. Adding changeset tags fixture. Indentation fix in way model.

11 years agoAdding some more diary entry tests. Making the RSS feed links more portable, by using...
Shaun McDonald [Thu, 13 Nov 2008 17:20:40 +0000 (17:20 +0000)]
Adding some more diary entry tests. Making the RSS feed links more portable, by using the SERVER_URL constant. Fixing the validation for the length of the language of diary entries until the i18n branch is integrated.

11 years agoCovering the case of an entry not being found. More diary entry tests.
Shaun McDonald [Wed, 12 Nov 2008 18:48:58 +0000 (18:48 +0000)]
Covering the case of an entry not being found. More diary entry tests.

11 years agoreplaced "wtf does this do" comment by something explaining what it does.
Frederik Ramm [Wed, 12 Nov 2008 00:11:57 +0000 (00:11 +0000)]
replaced "wtf does this do" comment by something explaining what it does.

11 years agomore diary entry test
Shaun McDonald [Tue, 11 Nov 2008 18:33:08 +0000 (18:33 +0000)]
more diary entry test

11 years agomore diary entry tests, and a minor fix to the relation member that makes the code...
Shaun McDonald [Tue, 11 Nov 2008 18:07:59 +0000 (18:07 +0000)]
more diary entry tests, and a minor fix to the relation member that makes the code a bit more readable.

11 years agoslight more work on the diary test
Shaun McDonald [Mon, 10 Nov 2008 19:21:59 +0000 (19:21 +0000)]
slight more work on the diary test

11 years agoPostgres adapter, and make migration 022 db-agnostic
Andy Allan [Mon, 10 Nov 2008 19:14:00 +0000 (19:14 +0000)]
Postgres adapter, and make migration 022 db-agnostic

11 years agonil protection - mysql however has a default for enums, which is why it wasn't a...
Andy Allan [Mon, 10 Nov 2008 17:10:55 +0000 (17:10 +0000)]
nil protection - mysql however has a default for enums, which is why it wasn't a problem before

11 years agoMade relations ordered. Added some tests for this. Otherwise interface is unchanged.
Matt Amos [Mon, 10 Nov 2008 15:41:05 +0000 (15:41 +0000)]
Made relations ordered. Added some tests for this. Otherwise interface is unchanged.

11 years agoOoops, forgot to commit the routes for the changeset query and include calls.
Matt Amos [Mon, 10 Nov 2008 15:37:34 +0000 (15:37 +0000)]
Ooops, forgot to commit the routes for the changeset query and include calls.

11 years agoboolean correctness
Andy Allan [Mon, 10 Nov 2008 11:47:20 +0000 (11:47 +0000)]
boolean correctness

11 years agoforgot the test change from 11866
Andy Allan [Mon, 10 Nov 2008 11:39:10 +0000 (11:39 +0000)]
forgot the test change from 11866

11 years agoIn YAML yes is a boolean keyword: also fix test that was erroneously asserting success
Andy Allan [Mon, 10 Nov 2008 11:32:17 +0000 (11:32 +0000)]
In YAML yes is a boolean keyword: also fix test that was erroneously asserting success

11 years ago0.6-friendly Potlatch (work in progress). DO NOT SET POTLATCH_USE_SQL=false as it...
Richard Fairhurst [Sun, 9 Nov 2008 23:50:03 +0000 (23:50 +0000)]
0.6-friendly Potlatch (work in progress). DO NOT SET POTLATCH_USE_SQL=false as it won't work

11 years agoadding first integration for testing user diaries, as multiple controllers are requir...
Shaun McDonald [Sun, 9 Nov 2008 19:51:56 +0000 (19:51 +0000)]
adding first integration for testing user diaries, as multiple controllers are required. more work required.

11 years agoremove indexes before renaming tables (some dbs have database-level index namespaces...
Andy Allan [Sun, 9 Nov 2008 19:30:22 +0000 (19:30 +0000)]
remove indexes before renaming tables (some dbs have database-level index namespaces) and unsigned is also a mysqlism

11 years agoamf get*_history tests and related fixes
Dave Stubbs [Sun, 9 Nov 2008 18:48:16 +0000 (18:48 +0000)]
amf get*_history tests and related fixes

11 years agoa few more amf tests and associated bug fixes
Dave Stubbs [Sun, 9 Nov 2008 17:41:38 +0000 (17:41 +0000)]
a few more amf tests and associated bug fixes

11 years agofixing the tests due to a osm -> diffChange and moving to floats
Shaun McDonald [Sun, 9 Nov 2008 16:49:27 +0000 (16:49 +0000)]
fixing the tests due to a osm -> diffChange and moving to floats

11 years agoupdate nodes/ways/relation XML to include user id as well as display name
Dave Stubbs [Sun, 9 Nov 2008 16:43:09 +0000 (16:43 +0000)]
update nodes/ways/relation XML to include user id as well as display name

11 years agoreturn user id AND name with changeset get request
Frederik Ramm [Sun, 9 Nov 2008 16:12:23 +0000 (16:12 +0000)]
return user id AND name with changeset get request

11 years agomigrations: add specific method for nodes/ways/relations enum column
Andy Allan [Sun, 9 Nov 2008 16:11:42 +0000 (16:11 +0000)]
migrations: add specific method for nodes/ways/relations enum column

11 years agofix SCALE, make changeset GET use floats
Frederik Ramm [Sun, 9 Nov 2008 15:52:10 +0000 (15:52 +0000)]
fix SCALE, make changeset GET use floats

11 years agorequire auth for close
Frederik Ramm [Sun, 9 Nov 2008 13:44:08 +0000 (13:44 +0000)]
require auth for close

11 years agocosmetic tweaks to 'login' and 'create account' screens
Harry Wood [Sun, 9 Nov 2008 12:17:53 +0000 (12:17 +0000)]
cosmetic tweaks to 'login' and 'create account' screens

11 years agomini fix
Frederik Ramm [Sun, 9 Nov 2008 12:06:05 +0000 (12:06 +0000)]
mini fix

11 years agomake diff upload result a "diffResult" rather than "osm" document
Frederik Ramm [Sun, 9 Nov 2008 11:30:03 +0000 (11:30 +0000)]
make diff upload result a "diffResult" rather than "osm" document

11 years agomove index dropping to remove_index method
Andy Allan [Sun, 9 Nov 2008 11:19:46 +0000 (11:19 +0000)]
move index dropping to remove_index method

11 years agobumping the version of composite primary keys for the amf controler as there are...
Shaun McDonald [Sun, 9 Nov 2008 11:13:10 +0000 (11:13 +0000)]
bumping the version of composite primary keys for the amf controler as there are bugs in it

11 years agooops remove my test
Harry Wood [Sun, 9 Nov 2008 10:57:05 +0000 (10:57 +0000)]
oops remove my test

11 years agoUpdate DB readme for PgSQL a bit
Daniel Silverstone [Sun, 9 Nov 2008 10:41:48 +0000 (10:41 +0000)]
Update DB readme for PgSQL a bit

11 years agofix accidental commit of local config changes
Frederik Ramm [Sat, 8 Nov 2008 19:55:13 +0000 (19:55 +0000)]
fix accidental commit of local config changes

11 years agofix version number return for "modify" sections of diff uploads
Frederik Ramm [Sat, 8 Nov 2008 19:43:31 +0000 (19:43 +0000)]
fix version number return for "modify" sections of diff uploads

11 years ago1st amf_controller tests, and some basic sanity check fixes
Dave Stubbs [Sat, 8 Nov 2008 19:41:29 +0000 (19:41 +0000)]
1st amf_controller tests, and some basic sanity check fixes

11 years agoIgnore the bits in tmp/
Daniel Silverstone [Sat, 8 Nov 2008 19:33:41 +0000 (19:33 +0000)]
Ignore the bits in tmp/

11 years agoCREATE FUNCTION statement for pgsql
Daniel Silverstone [Sat, 8 Nov 2008 19:21:03 +0000 (19:21 +0000)]
CREATE FUNCTION statement for pgsql

11 years agoSupport building a postgresql binding for maptile_for_point
Daniel Silverstone [Sat, 8 Nov 2008 19:18:22 +0000 (19:18 +0000)]
Support building a postgresql binding for maptile_for_point

11 years agocosmetic tweaks to user settings form + move 'Mapper since' field onto user profile...
Harry Wood [Sat, 8 Nov 2008 19:03:25 +0000 (19:03 +0000)]
cosmetic tweaks to user settings form + move 'Mapper since' field onto user profile view

11 years agocorrecting typo on gps_points fixtures
Andy Allan [Sat, 8 Nov 2008 18:59:06 +0000 (18:59 +0000)]
correcting typo on gps_points fixtures

11 years agomove fulltext indexes to monkeypatch, since not all dbs have a fulltext analogue
Andy Allan [Sat, 8 Nov 2008 18:44:38 +0000 (18:44 +0000)]
move fulltext indexes to monkeypatch, since not all dbs have a fulltext analogue

11 years agoMove db engine changing into db adaptor monkeypatch
Andy Allan [Sat, 8 Nov 2008 18:04:36 +0000 (18:04 +0000)]
Move db engine changing into db adaptor monkeypatch

11 years agolast of the auto_increments removed from the migrations
Andy Allan [Sat, 8 Nov 2008 17:39:16 +0000 (17:39 +0000)]
last of the auto_increments removed from the migrations

11 years agoFixing boo-boo in r11802 - but you can assign integers to booleans on all dbs
Andy Allan [Sat, 8 Nov 2008 17:08:51 +0000 (17:08 +0000)]
Fixing boo-boo in r11802 - but you can assign integers to booleans on all dbs

11 years agoMoving AUTO_INCREMENTs to monkeypatching. Seems a bit hacky though
Andy Allan [Sat, 8 Nov 2008 16:47:02 +0000 (16:47 +0000)]
Moving AUTO_INCREMENTs to monkeypatching. Seems a bit hacky though

11 years agomessage with a logo and link to Contact page
Harry Wood [Sat, 8 Nov 2008 16:41:51 +0000 (16:41 +0000)]
message with a logo and link to Contact page

11 years agoBoolean correctness in migrations
Andy Allan [Sat, 8 Nov 2008 15:01:14 +0000 (15:01 +0000)]
Boolean correctness in migrations

11 years agoMake the confrm button into a confirm button
Daniel Silverstone [Sat, 8 Nov 2008 14:11:45 +0000 (14:11 +0000)]
Make the confrm button into a confirm button

11 years agoError message for version mismatch is now more informative.
Matt Amos [Sat, 8 Nov 2008 14:07:34 +0000 (14:07 +0000)]
Error message for version mismatch is now more informative.

11 years agomove bigint_pk id column into table def, no need to be an add_column
Andy Allan [Sat, 8 Nov 2008 12:30:42 +0000 (12:30 +0000)]
move bigint_pk id column into table def, no need to be an add_column

11 years agofixing one cmd that was missed in the resync
Shaun McDonald [Sat, 8 Nov 2008 12:16:42 +0000 (12:16 +0000)]
fixing one cmd that was missed in the resync

11 years agoResyncing from head 10895:11795
Shaun McDonald [Sat, 8 Nov 2008 11:52:58 +0000 (11:52 +0000)]
Resyncing from head 10895:11795

11 years agoAdding some diary fixtures and test stubs
Shaun McDonald [Sat, 8 Nov 2008 11:34:58 +0000 (11:34 +0000)]
Adding some diary fixtures and test stubs

11 years agoChange bigint id column to monkeypatching-friendly syntax
Andy Allan [Sat, 8 Nov 2008 11:01:39 +0000 (11:01 +0000)]
Change bigint id column to monkeypatching-friendly syntax

11 years agomore boolean correcting
Dave Stubbs [Sat, 8 Nov 2008 10:48:07 +0000 (10:48 +0000)]
more boolean correcting

11 years agoAdded a query method for querying bounding boxes, times and users of changesets....
Matt Amos [Fri, 7 Nov 2008 18:24:34 +0000 (18:24 +0000)]
Added a query method for querying bounding boxes, times and users of changesets. Needs (much) more testing.

11 years agofix the indentation only
Shaun McDonald [Fri, 7 Nov 2008 15:08:43 +0000 (15:08 +0000)]
fix the indentation only

11 years agosome boolean correctness work
Andy Allan [Fri, 7 Nov 2008 13:51:09 +0000 (13:51 +0000)]
some boolean correctness work

11 years agoadd fixme
Andy Allan [Fri, 7 Nov 2008 13:27:03 +0000 (13:27 +0000)]
add fixme

11 years agouse boolean flags when using boolean columns
Andy Allan [Fri, 7 Nov 2008 13:24:18 +0000 (13:24 +0000)]
use boolean flags when using boolean columns

11 years agoBooleans should be true/false - coding style comments welcome
Andy Allan [Fri, 7 Nov 2008 11:36:34 +0000 (11:36 +0000)]
Booleans should be true/false - coding style comments welcome

11 years agoD'oh! Fixed stupid errors in changeset controller.
Matt Amos [Fri, 7 Nov 2008 11:36:00 +0000 (11:36 +0000)]
D'oh! Fixed stupid errors in changeset controller.

11 years agousers fixtures should all have creation times
Andy Allan [Fri, 7 Nov 2008 11:21:46 +0000 (11:21 +0000)]
users fixtures should all have creation times

11 years agoBooleans should be true/false for compatibility with other db adapters
Andy Allan [Fri, 7 Nov 2008 11:20:25 +0000 (11:20 +0000)]
Booleans should be true/false for compatibility with other db adapters

11 years agoOoops. Added missing access control to changeset controller.
Matt Amos [Thu, 6 Nov 2008 19:10:19 +0000 (19:10 +0000)]
Ooops. Added missing access control to changeset controller.

11 years agoAdded a changeset/#id/include method to POST to to expand the bounding box.
Matt Amos [Thu, 6 Nov 2008 18:42:06 +0000 (18:42 +0000)]
Added a changeset/#id/include method to POST to to expand the bounding box.

11 years agoImplemented changeset bounding box handling for relations, based on the conversation...
Matt Amos [Thu, 6 Nov 2008 17:56:24 +0000 (17:56 +0000)]
Implemented changeset bounding box handling for relations, based on the conversation on the mailing list. Its a bit complex...

11 years agoDoing the update version part of the migration in chunks of 10000 instead of all...
Shaun McDonald [Thu, 6 Nov 2008 17:15:22 +0000 (17:15 +0000)]
Doing the update version part of the migration in chunks of 10000 instead of all at once so that MySQL doesn't choke with running out of table locks.

11 years agoRemoving depricated config option in the development env
Shaun McDonald [Thu, 6 Nov 2008 14:20:07 +0000 (14:20 +0000)]
Removing depricated config option in the development env

11 years agoFixing the migration so that it will better match the live databetter.
Shaun McDonald [Wed, 5 Nov 2008 18:42:38 +0000 (18:42 +0000)]
Fixing the migration so that it will better match the live databetter.

11 years agoUpdating the cycle map to use all zoom levels as per Andy Allan's message.
Shaun McDonald [Wed, 5 Nov 2008 17:37:14 +0000 (17:37 +0000)]
Updating the cycle map to use all zoom levels as per Andy Allan's message.

11 years agoAdded first attempt at bounding box support in changesets and tests for the same.
Matt Amos [Tue, 4 Nov 2008 15:52:22 +0000 (15:52 +0000)]
Added first attempt at bounding box support in changesets and tests for the same.

11 years agoMinor fix (integer => bigint) to one of the migrations so that they will run fully...
Shaun McDonald [Tue, 4 Nov 2008 13:54:45 +0000 (13:54 +0000)]
Minor fix (integer => bigint) to one of the migrations so that they will run fully again.

11 years agoAdding an extra test to make sure that the correct response is returned when an inval...
Shaun McDonald [Mon, 3 Nov 2008 18:54:19 +0000 (18:54 +0000)]
Adding an extra test to make sure that the correct response is returned when an invalid changeset action is uploaded.

11 years agoAdditional api tests for the changes. Also making sure that you cannot request a...
Shaun McDonald [Mon, 3 Nov 2008 18:05:19 +0000 (18:05 +0000)]
Additional api tests for the changes. Also making sure that you cannot request a change of 0 length, so that you can detect erronious input.

11 years agoAdding a restriction to prevent more than 2000 nodes to be added to any way. Tests...
Shaun McDonald [Mon, 3 Nov 2008 00:12:18 +0000 (00:12 +0000)]
Adding a restriction to prevent more than 2000 nodes to be added to any way. Tests still need to be written. Capabilities api request also updated.

11 years agoAdd a description meta tag for the all web pages. Wording probably needs to be improved.
Shaun McDonald [Fri, 31 Oct 2008 18:02:12 +0000 (18:02 +0000)]
Add a description meta tag for the all web pages. Wording probably needs to be improved.

11 years agoStarting the gpx trace testing with additional fixtures
Shaun McDonald [Thu, 30 Oct 2008 18:50:45 +0000 (18:50 +0000)]
Starting the gpx trace testing with additional fixtures

11 years agoAdded custom validator for UTF-8 strings.
Matt Amos [Wed, 29 Oct 2008 16:27:15 +0000 (16:27 +0000)]
Added custom validator for UTF-8 strings.

11 years agoadd a comment about why the error handler is required, as per mail from TomH. Also...
Shaun McDonald [Wed, 29 Oct 2008 15:45:48 +0000 (15:45 +0000)]
add a comment about why the error handler is required, as per mail from TomH. Also adding the option so that we are using the old style of migrations, rather than the 2.1+ migrations.

11 years agoBetter error message and test for invalid UTF-8 sequences.
Matt Amos [Wed, 29 Oct 2008 15:33:23 +0000 (15:33 +0000)]
Better error message and test for invalid UTF-8 sequences.

11 years agoPut back the units on all the zero values. Just because you can remove
Tom Hughes [Wed, 29 Oct 2008 13:49:45 +0000 (13:49 +0000)]
Put back the units on all the zero values. Just because you can remove
something doesn't mean it's a good idea...

11 years agoFix for bug #1242, css foreground set + css shorthands used
Hugh Barnes [Wed, 29 Oct 2008 13:05:14 +0000 (13:05 +0000)]
Fix for bug #1242, css foreground set + css shorthands used

11 years agoUpdating to use Rails 2.1.2. Moving the gem dependancies to the config/environment...
Shaun McDonald [Tue, 28 Oct 2008 20:42:48 +0000 (20:42 +0000)]
Updating to use Rails 2.1.2. Moving the gem dependancies to the config/environment.rb file. Moving the vendor/plugins externals into our svn.

11 years agomessage title shouldn't accept invalid utf-8 sequences - test currently fails
Andy Allan [Tue, 28 Oct 2008 18:34:05 +0000 (18:34 +0000)]
message title shouldn't accept invalid utf-8 sequences - test currently fails

11 years agoMade full test a bit more thorough.
Matt Amos [Tue, 28 Oct 2008 15:01:17 +0000 (15:01 +0000)]
Made full test a bit more thorough.

11 years agoAdded tests for relations for way/relation and a bit of DRYing up.
Matt Amos [Tue, 28 Oct 2008 14:49:51 +0000 (14:49 +0000)]
Added tests for relations for way/relation and a bit of DRYing up.

11 years agoAdding stub functional test files for all the controllers that should have tests...
Shaun McDonald [Tue, 28 Oct 2008 12:49:51 +0000 (12:49 +0000)]
Adding stub functional test files for all the controllers that should have tests written for them.

11 years agoMoving all the functional tests to the Rails 2 way, which uses less code by having...
Shaun McDonald [Tue, 28 Oct 2008 12:27:10 +0000 (12:27 +0000)]
Moving all the functional tests to the Rails 2 way, which uses less code by having an additional sub-class to take care of the duplicate code in every test. There is a bug in rails 2.0.2, which means that super doesn't get called in the setup method in the functional tests. This is fixed in Rails 2.1.2, thus a version bump should really be done.

11 years agoPrepare for Rails 2.1+, as we will no longer be able to use a symbol in the set_fixtu...
Shaun McDonald [Mon, 27 Oct 2008 18:45:28 +0000 (18:45 +0000)]
Prepare for Rails 2.1+, as we will no longer be able to use a symbol in the set_fixture_class method, instead we must use a Class. This change doesn't affect Rails 2.0.2, as currently used. All tests still work. :-)

11 years agoImplemented osmChange diff downloads for changesets and a couple of tests.
Matt Amos [Mon, 27 Oct 2008 17:50:28 +0000 (17:50 +0000)]
Implemented osmChange diff downloads for changesets and a couple of tests.

11 years agoUpdated comment to reflect implementation.
Matt Amos [Mon, 27 Oct 2008 16:48:09 +0000 (16:48 +0000)]
Updated comment to reflect implementation.

11 years agocover the other extreme in the map bounary sanitizeation. Ading some documentation...
Shaun McDonald [Sun, 26 Oct 2008 23:43:37 +0000 (23:43 +0000)]
cover the other extreme in the map bounary sanitizeation. Ading some documentation, which is parsed when running rake doc:app. Fixing up a couple of tests.

11 years agoBots Disallow /edit* & /login*, Nothing to see here... move right along.
Grant Slater [Sun, 26 Oct 2008 17:26:39 +0000 (17:26 +0000)]
Bots Disallow /edit* & /login*, Nothing to see here... move right along.

11 years agofix broken YAML
Richard Fairhurst [Fri, 24 Oct 2008 14:35:01 +0000 (14:35 +0000)]
fix broken YAML

11 years agoAdded tests for changeset upload code. Refactored diff reading code and put it into...
Matt Amos [Thu, 23 Oct 2008 15:14:17 +0000 (15:14 +0000)]
Added tests for changeset upload code. Refactored diff reading code and put it into /lib. Changed the route of a changeset upload to explicitly refer to the changeset it applies to (i.e: resource).

11 years agoPotlatch 0.10f
Richard Fairhurst [Thu, 23 Oct 2008 08:42:07 +0000 (08:42 +0000)]
Potlatch 0.10f