rails.git
11 years agoAdd a changeset cache to stop us looking up the same changeset over
Tom Hughes [Tue, 28 Apr 2009 13:40:30 +0000 (13:40 +0000)]
Add a changeset cache to stop us looking up the same changeset over
and over again when processing a map call.

11 years agoCope with sessions which don't exist.
Tom Hughes [Tue, 28 Apr 2009 12:08:47 +0000 (12:08 +0000)]
Cope with sessions which don't exist.

11 years agoReject any AMF request which is not a POST request.
Tom Hughes [Tue, 28 Apr 2009 11:14:15 +0000 (11:14 +0000)]
Reject any AMF request which is not a POST request.

11 years agoFix session plugin work with the new ruby pg driver for postgresql.
Tom Hughes [Tue, 28 Apr 2009 10:57:25 +0000 (10:57 +0000)]
Fix session plugin work with the new ruby pg driver for postgresql.

11 years agoRemove debugging statement.
Tom Hughes [Tue, 28 Apr 2009 09:00:01 +0000 (09:00 +0000)]
Remove debugging statement.

11 years agoDon't log the contents of the changeset.
Tom Hughes [Tue, 28 Apr 2009 08:59:33 +0000 (08:59 +0000)]
Don't log the contents of the changeset.

11 years agoQuick fix to reference relation rather than relation_member when linking to the relat...
Thomas Wood [Mon, 27 Apr 2009 21:26:23 +0000 (21:26 +0000)]
Quick fix to reference relation rather than relation_member when linking to the relation, not sure when the bug was introduced. Tests still need to be written for the browse controller.
Closes #1764

11 years agoFurther clarify descriptive texts regarding public editing.
Thomas Wood [Mon, 27 Apr 2009 18:23:43 +0000 (18:23 +0000)]
Further clarify descriptive texts regarding public editing.

11 years agoFix the node and relation tests from when the users with data public=false were disal...
Shaun McDonald [Mon, 27 Apr 2009 11:57:58 +0000 (11:57 +0000)]
Fix the node and relation tests from when the users with data public=false were disallowed from editing. Needed extra fixtures.

11 years agoImprove the node/way/relation already deleted error message, and get rid bug in way...
Shaun McDonald [Mon, 27 Apr 2009 11:49:56 +0000 (11:49 +0000)]
Improve the node/way/relation already deleted error message, and get rid bug in way model with missing new in exception

11 years agoFinish removing old request counting logic.
Tom Hughes [Sun, 26 Apr 2009 23:27:40 +0000 (23:27 +0000)]
Finish removing old request counting logic.

11 years agoRemove old code to exit after 10000 requests as the memory limit code
Tom Hughes [Sun, 26 Apr 2009 23:14:20 +0000 (23:14 +0000)]
Remove old code to exit after 10000 requests as the memory limit code
should do a better job of controlling things.

11 years agoTidy up.
Tom Hughes [Sun, 26 Apr 2009 23:13:06 +0000 (23:13 +0000)]
Tidy up.

11 years agoMake node update work with the new require data public to edit policy. Added convenie...
Shaun McDonald [Sun, 26 Apr 2009 22:46:41 +0000 (22:46 +0000)]
Make node update work with the new require data public to edit policy. Added convenience testing method for the require data public. Add 2 new fixtures that are owned by the public user.

11 years agoMake the report_error function support any http status code for added flexibility.
Shaun McDonald [Sun, 26 Apr 2009 21:11:31 +0000 (21:11 +0000)]
Make the report_error function support any http status code for added flexibility.

11 years agoFix typo of missing .new for some of the errors. Tests are useful.
Shaun McDonald [Sun, 26 Apr 2009 20:56:58 +0000 (20:56 +0000)]
Fix typo of missing .new for some of the errors. Tests are useful.

11 years agomove relations mapping out of way/node objects, so we don't need horrible expensive...
Richard Fairhurst [Sun, 26 Apr 2009 18:26:48 +0000 (18:26 +0000)]
move relations mapping out of way/node objects, so we don't need horrible expensive getrelations any more

11 years agoRun GC if we hit the memory limit, and only restart if we are still too big.
Tom Hughes [Sun, 26 Apr 2009 17:01:59 +0000 (17:01 +0000)]
Run GC if we hit the memory limit, and only restart if we are still too big.

11 years agoIncrease the hard memory limit and set a lower soft limit that does a
Tom Hughes [Sun, 26 Apr 2009 16:56:40 +0000 (16:56 +0000)]
Increase the hard memory limit and set a lower soft limit that does a
clean restart between requests.

11 years agoDo a GC run every 10 requests.
Tom Hughes [Sun, 26 Apr 2009 11:28:55 +0000 (11:28 +0000)]
Do a GC run every 10 requests.

11 years agoNull descriptions are not allowed.
Tom Hughes [Sat, 25 Apr 2009 22:26:56 +0000 (22:26 +0000)]
Null descriptions are not allowed.

11 years agoFixed bug in exception creation.
Matt Amos [Sat, 25 Apr 2009 15:20:48 +0000 (15:20 +0000)]
Fixed bug in exception creation.

11 years agoibid
Richard Fairhurst [Fri, 24 Apr 2009 20:40:48 +0000 (20:40 +0000)]
ibid

11 years agoa couple of minor revert fixes
Richard Fairhurst [Fri, 24 Apr 2009 20:12:43 +0000 (20:12 +0000)]
a couple of minor revert fixes

11 years agoFixed dumb copy-and-paste mistake.
Matt Amos [Fri, 24 Apr 2009 18:47:41 +0000 (18:47 +0000)]
Fixed dumb copy-and-paste mistake.

11 years agopass common API error text through to Potlatch so it can be shown to the user
Richard Fairhurst [Fri, 24 Apr 2009 17:44:52 +0000 (17:44 +0000)]
pass common API error text through to Potlatch so it can be shown to the user

11 years agolots of relations changes for speed and version management
Richard Fairhurst [Fri, 24 Apr 2009 14:46:52 +0000 (14:46 +0000)]
lots of relations changes for speed and version management

11 years agoPatching better 412 error messages from mis-commit on old api06 branch.
Matt Amos [Fri, 24 Apr 2009 10:08:15 +0000 (10:08 +0000)]
Patching better 412 error messages from mis-commit on old api06 branch.

11 years agoBackout broken attempt at making case insensitive authentication work
Tom Hughes [Thu, 23 Apr 2009 23:46:45 +0000 (23:46 +0000)]
Backout broken attempt at making case insensitive authentication work
on Postgres. As implemented this forces a table scan to authenticate
users which is ridiculous to save people pressing the shift key.

11 years agoThe render method needs to be last, otherwise the error header won't get set. Needs...
Shaun McDonald [Thu, 23 Apr 2009 21:03:59 +0000 (21:03 +0000)]
The render method needs to be last, otherwise the error header won't get set. Needs tests.

11 years agoHack a way to make the email and display name case insensitive for logging in, based...
Shaun McDonald [Thu, 23 Apr 2009 19:20:08 +0000 (19:20 +0000)]
Hack a way to make the email and display name case insensitive for logging in, based on a suggestion by firefishy to use ILIKE. Changes requested from users on mailing list. Includes some tests to check the case insensitivity of the username, and and e-mail address on login.

11 years agoAdded better error messages on 412 precondition failed.
Matt Amos [Thu, 23 Apr 2009 18:39:36 +0000 (18:39 +0000)]
Added better error messages on 412 precondition failed.

11 years agofix another way-node/Way-Node problem in amf_controller; add WinIE JS compatibility...
Richard Fairhurst [Thu, 23 Apr 2009 17:54:17 +0000 (17:54 +0000)]
fix another way-node/Way-Node problem in amf_controller; add WinIE JS compatibility via ExternalInterface (we can use this later to alert for a commit message if none is provided)

11 years agochange updatelinks params so that Potlatch can pass in the view bbox. Also check...
Harry Wood [Thu, 23 Apr 2009 14:38:40 +0000 (14:38 +0000)]
change updatelinks params so that Potlatch can pass in the view bbox. Also check if it's missing. closes #1738

11 years agoactually delete nodes on deleteway (might help)
Richard Fairhurst [Thu, 23 Apr 2009 12:01:42 +0000 (12:01 +0000)]
actually delete nodes on deleteway (might help)

11 years agofix nodes bug
Richard Fairhurst [Thu, 23 Apr 2009 08:32:26 +0000 (08:32 +0000)]
fix nodes bug

11 years agolighttpd increase server.max-fds from 1024 (default) to 8192 after lighttpd deadlock.
Grant Slater [Thu, 23 Apr 2009 02:00:15 +0000 (02:00 +0000)]
lighttpd increase server.max-fds from 1024 (default) to 8192 after lighttpd deadlock.

11 years agofix word-wrap in "close changeset" dialogue
Richard Fairhurst [Wed, 22 Apr 2009 23:57:37 +0000 (23:57 +0000)]
fix word-wrap in "close changeset" dialogue

11 years agoremove debug stuff
Richard Fairhurst [Wed, 22 Apr 2009 19:42:22 +0000 (19:42 +0000)]
remove debug stuff

11 years agochange relation_member 'type' case, to match change in database
Richard Fairhurst [Wed, 22 Apr 2009 17:47:06 +0000 (17:47 +0000)]
change relation_member 'type' case, to match change in database

11 years agoFix multiple issues with links to /history from the homepage. Thanks to Ed Avis for...
Thomas Wood [Wed, 22 Apr 2009 17:08:04 +0000 (17:08 +0000)]
Fix multiple issues with links to /history from the homepage. Thanks to Ed Avis for bringing this to our attention.

11 years agoFixing the create relation test, which now also tests to make sure that private users...
Shaun McDonald [Wed, 22 Apr 2009 14:38:23 +0000 (14:38 +0000)]
Fixing the create relation test, which now also tests to make sure that private users cannot edit.

11 years agoUse postgres interval syntax.
Tom Hughes [Wed, 22 Apr 2009 13:41:17 +0000 (13:41 +0000)]
Use postgres interval syntax.

11 years agoThe active flag is still an integer for some reason, not a boolean.
Tom Hughes [Wed, 22 Apr 2009 13:34:12 +0000 (13:34 +0000)]
The active flag is still an integer for some reason, not a boolean.
Closes #1727.

11 years agoadding the maximum number of elements in a changeset to the capabilities call, includ...
Shaun McDonald [Wed, 22 Apr 2009 11:03:22 +0000 (11:03 +0000)]
adding the maximum number of elements in a changeset to the capabilities call, including test update

11 years agobit more debug
Richard Fairhurst [Wed, 22 Apr 2009 08:37:55 +0000 (08:37 +0000)]
bit more debug

11 years agoadd temporary relations debug code
Richard Fairhurst [Wed, 22 Apr 2009 08:25:33 +0000 (08:25 +0000)]
add temporary relations debug code

11 years agoremove Bavaria
Richard Fairhurst [Wed, 22 Apr 2009 07:41:21 +0000 (07:41 +0000)]
remove Bavaria

11 years agofixing some of the relation tests. Some adjustments to the fixtures.
Shaun McDonald [Wed, 22 Apr 2009 00:42:23 +0000 (00:42 +0000)]
fixing some of the relation tests. Some adjustments to the fixtures.

11 years agoibid
Richard Fairhurst [Tue, 21 Apr 2009 23:59:27 +0000 (23:59 +0000)]
ibid

11 years agothere is not HTML attribute named "padding". either use "cellpadding" (this patch...
Frederik Ramm [Tue, 21 Apr 2009 23:55:02 +0000 (23:55 +0000)]
there is not HTML attribute named "padding". either use "cellpadding" (this patch), or use the CSS attribute (i.e. style="padding: 0px").

11 years agoQuick and dirty fix for relation tags issue.
Matt Amos [Tue, 21 Apr 2009 23:40:27 +0000 (23:40 +0000)]
Quick and dirty fix for relation tags issue.

11 years agomodified "user" link in "recent changes" list to point directly to user's list of...
Frederik Ramm [Tue, 21 Apr 2009 23:38:43 +0000 (23:38 +0000)]
modified "user" link in "recent changes" list to point directly to user's list of changes which is what you expect in this context, rather than going to that user's user page and having to click "edits" there.

11 years agofix id/relid inconsistency
Richard Fairhurst [Tue, 21 Apr 2009 23:36:53 +0000 (23:36 +0000)]
fix id/relid inconsistency

11 years agoFixed search controller to have some chance of working.
Tom Hughes [Tue, 21 Apr 2009 23:35:19 +0000 (23:35 +0000)]
Fixed search controller to have some chance of working.

11 years agoForce selection to fail when no traces match the tag.
Tom Hughes [Tue, 21 Apr 2009 21:54:44 +0000 (21:54 +0000)]
Force selection to fail when no traces match the tag.

11 years agoDon't generate an IN condition with an empty list.
Tom Hughes [Tue, 21 Apr 2009 21:51:02 +0000 (21:51 +0000)]
Don't generate an IN condition with an empty list.

11 years agoUse correct names for member types.
Tom Hughes [Tue, 21 Apr 2009 21:37:27 +0000 (21:37 +0000)]
Use correct names for member types.

11 years agoFix bbox display again, how do we keep mixing our lons and lats?
Thomas Wood [Tue, 21 Apr 2009 21:30:37 +0000 (21:30 +0000)]
Fix bbox display again, how do we keep mixing our lons and lats?

11 years agoAdding more tests for updating relation tags.
Matt Amos [Tue, 21 Apr 2009 20:33:16 +0000 (20:33 +0000)]
Adding more tests for updating relation tags.

11 years agoExtra test for updating relation tags.
Matt Amos [Tue, 21 Apr 2009 19:53:14 +0000 (19:53 +0000)]
Extra test for updating relation tags.

11 years agoMore test fixes after fixture changes.
Matt Amos [Tue, 21 Apr 2009 19:51:43 +0000 (19:51 +0000)]
More test fixes after fixture changes.

11 years agoFixed formatting and stuff in fixtures.
Matt Amos [Tue, 21 Apr 2009 18:37:24 +0000 (18:37 +0000)]
Fixed formatting and stuff in fixtures.

11 years agoSlight performance improvement (a reported 2s) by skipping db query if no bbox is...
Thomas Wood [Tue, 21 Apr 2009 18:04:43 +0000 (18:04 +0000)]
Slight performance improvement (a reported 2s) by skipping db query if no bbox is passed in on /history
Thanks apmon for the report.

11 years agoAdd new fixtures for testing multiple tags on a relation.
Shaun McDonald [Tue, 21 Apr 2009 17:54:59 +0000 (17:54 +0000)]
Add new fixtures for testing multiple tags on a relation.

11 years agoPedantic change to descriptive text - "Recently closed" to "Recently edited"
Thomas Wood [Tue, 21 Apr 2009 17:35:54 +0000 (17:35 +0000)]
Pedantic change to descriptive text - "Recently closed" to "Recently edited"

11 years agoAdd an expiry header to trace images.
Tom Hughes [Tue, 21 Apr 2009 17:10:35 +0000 (17:10 +0000)]
Add an expiry header to trace images.

11 years agoHopefully fix the old_node_controller tests.
Shaun McDonald [Tue, 21 Apr 2009 17:07:14 +0000 (17:07 +0000)]
Hopefully fix the old_node_controller tests.

11 years agoAdd a geocoder backend.
Tom Hughes [Tue, 21 Apr 2009 15:08:36 +0000 (15:08 +0000)]
Add a geocoder backend.

11 years agoArrays have a length method, not a count method.
Tom Hughes [Tue, 21 Apr 2009 11:36:41 +0000 (11:36 +0000)]
Arrays have a length method, not a count method.

11 years agoMake error messages more helpful
Richard Fairhurst [Tue, 21 Apr 2009 11:27:03 +0000 (11:27 +0000)]
Make error messages more helpful

11 years agoSplit out subscript to see which one is erroring
Richard Fairhurst [Tue, 21 Apr 2009 10:14:28 +0000 (10:14 +0000)]
Split out subscript to see which one is erroring

11 years agoConnect up the versioned capabilities call again.
Tom Hughes [Tue, 21 Apr 2009 09:32:19 +0000 (09:32 +0000)]
Connect up the versioned capabilities call again.

11 years agoFix MySQL dependency
Richard Fairhurst [Tue, 21 Apr 2009 09:24:07 +0000 (09:24 +0000)]
Fix MySQL dependency

11 years agoAdd missing image.
Tom Hughes [Tue, 21 Apr 2009 08:51:23 +0000 (08:51 +0000)]
Add missing image.

11 years agoRemove reference to non-existent images.
Tom Hughes [Tue, 21 Apr 2009 08:08:02 +0000 (08:08 +0000)]
Remove reference to non-existent images.

11 years agoSwitch database config to postgresql.
Tom Hughes [Tue, 21 Apr 2009 07:56:52 +0000 (07:56 +0000)]
Switch database config to postgresql.

11 years agoUpdate lighttpd config for 0.6 api.
Tom Hughes [Tue, 21 Apr 2009 07:54:00 +0000 (07:54 +0000)]
Update lighttpd config for 0.6 api.

11 years agoRemove explicit load of mysql and rails automatically loads the
Tom Hughes [Tue, 21 Apr 2009 07:52:47 +0000 (07:52 +0000)]
Remove explicit load of mysql and rails automatically loads the
right database driver already.

11 years agoImprove comments.
Tom Hughes [Tue, 21 Apr 2009 07:51:26 +0000 (07:51 +0000)]
Improve comments.

11 years agonginx fix expiry to actually work on images/javascripts/etc
Grant Slater [Tue, 21 Apr 2009 02:42:29 +0000 (02:42 +0000)]
nginx fix expiry to actually work on images/javascripts/etc

11 years agoPull in block rules from the lighttpd config.
Tom Hughes [Mon, 20 Apr 2009 21:14:39 +0000 (21:14 +0000)]
Pull in block rules from the lighttpd config.

11 years agoEnsure :not_found status is returned, catching RecordNotFound doesn't work as isnt...
Thomas Wood [Mon, 20 Apr 2009 20:58:42 +0000 (20:58 +0000)]
Ensure :not_found status is returned, catching RecordNotFound doesn't work as isnt raised when finding :first.

11 years agoGive munin access to some statistics.
Tom Hughes [Mon, 20 Apr 2009 20:14:05 +0000 (20:14 +0000)]
Give munin access to some statistics.

11 years agoExpose relation version to api and fix remaining server status typo in old_relation...
Thomas Wood [Mon, 20 Apr 2009 19:44:58 +0000 (19:44 +0000)]
Expose relation version to api and fix remaining server status typo in old_relation controller.

11 years agoIncrease fastcgi timeout to 300s for bulk api requests.
Tom Hughes [Mon, 20 Apr 2009 19:30:23 +0000 (19:30 +0000)]
Increase fastcgi timeout to 300s for bulk api requests.

11 years agoRemove trailing whitespace.
Tom Hughes [Mon, 20 Apr 2009 19:25:10 +0000 (19:25 +0000)]
Remove trailing whitespace.

11 years agoStrip asset tags from user images.
Tom Hughes [Mon, 20 Apr 2009 19:22:38 +0000 (19:22 +0000)]
Strip asset tags from user images.

11 years agoFix bug introduced in r14610 (.downcase in wrong place)
Thomas Wood [Mon, 20 Apr 2009 19:13:52 +0000 (19:13 +0000)]
Fix bug introduced in r14610 (.downcase in wrong place)
No need to sanitise type of relation member, since will only be a Node, Way, or Relation and not user-provided.

11 years agoDetabify.
Tom Hughes [Mon, 20 Apr 2009 18:57:05 +0000 (18:57 +0000)]
Detabify.

11 years agonginx fixes, including http://api.openstreetmap/0.6/... support
Grant Slater [Mon, 20 Apr 2009 18:45:20 +0000 (18:45 +0000)]
nginx fixes, including api.openstreetmap/0.6/... support

11 years agoRemove location block from abuse placeholder so it applies server wide.
Tom Hughes [Mon, 20 Apr 2009 17:32:33 +0000 (17:32 +0000)]
Remove location block from abuse placeholder so it applies server wide.

11 years agofix bug in the case of the action in the data browser when linking to relation members
Shaun McDonald [Mon, 20 Apr 2009 17:28:01 +0000 (17:28 +0000)]
fix bug in the case of the action in the data browser when linking to relation members

11 years agoRestrict 7 day expiry on /export to just the embed.html page.
Tom Hughes [Mon, 20 Apr 2009 17:27:12 +0000 (17:27 +0000)]
Restrict 7 day expiry on /export to just the embed.html page.

11 years agoReturn 404 for unknown API versions instead of 403.
Tom Hughes [Mon, 20 Apr 2009 17:17:00 +0000 (17:17 +0000)]
Return 404 for unknown API versions instead of 403.

11 years agoApply patch by Lars from osm dev list with the typo
Shaun McDonald [Mon, 20 Apr 2009 17:15:28 +0000 (17:15 +0000)]
Apply patch by Lars from osm dev list with the typo

11 years agoStrip asset tags from public files.
Tom Hughes [Mon, 20 Apr 2009 17:09:26 +0000 (17:09 +0000)]
Strip asset tags from public files.

11 years agoMove access_log configuration.
Tom Hughes [Mon, 20 Apr 2009 17:00:52 +0000 (17:00 +0000)]
Move access_log configuration.

11 years agoTidy things up and fix a few errors.
Tom Hughes [Mon, 20 Apr 2009 16:59:12 +0000 (16:59 +0000)]
Tidy things up and fix a few errors.

11 years agoRemove tabs.
Tom Hughes [Mon, 20 Apr 2009 16:39:24 +0000 (16:39 +0000)]
Remove tabs.