From d075fc4c1f3e7a17b4c71e7a06fd6cf318e0ef2f Mon Sep 17 00:00:00 2001 From: Tom Hughes Date: Sat, 2 Jul 2011 01:00:51 +0100 Subject: [PATCH] Lots more work on making RTL layout work --- app/views/diary_entry/_diary_comment.html.erb | 2 +- .../diary_entry/_diary_list_entry.html.erb | 2 +- app/views/diary_entry/list.html.erb | 59 ++--- app/views/diary_entry/view.html.erb | 36 +-- app/views/layouts/_head.html.erb | 1 + app/views/message/new.html.erb | 6 +- app/views/message/read.html.erb | 12 +- app/views/site/_sidebar.html.erb | 4 +- app/views/site/copyright.html.erb | 2 +- app/views/site/index.html.erb | 13 +- app/views/trace/create.html.erb | 8 +- app/views/user/_popup.html.erb | 2 +- app/views/user/account.html.erb | 2 +- app/views/user/view.html.erb | 214 ++++++++-------- config/locales/en.yml | 8 +- public/stylesheets/common.css | 133 +++------- public/stylesheets/large.css | 1 - public/stylesheets/ltr.css | 233 +++++++++++++++++ public/stylesheets/rtl.css | 240 ++++++++++++++++++ public/stylesheets/small.css | 3 + 20 files changed, 695 insertions(+), 286 deletions(-) create mode 100644 public/stylesheets/ltr.css create mode 100644 public/stylesheets/rtl.css diff --git a/app/views/diary_entry/_diary_comment.html.erb b/app/views/diary_entry/_diary_comment.html.erb index a0e75ecce..ef5c601e8 100644 --- a/app/views/diary_entry/_diary_comment.html.erb +++ b/app/views/diary_entry/_diary_comment.html.erb @@ -1,4 +1,4 @@ -<%= user_thumbnail diary_comment.user, :style => "float: right" %> +<%= user_thumbnail diary_comment.user %>

<%= t('diary_entry.diary_comment.comment_from', :link_user => (link_to h(diary_comment.user.display_name), :controller => 'user', :action => 'view', :display_name => diary_comment.user.display_name), :comment_created_at => l(diary_comment.created_at, :format => :friendly)) %>

<%= htmlize(diary_comment.body) %> <% if_administrator(:span) do %> diff --git a/app/views/diary_entry/_diary_list_entry.html.erb b/app/views/diary_entry/_diary_list_entry.html.erb index 65ee73ff0..496443272 100644 --- a/app/views/diary_entry/_diary_list_entry.html.erb +++ b/app/views/diary_entry/_diary_list_entry.html.erb @@ -1,2 +1,2 @@ -<%= user_thumbnail diary_list_entry.user, :style => "float: right" %> +<%= user_thumbnail diary_list_entry.user %> <%= render :partial => "diary_entry", :object => diary_list_entry %> diff --git a/app/views/diary_entry/list.html.erb b/app/views/diary_entry/list.html.erb index 1be32fd21..e3dac5989 100644 --- a/app/views/diary_entry/list.html.erb +++ b/app/views/diary_entry/list.html.erb @@ -1,41 +1,42 @@ -<% if @this_user %> -<%= user_image @this_user, :style => "float: right" %> -<% end %> - -

<%= h(@title) %>

- -<% if @this_user %> - <% if_user(@this_user) do %> - <%= link_to image_tag("new.png", :border=>0) + t('diary_entry.list.new'), {:controller => 'diary_entry', :action => 'new'}, {:title => t('diary_entry.list.new_title')} %> - <% end %> -<% else %> - <% if_logged_in do %> - <%= link_to image_tag("new.png", :border=>0) + t('diary_entry.list.new'), {:controller => 'diary_entry', :action => 'new'}, {:title => t('diary_entry.list.new_title')} %> +
+ <% if @this_user %> + <%= user_image @this_user %> <% end %> -<% end %> - -<% if @entries.empty? %> -

<%= t 'diary_entry.list.no_entries' %>

-<% else %> -

<%= t 'diary_entry.list.recent_entries' %>

- -
+

<%= h(@title) %>

<% if @this_user %> - <%= render :partial => 'diary_entry', :collection => @entries %> + <% if_user(@this_user) do %> + <%= link_to image_tag("new.png", :border=>0) + t('diary_entry.list.new'), {:controller => 'diary_entry', :action => 'new'}, {:title => t('diary_entry.list.new_title')} %> + <% end %> <% else %> - <%= render :partial => 'diary_list_entry', :collection => @entries %> + <% if_logged_in do %> + <%= link_to image_tag("new.png", :border=>0) + t('diary_entry.list.new'), {:controller => 'diary_entry', :action => 'new'}, {:title => t('diary_entry.list.new_title')} %> + <% end %> <% end %> - <%= link_to t('diary_entry.list.older_entries'), { :page => @entry_pages.current.next, :language => params[:language] } if @entry_pages.current.next %> - <% if @entry_pages.current.next and @entry_pages.current.previous %>|<% end %> - <%= link_to t('diary_entry.list.newer_entries'), { :page => @entry_pages.current.previous, :language => params[:language] } if @entry_pages.current.previous %> + <% if @entries.empty? %> +

<%= t 'diary_entry.list.no_entries' %>

+ <% else %> +

<%= t 'diary_entry.list.recent_entries' %>

+ +
-
-<% end %> + <% if @this_user %> + <%= render :partial => 'diary_entry', :collection => @entries %> + <% else %> + <%= render :partial => 'diary_list_entry', :collection => @entries %> + <% end %> + + <%= link_to t('diary_entry.list.older_entries'), { :page => @entry_pages.current.next, :language => params[:language] } if @entry_pages.current.next %> + <% if @entry_pages.current.next and @entry_pages.current.previous %>|<% end %> + <%= link_to t('diary_entry.list.newer_entries'), { :page => @entry_pages.current.previous, :language => params[:language] } if @entry_pages.current.previous %> + +
+ <% end %> -<%= rss_link_to :action => 'rss', :language => params[:language] %> + <%= rss_link_to :action => 'rss', :language => params[:language] %> +
<% content_for :head do %> <%= auto_discovery_link_tag :atom, :action => 'rss', :language => params[:language] %> diff --git a/app/views/diary_entry/view.html.erb b/app/views/diary_entry/view.html.erb index 1a8096d13..451d849c2 100644 --- a/app/views/diary_entry/view.html.erb +++ b/app/views/diary_entry/view.html.erb @@ -1,26 +1,28 @@ -<%= user_image @entry.user, :style => "float: right" %> +
+ <%= user_image @entry.user %> -

<%= link_to t('diary_entry.view.user_title', :user => h(@entry.user.display_name)), :action => :list %>

+

<%= link_to t('diary_entry.view.user_title', :user => h(@entry.user.display_name)), :action => :list %>

-<%= render :partial => 'diary_entry', :object => @entry %> + <%= render :partial => 'diary_entry', :object => @entry %> - + -<%= render :partial => 'diary_comment', :collection => @entry.visible_comments %> + <%= render :partial => 'diary_comment', :collection => @entry.visible_comments %> -<% if_logged_in(:div) do %> -

<%= t 'diary_entry.view.leave_a_comment' %>

+ <% if_logged_in(:div) do %> +

<%= t 'diary_entry.view.leave_a_comment' %>

- <%= error_messages_for 'diary_comment' %> + <%= error_messages_for 'diary_comment' %> - <% form_for :diary_comment, @diary_comment, :url => { :action => 'comment' } do |f| %> - <%= f.text_area :body, :cols => 80, :rows => 5 %> -
-
- <%= submit_tag t('diary_entry.view.save_button') %> + <% form_for :diary_comment, @diary_comment, :url => { :action => 'comment' } do |f| %> + <%= f.text_area :body, :cols => 80, :rows => 5 %> +
+
+ <%= submit_tag t('diary_entry.view.save_button') %> + <% end %> <% end %> -<% end %> -<% if_not_logged_in(:div) do %> -

<%= t("diary_entry.view.login_to_leave_a_comment", :login_link => link_to(t("diary_entry.view.login"), :controller => 'user', :action => 'login', :referer => request.request_uri)) %>

-<% end %> + <% if_not_logged_in(:div) do %> +

<%= t("diary_entry.view.login_to_leave_a_comment", :login_link => link_to(t("diary_entry.view.login"), :controller => 'user', :action => 'login', :referer => request.request_uri)) %>

+ <% end %> +
diff --git a/app/views/layouts/_head.html.erb b/app/views/layouts/_head.html.erb index 6c22a9475..206905b94 100644 --- a/app/views/layouts/_head.html.erb +++ b/app/views/layouts/_head.html.erb @@ -6,6 +6,7 @@ <%= javascript_include_tag 'menu' %> <%= stylesheet_link_tag 'common' %> + <%= stylesheet_link_tag t('html.dir') %> <%= stylesheet_link_tag 'small', :media => "only screen and (max-width:641px)" %> <%= stylesheet_link_tag 'large', :media => "screen and (min-width: 642px)" %> diff --git a/app/views/message/new.html.erb b/app/views/message/new.html.erb index 151cd2759..85de1e51b 100644 --- a/app/views/message/new.html.erb +++ b/app/views/message/new.html.erb @@ -5,15 +5,15 @@ <% form_for :message, :url => { :action => "new", :display_name => @to_user.display_name } do |f| %> - + - + - +
<%= t'message.new.subject' %><%= t'message.new.subject' %> <%= f.text_field :title, :size => 60, :value => @subject %>
<%= t'message.new.body' %><%= t'message.new.body' %> <%= f.text_area :body, :cols => 80, :value => @body %>
<%= submit_tag t('message.new.send_button') %>
diff --git a/app/views/message/read.html.erb b/app/views/message/read.html.erb index 576403170..6bad015cc 100644 --- a/app/views/message/read.html.erb +++ b/app/views/message/read.html.erb @@ -4,17 +4,17 @@ - + - + - + @@ -41,17 +41,17 @@
<%= t'message.read.from' %><%= t'message.read.from' %> <%= link_to h(@message.sender.display_name), :controller => 'user', :action => 'view', :display_name => @message.sender.display_name %> <%= user_thumbnail @message.sender %>
<%= t'message.read.subject' %><%= t'message.read.subject' %> <%= h(@message.title) %>
<%= t'message.read.date' %><%= t'message.read.date' %> <%= l @message.sent_on, :format => :friendly %>
- + - + - + diff --git a/app/views/site/_sidebar.html.erb b/app/views/site/_sidebar.html.erb index 2dbcef432..f7e7229c8 100644 --- a/app/views/site/_sidebar.html.erb +++ b/app/views/site/_sidebar.html.erb @@ -1,8 +1,8 @@
<%= t'message.read.to' %><%= t'message.read.to' %> <%= link_to h(@message.recipient.display_name), :controller => 'user', :action => 'view', :display_name => @message.recipient.display_name %> <%= user_thumbnail @message.recipient %>
<%= t'message.read.subject' %><%= t'message.read.subject' %> <%= h(@message.title) %>
<%= t'message.read.date' %><%= t'message.read.date' %> <%= l @message.sent_on, :format => :friendly %>
- - + +