]> git.openstreetmap.org Git - nominatim.git/commitdiff
Use assertEqualsWithDelta for float comparisons
authorSimon Will <gorgor@gorgor.de>
Tue, 5 May 2020 21:43:09 +0000 (23:43 +0200)
committerSimon Will <gorgor@gorgor.de>
Tue, 5 May 2020 21:43:09 +0000 (23:43 +0200)
PHPUnit 7.3 introduced the functions assertEqualsWithDelta for comparing
floats with a delta. The old four-argument version of assertEquals is
deprecated in PHPUnit 8 and removed in PHPUnit 9.

This commit means that the tests will fail with PHPUnit < 7.3 because
assertEqualsWithDelta is not defined there.

test/php/Nominatim/LibTest.php

index 7e8cbcc345dc98f9e3ea022a2cb34b2c9e56f289..28cd9af04896f4f58a8b59c326534c2fbf5f73b1 100644 (file)
@@ -98,8 +98,8 @@ class LibTest extends \PHPUnit\Framework\TestCase
 
         foreach ($aQueries as $sQuery) {
             $aRes = parseLatLon($sQuery);
-            $this->assertEquals(40.446, $aRes[1], 'degrees decimal ' . $sQuery, 0.01);
-            $this->assertEquals(-79.982, $aRes[2], 'degrees decimal ' . $sQuery, 0.01);
+            $this->assertEqualsWithDelta(40.446, $aRes[1], 0.01, 'degrees decimal ' . $sQuery);
+            $this->assertEqualsWithDelta(-79.982, $aRes[2], 0.01, 'degrees decimal ' . $sQuery);
             $this->assertEquals($sQuery, $aRes[0]);
         }
     }