]> git.openstreetmap.org Git - nominatim.git/commitdiff
pylint may be available as pylint3 or pylint
authorSarah Hoffmann <lonvia@denofr.de>
Fri, 15 Jan 2021 09:52:25 +0000 (10:52 +0100)
committerSarah Hoffmann <lonvia@denofr.de>
Fri, 15 Jan 2021 09:52:25 +0000 (10:52 +0100)
CMakeLists.txt
docs/develop/Development-Environment.md

index 88565238a131d4129c0dfdabf2b7829f3d20e1d4..761531b10218ea5e7feda79c884de2841fc143bd 100644 (file)
@@ -140,6 +140,8 @@ if (BUILD_TESTS)
 
     set(TEST_BDD db osm2pgsql api)
 
+    find_program(PYLINT NAMES pylint3 pylint)
+
     foreach (test ${TEST_BDD})
         add_test(NAME bdd_${test}
                  COMMAND behave ${test}
@@ -156,9 +158,14 @@ if (BUILD_TESTS)
              COMMAND phpcs --report-width=120 --colors lib website utils
              WORKING_DIRECTORY ${PROJECT_SOURCE_DIR})
 
-    add_test(NAME pylint
-             COMMAND pylint3 nominatim
-             WORKING_DIRECTORY ${PROJECT_SOURCE_DIR})
+    if (PYLINT)
+        message(STATUS "Using '${PYLINT}' for Python linting.")
+        add_test(NAME pylint
+                 COMMAND ${PYLINT} nominatim
+                 WORKING_DIRECTORY ${PROJECT_SOURCE_DIR})
+    else()
+        message(STATUS "pylint not found. Linting tests disabled.")
+    endif()
 endif()
 
 #-----------------------------------------------------------------------------
index 36b34ccbe76ce4abf8eddf4b36ac54dd64a18a15..75324e716f58829f07e4717718df33c5dbee9771 100644 (file)
@@ -47,7 +47,7 @@ To install all necessary packages run:
 
 ```sh
 sudo apt install php-cgi phpunit php-codesniffer \
-                 python3-pip python3-setuptools python3-dev pylint3
+                 python3-pip python3-setuptools python3-dev pylint
 
 pip3 install --user behave mkdocs
 ```