]> git.openstreetmap.org Git - nominatim.git/log
nominatim.git
12 months agoprepare 4.2.3 release v4.2.3
Sarah Hoffmann [Tue, 11 Apr 2023 13:35:42 +0000 (15:35 +0200)]
prepare 4.2.3 release

12 months agofix a number of corner cases with interpolation splitting
Sarah Hoffmann [Thu, 6 Apr 2023 14:54:00 +0000 (16:54 +0200)]
fix a number of corner cases with interpolation splitting

Snapping a line to a point before splitting was meant to ensure
that the split point is really on the line. However, ST_Snap() does
not always behave well for this case. It may shorten the interpolation
line in some cases with the result that two points housenumbers
suddenly fall on the same point. It might also shorten the line down
to a single point which then makes ST_Split() crash.

Switch to a combination of ST_LineLocatePoint and ST_LineSubString
instead, which guarantees to keep the original geometry. Explicitly
handle the corner cases, where the split point falls on the beginning
or end of the line.

12 months agouse place_to_be_deleted when force deleting objects
Sarah Hoffmann [Tue, 4 Apr 2023 09:09:17 +0000 (11:09 +0200)]
use place_to_be_deleted when force deleting objects

12 months agoflex style: reinstate postcode boundaries
Sarah Hoffmann [Mon, 3 Apr 2023 07:17:50 +0000 (09:17 +0200)]
flex style: reinstate postcode boundaries

Postcode boundaries don't have a name, so need to be imported
unconditionally.

12 months agocall osm2pgsql postprocessing flush_deleted_places() when adding data
Sarah Hoffmann [Tue, 28 Mar 2023 12:48:41 +0000 (14:48 +0200)]
call osm2pgsql postprocessing flush_deleted_places() when adding data

13 months agoprepare release 4.2.2 v4.2.2
Sarah Hoffmann [Wed, 22 Mar 2023 17:16:01 +0000 (18:16 +0100)]
prepare release 4.2.2

13 months agoactions: restrict linting to newest version
Sarah Hoffmann [Wed, 22 Mar 2023 16:31:51 +0000 (17:31 +0100)]
actions: restrict linting to newest version

13 months agoadapt to new version of pylint
Sarah Hoffmann [Wed, 22 Mar 2023 15:00:09 +0000 (16:00 +0100)]
adapt to new version of pylint

13 months agoremove more tags from full style
Sarah Hoffmann [Mon, 20 Mar 2023 20:42:24 +0000 (21:42 +0100)]
remove more tags from full style

The full style should only save the necessary tags needed for
processing.

13 months agofix handling of unused extra tags
Sarah Hoffmann [Mon, 20 Mar 2023 20:20:27 +0000 (21:20 +0100)]
fix handling of unused extra tags

The tags can only be moved to extra tags after the main tags have been
handled.

13 months agofix polygon simplification in reverse results
Sarah Hoffmann [Thu, 9 Mar 2023 19:24:07 +0000 (20:24 +0100)]
fix polygon simplification in reverse results

polygon_threshold has never really worked for reverse.

13 months agorestrict place rank inheritance to address items
Sarah Hoffmann [Fri, 17 Feb 2023 15:25:26 +0000 (16:25 +0100)]
restrict place rank inheritance to address items

Place tags must have no influence on street- or POI-level
objects.

13 months agoactions: use token to avoid rate limiting
Sarah Hoffmann [Sun, 12 Feb 2023 08:34:22 +0000 (09:34 +0100)]
actions: use token to avoid rate limiting

13 months agoMain tag information added to geocodejson in reverse geocoding
danil [Tue, 7 Feb 2023 20:19:49 +0000 (00:19 +0400)]
Main tag information added to geocodejson in reverse geocoding

13 months agoactions: force PHPUnit 9
Sarah Hoffmann [Sat, 4 Feb 2023 13:23:19 +0000 (14:23 +0100)]
actions: force PHPUnit 9

PHPUnit 10 is incompatible with our tests. Not worth adapting anymore.

13 months agodocs: fix internal links
Sarah Hoffmann [Sat, 4 Feb 2023 20:21:23 +0000 (21:21 +0100)]
docs: fix internal links

Fixes #2968.

13 months agofix importance recalculation
Sarah Hoffmann [Sun, 22 Jan 2023 20:30:43 +0000 (21:30 +0100)]
fix importance recalculation

The signature of the compute_importance() function has changed.

13 months agoremove comma as name separator
Sarah Hoffmann [Sun, 22 Jan 2023 20:10:12 +0000 (21:10 +0100)]
remove comma as name separator

Commas are most of the time used as a part of a name, not to
separate multiple names.

See also #2950.

13 months agoexclude names ending in :wikipedia from indexing
Sarah Hoffmann [Sat, 21 Jan 2023 10:16:08 +0000 (11:16 +0100)]
exclude names ending in :wikipedia from indexing

The wikipedia prefix is used for referencing a wikipedia article
for the given tag, not the object, so not useful to search.

13 months agofix typo in argument to details CLI command
Sarah Hoffmann [Sat, 21 Jan 2023 09:44:10 +0000 (10:44 +0100)]
fix typo in argument to details CLI command

Fixes #2951.

13 months agoupdate Makefile in test directory
Sarah Hoffmann [Mon, 9 Jan 2023 19:49:33 +0000 (20:49 +0100)]
update Makefile in test directory

13 months agodo not run osm2pgsql append with mutliple threads
Sarah Hoffmann [Thu, 5 Jan 2023 10:34:56 +0000 (11:34 +0100)]
do not run osm2pgsql append with mutliple threads

As the updates modify the placex table, there may be deadlocks
when different objects want to forward modifications to the same
place (for example because they are both linked to it).

13 months agosplit query that deletes old objects from placex
Sarah Hoffmann [Mon, 2 Jan 2023 16:25:38 +0000 (17:25 +0100)]
split query that deletes old objects from placex

placex only has partial indexes over OSM types, so the OSM type
needs to be hardcoded to ensure these indexes are used.

13 months agominor adaptions for flex style
Sarah Hoffmann [Wed, 22 Mar 2023 09:50:08 +0000 (10:50 +0100)]
minor adaptions for flex style

13 months agoVAGRANT.md - replace local.php settings with .env
marc tobias [Thu, 22 Dec 2022 02:12:30 +0000 (03:12 +0100)]
VAGRANT.md - replace local.php settings with .env

13 months agouse canonical url for nominatim.org
Sarah Hoffmann [Tue, 20 Dec 2022 15:55:47 +0000 (16:55 +0100)]
use canonical url for nominatim.org

13 months agoinstall new lua import scripts
Sarah Hoffmann [Wed, 22 Mar 2023 09:45:11 +0000 (10:45 +0100)]
install new lua import scripts

13 months agoflez: add other default styles
Sarah Hoffmann [Fri, 16 Dec 2022 10:19:37 +0000 (11:19 +0100)]
flez: add other default styles

13 months agoflex: hide compiled matchers
Sarah Hoffmann [Thu, 15 Dec 2022 21:39:36 +0000 (22:39 +0100)]
flex: hide compiled matchers

13 months agoflex: switch to functions for substyles
Sarah Hoffmann [Thu, 15 Dec 2022 21:10:19 +0000 (22:10 +0100)]
flex: switch to functions for substyles

This gives us a bit more flexibility about the implementation
in the future.

13 months agoexplicit export for functions in flex-base
Sarah Hoffmann [Thu, 15 Dec 2022 16:48:00 +0000 (17:48 +0100)]
explicit export for functions in flex-base

13 months agoflex: add combining clean function
Sarah Hoffmann [Thu, 15 Dec 2022 15:47:54 +0000 (16:47 +0100)]
flex: add combining clean function

13 months agoflex: simplify name handling
Sarah Hoffmann [Thu, 15 Dec 2022 14:48:04 +0000 (15:48 +0100)]
flex: simplify name handling

13 months agoflex: simplify address configuration
Sarah Hoffmann [Thu, 15 Dec 2022 12:46:34 +0000 (13:46 +0100)]
flex: simplify address configuration

13 months agoupdate osm2pgsql (flex not building index)
Sarah Hoffmann [Thu, 15 Dec 2022 11:13:12 +0000 (12:13 +0100)]
update osm2pgsql (flex not building index)

13 months agouse grapheme_stripos instead of stripos in PHP code
Sarah Hoffmann [Sun, 11 Dec 2022 12:55:27 +0000 (13:55 +0100)]
use grapheme_stripos instead of stripos in PHP code

The stripos() does not handle non-ASCII correctly.

13 months agodo not assign postcodes to long linear features
Sarah Hoffmann [Sat, 10 Dec 2022 13:53:08 +0000 (14:53 +0100)]
do not assign postcodes to long linear features

This avoids a postcode in particular for waterway features and
long natural featues like ridges and valleys.

Fixes #2915.

13 months agoFix typo in NOMINATIM_LOG_FILE (#2919)
Frederik Ramm [Thu, 8 Dec 2022 16:34:54 +0000 (17:34 +0100)]
Fix typo in NOMINATIM_LOG_FILE (#2919)

* fix typo in docs (NOMINATIM_LOG_FILE uses s not ms)

13 months agoadd FAQ about finding bad postcodes
Sarah Hoffmann [Wed, 7 Dec 2022 19:21:30 +0000 (20:21 +0100)]
add FAQ about finding bad postcodes

13 months agocontract duplicate spaces in transliteration string
Sarah Hoffmann [Fri, 2 Dec 2022 09:15:02 +0000 (10:15 +0100)]
contract duplicate spaces in transliteration string

There are some pathological cases where an isolated letter may
be deleted because it is in itself meaningless. If this happens in
the middle of a sentence, then the transliteration contains two
consecutive spaces. Add a final rule to fix this.

See #2909.

14 months agoprepare release 4.2.1 v4.2.1
Sarah Hoffmann [Mon, 20 Feb 2023 16:58:19 +0000 (17:58 +0100)]
prepare release 4.2.1

14 months agoharmonize flags for PHP's htmlspecialchars
Sarah Hoffmann [Mon, 20 Feb 2023 15:46:53 +0000 (16:46 +0100)]
harmonize flags for PHP's htmlspecialchars

14 months agoadapt PHP tests for debug output
Sarah Hoffmann [Mon, 20 Feb 2023 15:23:28 +0000 (16:23 +0100)]
adapt PHP tests for debug output

14 months agoproperly encode special HTML characters in debug mode
Sarah Hoffmann [Mon, 20 Feb 2023 14:41:04 +0000 (15:41 +0100)]
properly encode special HTML characters in debug mode

17 months agoactions: install keys for postgres repo v4.2.0
Sarah Hoffmann [Thu, 24 Nov 2022 10:36:56 +0000 (11:36 +0100)]
actions: install keys for postgres repo

17 months agoprepare release 4.2.0
Sarah Hoffmann [Thu, 24 Nov 2022 09:43:29 +0000 (10:43 +0100)]
prepare release 4.2.0

17 months agoadd checklist for releases
Sarah Hoffmann [Thu, 24 Nov 2022 09:17:30 +0000 (10:17 +0100)]
add checklist for releases

17 months agoMerge pull request #2903 from lonvia/migration-for-index-reorganization
Sarah Hoffmann [Thu, 24 Nov 2022 09:13:38 +0000 (10:13 +0100)]
Merge pull request #2903 from lonvia/migration-for-index-reorganization

Add migration for reorganization of pending indexes

17 months agoadd migration for reorganization of pending indexes
Sarah Hoffmann [Wed, 23 Nov 2022 09:55:39 +0000 (10:55 +0100)]
add migration for reorganization of pending indexes

Fixes #2900.

17 months agoMerge pull request #2902 from lonvia/tiger-county-sanitizer
Sarah Hoffmann [Wed, 23 Nov 2022 16:58:42 +0000 (17:58 +0100)]
Merge pull request #2902 from lonvia/tiger-county-sanitizer

Tiger county sanitizer

17 months agoremove BDD test for tiger:county
Sarah Hoffmann [Tue, 22 Nov 2022 16:17:38 +0000 (17:17 +0100)]
remove BDD test for tiger:county

We no longer rely on the import to strip the tag.

17 months agoadd sanitizer for TIGER tags
Sarah Hoffmann [Tue, 22 Nov 2022 16:10:21 +0000 (17:10 +0100)]
add sanitizer for TIGER tags

Currently only takes over cleaning the tiger:county data. This was
done by the import until now.

17 months agoMerge pull request #2892 from lonvia/optional-forward-dependecies
Sarah Hoffmann [Mon, 21 Nov 2022 15:57:45 +0000 (16:57 +0100)]
Merge pull request #2892 from lonvia/optional-forward-dependecies

Add experimental configuration switch for enabling forward dependencies

17 months agoadd experimental option for enabling forward dependencies
Sarah Hoffmann [Fri, 4 Nov 2022 16:48:05 +0000 (17:48 +0100)]
add experimental option for enabling forward dependencies

17 months agoMerge pull request #2890 from lonvia/use-rank-search-for-reverse-polygon-match
Sarah Hoffmann [Sun, 20 Nov 2022 21:11:35 +0000 (22:11 +0100)]
Merge pull request #2890 from lonvia/use-rank-search-for-reverse-polygon-match

Use rank search for reverse polygon match

17 months agoforce use of geometry index for reverse polygon lookup
Sarah Hoffmann [Sun, 20 Nov 2022 19:22:44 +0000 (20:22 +0100)]
force use of geometry index for reverse polygon lookup

17 months agouse rank_search for reverse polygon match
Sarah Hoffmann [Sun, 20 Nov 2022 18:28:56 +0000 (19:28 +0100)]
use rank_search for reverse polygon match

17 months agofix condition under which place_to_be_deleted is created
Sarah Hoffmann [Sat, 19 Nov 2022 20:53:14 +0000 (21:53 +0100)]
fix condition under which place_to_be_deleted is created

It is needed for updates, independently if reverse-only is set.

17 months agoMerge pull request #2889 from lonvia/fix-interpolation-updates
Sarah Hoffmann [Fri, 18 Nov 2022 17:51:11 +0000 (18:51 +0100)]
Merge pull request #2889 from lonvia/fix-interpolation-updates

Drop illegal values for addr:interpolation on update

17 months agodrop illegal values for addr:interpolation on update
Sarah Hoffmann [Fri, 18 Nov 2022 16:26:56 +0000 (17:26 +0100)]
drop illegal values for addr:interpolation on update

17 months agoMerge pull request #2887 from lonvia/lookup-linked-places
Sarah Hoffmann [Thu, 17 Nov 2022 12:35:53 +0000 (13:35 +0100)]
Merge pull request #2887 from lonvia/lookup-linked-places

Add support for lookup of linked places

17 months agoMerge pull request #2886 from lonvia/closest-street-in-associated
Sarah Hoffmann [Thu, 17 Nov 2022 06:29:25 +0000 (07:29 +0100)]
Merge pull request #2886 from lonvia/closest-street-in-associated

Handle associatedStreet relations with multiple streets correctly

17 months agoadd support for lookup of linked places
Sarah Hoffmann [Wed, 16 Nov 2022 20:11:56 +0000 (21:11 +0100)]
add support for lookup of linked places

17 months agohandle associatedStreet relations with multiple streets
Sarah Hoffmann [Wed, 16 Nov 2022 16:25:51 +0000 (17:25 +0100)]
handle associatedStreet relations with multiple streets

When a associatedStreet relation has multiple street members
always take the closest one. Avoid geometry operations for
the frequent case that there is only one street.

17 months agoMerge pull request #2884 from lonvia/tweak-special-term-penalties
Sarah Hoffmann [Tue, 15 Nov 2022 18:29:55 +0000 (19:29 +0100)]
Merge pull request #2884 from lonvia/tweak-special-term-penalties

Correctly handle special term + name combination

17 months agoMerge pull request #2885 from lonvia/remove-unused-countries
Sarah Hoffmann [Tue, 15 Nov 2022 18:29:39 +0000 (19:29 +0100)]
Merge pull request #2885 from lonvia/remove-unused-countries

Remove dependent territories from country list

17 months agocorrectly handle special term + name combination
Sarah Hoffmann [Tue, 15 Nov 2022 10:55:40 +0000 (11:55 +0100)]
correctly handle special term + name combination

Special terms with operator name usually appear in combination with the
name. The current penalties only took name + special term into account
not special term + name.

Fixes #2876.

17 months agoremove dependent territories from country list
Sarah Hoffmann [Tue, 15 Nov 2022 10:37:30 +0000 (11:37 +0100)]
remove dependent territories from country list

Removes territories of US, France, Australia and Netherlands from the
country list. These territories have their own country code (which is
why they are in the list in the first place) but are mapped as part of
the admin_level 2 relations for the respective parent countries.
Therefore they never had any places attached. In practical terms, the
change only affects the number of tables created.

17 months agoMerge pull request #2881 from lonvia/more-update-tests-for-osm2pgsql
Sarah Hoffmann [Tue, 15 Nov 2022 08:39:46 +0000 (09:39 +0100)]
Merge pull request #2881 from lonvia/more-update-tests-for-osm2pgsql

Experimental support for osm2pgsql flex output

17 months agobdd: add tests for osm2pgsql update of postcode nodes
Sarah Hoffmann [Mon, 14 Nov 2022 16:27:04 +0000 (17:27 +0100)]
bdd: add tests for osm2pgsql update of postcode nodes

17 months agobdd: add osm2pgsql tests for updating interpolations
Sarah Hoffmann [Mon, 14 Nov 2022 15:57:31 +0000 (16:57 +0100)]
bdd: add osm2pgsql tests for updating interpolations

17 months agobdd: test placex content when updating with osm2pgsql
Sarah Hoffmann [Mon, 14 Nov 2022 13:48:44 +0000 (14:48 +0100)]
bdd: test placex content when updating with osm2pgsql

17 months agoreorganize handling of place type changes
Sarah Hoffmann [Mon, 14 Nov 2022 12:57:26 +0000 (13:57 +0100)]
reorganize handling of place type changes

Always replace existing entries in place, never delete them because
a direct delete will cause conflicts.

17 months agofix country handling in flex style
Sarah Hoffmann [Thu, 10 Nov 2022 14:52:13 +0000 (15:52 +0100)]
fix country handling in flex style

If the country tag does not match a 2-letter code, it needs to
be dropped.

17 months agoremove tests that differ between lua and gazetteer versions
Sarah Hoffmann [Thu, 10 Nov 2022 14:51:55 +0000 (15:51 +0100)]
remove tests that differ between lua and gazetteer versions

17 months agonode locations must be stable for osm2pgsql update tests
Sarah Hoffmann [Thu, 10 Nov 2022 10:11:45 +0000 (11:11 +0100)]
node locations must be stable for osm2pgsql update tests

17 months agobdd: extend osm2pgsql update tests
Sarah Hoffmann [Tue, 8 Nov 2022 13:06:18 +0000 (14:06 +0100)]
bdd: extend osm2pgsql update tests

Now also checks for correct indexing state of placex table.

17 months agooptimise tag match function
Sarah Hoffmann [Tue, 8 Nov 2022 09:21:44 +0000 (10:21 +0100)]
optimise tag match function

17 months agoadd lua requirements for vagrant scripts
Sarah Hoffmann [Fri, 4 Nov 2022 21:43:10 +0000 (22:43 +0100)]
add lua requirements for vagrant scripts

17 months agoCI: require lua libraries
Sarah Hoffmann [Fri, 4 Nov 2022 15:03:04 +0000 (16:03 +0100)]
CI: require lua libraries

17 months agoadd migration for place_to_be_deleted table
Sarah Hoffmann [Fri, 4 Nov 2022 14:20:43 +0000 (15:20 +0100)]
add migration for place_to_be_deleted table

17 months agochange updates to handle delete/insert workflow
Sarah Hoffmann [Fri, 4 Nov 2022 13:50:07 +0000 (14:50 +0100)]
change updates to handle delete/insert workflow

This makes Nominatim compatible with osm2pgsql's default update
modus operandi of deleting and reinserting data. Deletes are diverted
into a TODO table instead of executing them. When data is reinserted,
the corresponding entry in the TODO table is deleted. After updates are
finished, the remaining entries in the TODO table are executed, doing
the same work as the delete trigger did before.

The new behaviour also works against the gazetteer output with its
insert-only mechanism.

17 months agoinitial flex import scripts
Sarah Hoffmann [Thu, 3 Nov 2022 16:15:01 +0000 (17:15 +0100)]
initial flex import scripts

Only implements the extratags style for the moment. Tests pass
for the same behaviour as the gazetteer output. Updates still need
to be done.

17 months agobdd tests: make import style configurable
Sarah Hoffmann [Tue, 4 Oct 2022 15:01:25 +0000 (17:01 +0200)]
bdd tests: make import style configurable

The switch is for development. Tests are not guaranteed to still
work when run with anything but the 'extratags' style.

17 months agoadd osm2pgsql gazetteer tests
Sarah Hoffmann [Tue, 4 Oct 2022 13:02:19 +0000 (15:02 +0200)]
add osm2pgsql gazetteer tests

This ports the gazetteer tests from osm2pgsql to BDD tests.

17 months agoMerge pull request #2869 from mtmail/improve-tiger-install-doc
Sarah Hoffmann [Wed, 9 Nov 2022 19:48:39 +0000 (20:48 +0100)]
Merge pull request #2869 from mtmail/improve-tiger-install-doc

Tiger install doc: add -refresh website- step

17 months agofix type issues with calls to pyosmium
Sarah Hoffmann [Wed, 9 Nov 2022 19:45:56 +0000 (20:45 +0100)]
fix type issues with calls to pyosmium

17 months agoTiger install doc: add -refresh website- step
Marc Tobias [Tue, 8 Nov 2022 13:40:43 +0000 (14:40 +0100)]
Tiger install doc: add -refresh website- step

17 months agoMerge pull request #2871 from lonvia/fix-timeout-for-updates
Sarah Hoffmann [Wed, 9 Nov 2022 13:26:39 +0000 (14:26 +0100)]
Merge pull request #2871 from lonvia/fix-timeout-for-updates

Fix timeout for updates

17 months agoadd types-requests dependency
Sarah Hoffmann [Tue, 8 Nov 2022 22:43:30 +0000 (23:43 +0100)]
add types-requests dependency

17 months agorespect socket timeout also in other replication functions
Sarah Hoffmann [Tue, 8 Nov 2022 21:24:19 +0000 (22:24 +0100)]
respect socket timeout also in other replication functions

17 months agofix timeout use for replication timeout
Sarah Hoffmann [Tue, 8 Nov 2022 20:45:36 +0000 (21:45 +0100)]
fix timeout use for replication timeout

The timeout parameter is no longer taken into account since
pyosmium switched to the requests library. This adds the parameter
back.

17 months agoMerge pull request #2870 from mtmail/update-github-actions-to-node-16
Sarah Hoffmann [Tue, 8 Nov 2022 16:24:53 +0000 (17:24 +0100)]
Merge pull request #2870 from mtmail/update-github-actions-to-node-16

update those github action packages still using node12

17 months agoupdate those github action packages still using node12
Marc Tobias [Tue, 8 Nov 2022 14:16:55 +0000 (15:16 +0100)]
update those github action packages still using node12

17 months agoMerge pull request #2866 from lonvia/reverse-ignore-interpolations-without-parent
Sarah Hoffmann [Mon, 7 Nov 2022 08:00:59 +0000 (09:00 +0100)]
Merge pull request #2866 from lonvia/reverse-ignore-interpolations-without-parent

Ignore interpolations without parent on reverse search

17 months agoignore interpolations without parent on reverse search
Sarah Hoffmann [Sat, 5 Nov 2022 13:33:28 +0000 (14:33 +0100)]
ignore interpolations without parent on reverse search

If no parent can be found for an interpolation, there is most
likely a data error involved. So don' t show these interpolations
in reverse search results.

17 months agoMerge pull request #2865 from Romeo-PHILLIPS/fix/documentation_status_code
Sarah Hoffmann [Sat, 5 Nov 2022 21:14:44 +0000 (22:14 +0100)]
Merge pull request #2865 from Romeo-PHILLIPS/fix/documentation_status_code

Fix: documentation status code

17 months agofix: format
Romeo [Fri, 4 Nov 2022 17:05:40 +0000 (18:05 +0100)]
fix: format

17 months agofix: markup
Romeo [Fri, 4 Nov 2022 17:04:28 +0000 (18:04 +0100)]
fix: markup

17 months agofix: 705 Status Code Documentation
Romeo [Fri, 4 Nov 2022 17:03:49 +0000 (18:03 +0100)]
fix: 705 Status Code Documentation