1 require File.dirname(__FILE__) + '/../test_helper'
2 require 'changeset_controller'
4 class ChangesetControllerTest < ActionController::TestCase
7 def basic_authorization(user, pass)
8 @request.env["HTTP_AUTHORIZATION"] = "Basic %s" % Base64.encode64("#{user}:#{pass}")
12 @request.env["RAW_POST_DATA"] = c.to_s
15 # -----------------------
16 # Test simple changeset creation
17 # -----------------------
20 basic_authorization "test@openstreetmap.org", "test"
22 # Create the first user's changeset
23 content "<osm><changeset>" +
24 "<tag k='created_by' v='osm test suite checking changesets'/>" +
28 assert_response :success, "Creation of changeset did not return sucess status"
29 newid = @response.body.to_i
31 # check end time, should be an hour ahead of creation time
32 cs = Changeset.find(newid)
33 duration = cs.closed_at - cs.created_at
34 # the difference can either be a rational, or a floating point number
35 # of seconds, depending on the code path taken :-(
36 if duration.class == Rational
37 assert_equal Rational(1,24), duration , "initial idle timeout should be an hour (#{cs.created_at} -> #{cs.closed_at})"
39 # must be number of seconds...
40 assert_equal 3600.0, duration , "initial idle timeout should be an hour (#{cs.created_at} -> #{cs.closed_at})"
44 def test_create_invalid
45 basic_authorization "test@openstreetmap.org", "test"
46 content "<osm><changeset></osm>"
48 assert_response :bad_request, "creating a invalid changeset should fail"
52 # check that the changeset can be read and returns the correct
55 changeset_id = changesets(:normal_user_first_change).id
56 get :read, :id => changeset_id
57 assert_response :success, "cannot get first changeset"
59 assert_select "osm[version=#{API_VERSION}][generator=\"OpenStreetMap server\"]", 1
60 assert_select "osm>changeset[id=#{changeset_id}]", 1
64 # test that the user who opened a change can close it
66 basic_authorization "test@openstreetmap.org", "test"
68 cs_id = changesets(:normal_user_first_change).id
69 put :close, :id => cs_id
70 assert_response :success
72 # test that it really is closed now
73 cs = Changeset.find(cs_id)
75 "changeset should be closed now (#{cs.closed_at} > #{Time.now}.")
79 # test that a different user can't close another user's changeset
80 def test_close_invalid
81 basic_authorization "test@example.com", "test"
83 put :close, :id => changesets(:normal_user_first_change).id
84 assert_response :conflict
85 assert_equal "The user doesn't own that changeset", @response.body
89 # upload something simple, but valid and check that it can
91 def test_upload_simple_valid
92 basic_authorization "test@openstreetmap.org", "test"
94 # simple diff to change a node, way and relation by removing
99 <node id='1' lon='0' lat='0' changeset='1' version='1'/>
100 <way id='1' changeset='1' version='1'>
105 <relation id='1' changeset='1' version='1'>
106 <member type='way' role='some' ref='3'/>
107 <member type='node' role='some' ref='5'/>
108 <member type='relation' role='some' ref='3'/>
116 post :upload, :id => 1
117 assert_response :success,
118 "can't upload a simple valid diff to changeset: #{@response.body}"
120 # check that the changes made it into the database
121 assert_equal 0, Node.find(1).tags.size, "node 1 should now have no tags"
122 assert_equal 0, Way.find(1).tags.size, "way 1 should now have no tags"
123 assert_equal 0, Relation.find(1).tags.size, "relation 1 should now have no tags"
127 # upload something which creates new objects using placeholders
128 def test_upload_create_valid
129 basic_authorization "test@openstreetmap.org", "test"
131 # simple diff to create a node way and relation using placeholders
135 <node id='-1' lon='0' lat='0' changeset='1'>
136 <tag k='foo' v='bar'/>
137 <tag k='baz' v='bat'/>
139 <way id='-1' changeset='1'>
144 <relation id='-1' changeset='1'>
145 <member type='way' role='some' ref='3'/>
146 <member type='node' role='some' ref='5'/>
147 <member type='relation' role='some' ref='3'/>
155 post :upload, :id => 1
156 assert_response :success,
157 "can't upload a simple valid creation to changeset: #{@response.body}"
159 # check the returned payload
160 assert_select "diffResult[version=#{API_VERSION}][generator=\"OpenStreetMap server\"]", 1
161 assert_select "diffResult>node", 1
162 assert_select "diffresult>way", 1
163 assert_select "diffResult>relation", 1
165 # inspect the response to find out what the new element IDs are
166 doc = XML::Parser.string(@response.body).parse
167 new_node_id = doc.find("//diffResult/node").first["new_id"].to_i
168 new_way_id = doc.find("//diffResult/way").first["new_id"].to_i
169 new_rel_id = doc.find("//diffResult/relation").first["new_id"].to_i
171 # check the old IDs are all present and negative one
172 assert_equal -1, doc.find("//diffResult/node").first["old_id"].to_i
173 assert_equal -1, doc.find("//diffResult/way").first["old_id"].to_i
174 assert_equal -1, doc.find("//diffResult/relation").first["old_id"].to_i
176 # check the versions are present and equal one
177 assert_equal 1, doc.find("//diffResult/node").first["new_version"].to_i
178 assert_equal 1, doc.find("//diffResult/way").first["new_version"].to_i
179 assert_equal 1, doc.find("//diffResult/relation").first["new_version"].to_i
181 # check that the changes made it into the database
182 assert_equal 2, Node.find(new_node_id).tags.size, "new node should have two tags"
183 assert_equal 0, Way.find(new_way_id).tags.size, "new way should have no tags"
184 assert_equal 0, Relation.find(new_rel_id).tags.size, "new relation should have no tags"
188 # test a complex delete where we delete elements which rely on eachother
189 # in the same transaction.
190 def test_upload_delete
191 basic_authorization "test@openstreetmap.org", "test"
193 diff = XML::Document.new
194 diff.root = XML::Node.new "osmChange"
195 delete = XML::Node.new "delete"
197 delete << current_relations(:visible_relation).to_xml_node
198 delete << current_relations(:used_relation).to_xml_node
199 delete << current_ways(:used_way).to_xml_node
200 delete << current_nodes(:node_used_by_relationship).to_xml_node
204 post :upload, :id => 1
205 assert_response :success,
206 "can't upload a deletion diff to changeset: #{@response.body}"
208 # check the response is well-formed
209 assert_select "diffResult>node", 1
210 assert_select "diffResult>way", 1
211 assert_select "diffResult>relation", 2
213 # check that everything was deleted
214 assert_equal false, Node.find(current_nodes(:node_used_by_relationship).id).visible
215 assert_equal false, Way.find(current_ways(:used_way).id).visible
216 assert_equal false, Relation.find(current_relations(:visible_relation).id).visible
217 assert_equal false, Relation.find(current_relations(:used_relation).id).visible
221 # test uploading a delete with no lat/lon, as they are optional in
222 # the osmChange spec.
223 def test_upload_nolatlon_delete
224 basic_authorization "test@openstreetmap.org", "test"
226 node = current_nodes(:visible_node)
227 cs = changesets(:normal_user_first_change)
228 diff = "<osmChange><delete><node id='#{node.id}' version='#{node.version}' changeset='#{cs.id}'/></delete></osmChange>"
232 post :upload, :id => cs.id
233 assert_response :success,
234 "can't upload a deletion diff to changeset: #{@response.body}"
236 # check the response is well-formed
237 assert_select "diffResult>node", 1
239 # check that everything was deleted
240 assert_equal false, Node.find(node.id).visible
244 # test that deleting stuff in a transaction doesn't bypass the checks
245 # to ensure that used elements are not deleted.
246 def test_upload_delete_invalid
247 basic_authorization "test@openstreetmap.org", "test"
249 diff = XML::Document.new
250 diff.root = XML::Node.new "osmChange"
251 delete = XML::Node.new "delete"
253 delete << current_relations(:visible_relation).to_xml_node
254 delete << current_ways(:used_way).to_xml_node
255 delete << current_nodes(:node_used_by_relationship).to_xml_node
259 post :upload, :id => 1
260 assert_response :precondition_failed,
261 "shouldn't be able to upload a invalid deletion diff: #{@response.body}"
263 # check that nothing was, in fact, deleted
264 assert_equal true, Node.find(current_nodes(:node_used_by_relationship).id).visible
265 assert_equal true, Way.find(current_ways(:used_way).id).visible
266 assert_equal true, Relation.find(current_relations(:visible_relation).id).visible
270 # upload something which creates new objects and inserts them into
271 # existing containers using placeholders.
272 def test_upload_complex
273 basic_authorization "test@openstreetmap.org", "test"
275 # simple diff to create a node way and relation using placeholders
279 <node id='-1' lon='0' lat='0' changeset='1'>
280 <tag k='foo' v='bar'/>
281 <tag k='baz' v='bat'/>
285 <way id='1' changeset='1' version='1'>
289 <relation id='1' changeset='1' version='1'>
290 <member type='way' role='some' ref='3'/>
291 <member type='node' role='some' ref='-1'/>
292 <member type='relation' role='some' ref='3'/>
300 post :upload, :id => 1
301 assert_response :success,
302 "can't upload a complex diff to changeset: #{@response.body}"
304 # check the returned payload
305 assert_select "diffResult[version=#{API_VERSION}][generator=\"#{GENERATOR}\"]", 1
306 assert_select "diffResult>node", 1
307 assert_select "diffResult>way", 1
308 assert_select "diffResult>relation", 1
310 # inspect the response to find out what the new element IDs are
311 doc = XML::Parser.string(@response.body).parse
312 new_node_id = doc.find("//diffResult/node").first["new_id"].to_i
314 # check that the changes made it into the database
315 assert_equal 2, Node.find(new_node_id).tags.size, "new node should have two tags"
316 assert_equal [new_node_id, 3], Way.find(1).nds, "way nodes should match"
317 Relation.find(1).members.each do |type,id,role|
319 assert_equal new_node_id, id, "relation should contain new node"
325 # create a diff which references several changesets, which should cause
326 # a rollback and none of the diff gets committed
327 def test_upload_invalid_changesets
328 basic_authorization "test@openstreetmap.org", "test"
330 # simple diff to create a node way and relation using placeholders
334 <node id='1' lon='0' lat='0' changeset='1' version='1'/>
335 <way id='1' changeset='1' version='1'>
340 <relation id='1' changeset='1' version='1'>
341 <member type='way' role='some' ref='3'/>
342 <member type='node' role='some' ref='5'/>
343 <member type='relation' role='some' ref='3'/>
347 <node id='-1' lon='0' lat='0' changeset='4'>
348 <tag k='foo' v='bar'/>
349 <tag k='baz' v='bat'/>
354 # cache the objects before uploading them
355 node = current_nodes(:visible_node)
356 way = current_ways(:visible_way)
357 rel = current_relations(:visible_relation)
361 post :upload, :id => 1
362 assert_response :conflict,
363 "uploading a diff with multiple changsets should have failed"
365 # check that objects are unmodified
366 assert_nodes_are_equal(node, Node.find(1))
367 assert_ways_are_equal(way, Way.find(1))
371 # upload multiple versions of the same element in the same diff.
372 def test_upload_multiple_valid
373 basic_authorization "test@openstreetmap.org", "test"
375 # change the location of a node multiple times, each time referencing
376 # the last version. doesn't this depend on version numbers being
381 <node id='1' lon='0' lat='0' changeset='1' version='1'/>
382 <node id='1' lon='1' lat='0' changeset='1' version='2'/>
383 <node id='1' lon='1' lat='1' changeset='1' version='3'/>
384 <node id='1' lon='1' lat='2' changeset='1' version='4'/>
385 <node id='1' lon='2' lat='2' changeset='1' version='5'/>
386 <node id='1' lon='3' lat='2' changeset='1' version='6'/>
387 <node id='1' lon='3' lat='3' changeset='1' version='7'/>
388 <node id='1' lon='9' lat='9' changeset='1' version='8'/>
395 post :upload, :id => 1
396 assert_response :success,
397 "can't upload multiple versions of an element in a diff: #{@response.body}"
399 # check the response is well-formed. its counter-intuitive, but the
400 # API will return multiple elements with the same ID and different
401 # version numbers for each change we made.
402 assert_select "diffResult>node", 8
406 # upload multiple versions of the same element in the same diff, but
407 # keep the version numbers the same.
408 def test_upload_multiple_duplicate
409 basic_authorization "test@openstreetmap.org", "test"
414 <node id='1' lon='0' lat='0' changeset='1' version='1'/>
415 <node id='1' lon='1' lat='1' changeset='1' version='1'/>
422 post :upload, :id => 1
423 assert_response :conflict,
424 "shouldn't be able to upload the same element twice in a diff: #{@response.body}"
428 # try to upload some elements without specifying the version
429 def test_upload_missing_version
430 basic_authorization "test@openstreetmap.org", "test"
435 <node id='1' lon='1' lat='1' changeset='1'/>
442 post :upload, :id => 1
443 assert_response :bad_request,
444 "shouldn't be able to upload an element without version: #{@response.body}"
448 # try to upload with commands other than create, modify, or delete
449 def test_action_upload_invalid
450 basic_authorization "test@openstreetmap.org", "test"
455 <node id='1' lon='1' lat='1' changeset='1' />
460 post :upload, :id => 1
461 assert_response :bad_request, "Shouldn't be able to upload a diff with the action ping"
462 assert_equal @response.body, "Unknown action ping, choices are create, modify, delete."
466 # upload a valid changeset which has a mixture of whitespace
467 # to check a bug reported by ivansanchez (#1565).
468 def test_upload_whitespace_valid
469 basic_authorization "test@openstreetmap.org", "test"
473 <modify><node id='1' lon='0' lat='0' changeset='1'
475 <node id='1' lon='1' lat='1' changeset='1' version='2'><tag k='k' v='v'/></node></modify>
477 <relation id='1' changeset='1' version='1'><member
478 type='way' role='some' ref='3'/><member
479 type='node' role='some' ref='5'/>
480 <member type='relation' role='some' ref='3'/>
482 </modify></osmChange>
487 post :upload, :id => 1
488 assert_response :success,
489 "can't upload a valid diff with whitespace variations to changeset: #{@response.body}"
491 # check the response is well-formed
492 assert_select "diffResult>node", 2
493 assert_select "diffResult>relation", 1
495 # check that the changes made it into the database
496 assert_equal 1, Node.find(1).tags.size, "node 1 should now have one tag"
497 assert_equal 0, Relation.find(1).tags.size, "relation 1 should now have no tags"
501 # upload a valid changeset which has a mixture of whitespace
502 # to check a bug reported by ivansanchez.
503 def test_upload_reuse_placeholder_valid
504 basic_authorization "test@openstreetmap.org", "test"
509 <node id='-1' lon='0' lat='0' changeset='1'>
510 <tag k="foo" v="bar"/>
514 <node id='-1' lon='1' lat='1' changeset='1' version='1'/>
517 <node id='-1' lon='2' lat='2' changeset='1' version='2'/>
524 post :upload, :id => 1
525 assert_response :success,
526 "can't upload a valid diff with re-used placeholders to changeset: #{@response.body}"
528 # check the response is well-formed
529 assert_select "diffResult>node", 3
530 assert_select "diffResult>node[old_id=-1]", 3
534 # test what happens if a diff upload re-uses placeholder IDs in an
536 def test_upload_placeholder_invalid
537 basic_authorization "test@openstreetmap.org", "test"
542 <node id='-1' lon='0' lat='0' changeset='1' version='1'/>
543 <node id='-1' lon='1' lat='1' changeset='1' version='1'/>
544 <node id='-1' lon='2' lat='2' changeset='1' version='2'/>
551 post :upload, :id => 1
552 assert_response :bad_request,
553 "shouldn't be able to re-use placeholder IDs"
557 # test for more issues in #1568
558 def test_upload_empty_invalid
559 basic_authorization "test@openstreetmap.org", "test"
562 "<osmChange></osmChange>",
563 "<osmChange><modify/></osmChange>",
564 "<osmChange><modify></modify></osmChange>"
568 post :upload, :id => 1
569 assert_response(:success, "should be able to upload " +
570 "empty changeset: " + diff)
575 # when we make some simple changes we get the same changes back from the
577 def test_diff_download_simple
578 basic_authorization(users(:normal_user).email, "test")
580 # create a temporary changeset
581 content "<osm><changeset>" +
582 "<tag k='created_by' v='osm test suite checking changesets'/>" +
585 assert_response :success
586 changeset_id = @response.body.to_i
592 <node id='1' lon='0' lat='0' changeset='#{changeset_id}' version='1'/>
593 <node id='1' lon='1' lat='0' changeset='#{changeset_id}' version='2'/>
594 <node id='1' lon='1' lat='1' changeset='#{changeset_id}' version='3'/>
595 <node id='1' lon='1' lat='2' changeset='#{changeset_id}' version='4'/>
596 <node id='1' lon='2' lat='2' changeset='#{changeset_id}' version='5'/>
597 <node id='1' lon='3' lat='2' changeset='#{changeset_id}' version='6'/>
598 <node id='1' lon='3' lat='3' changeset='#{changeset_id}' version='7'/>
599 <node id='1' lon='9' lat='9' changeset='#{changeset_id}' version='8'/>
606 post :upload, :id => changeset_id
607 assert_response :success,
608 "can't upload multiple versions of an element in a diff: #{@response.body}"
610 get :download, :id => changeset_id
611 assert_response :success
613 assert_select "osmChange", 1
614 assert_select "osmChange>modify", 8
615 assert_select "osmChange>modify>node", 8
619 # culled this from josm to ensure that nothing in the way that josm
620 # is formatting the request is causing it to fail.
622 # NOTE: the error turned out to be something else completely!
624 basic_authorization(users(:normal_user).email, "test")
626 # create a temporary changeset
627 content "<osm><changeset>" +
628 "<tag k='created_by' v='osm test suite checking changesets'/>" +
631 assert_response :success
632 changeset_id = @response.body.to_i
635 <osmChange version="0.6" generator="JOSM">
636 <create version="0.6" generator="JOSM">
637 <node id='-1' visible='true' changeset='#{changeset_id}' lat='51.49619982187321' lon='-0.18722061869438314' />
638 <node id='-2' visible='true' changeset='#{changeset_id}' lat='51.496359883909605' lon='-0.18653093576241928' />
639 <node id='-3' visible='true' changeset='#{changeset_id}' lat='51.49598132358285' lon='-0.18719613290981638' />
640 <node id='-4' visible='true' changeset='#{changeset_id}' lat='51.4961591711078' lon='-0.18629015888084607' />
641 <node id='-5' visible='true' changeset='#{changeset_id}' lat='51.49582126021711' lon='-0.18708186591517145' />
642 <node id='-6' visible='true' changeset='#{changeset_id}' lat='51.49591018437858' lon='-0.1861432441734455' />
643 <node id='-7' visible='true' changeset='#{changeset_id}' lat='51.49560784152179' lon='-0.18694719410005425' />
644 <node id='-8' visible='true' changeset='#{changeset_id}' lat='51.49567389979617' lon='-0.1860289771788006' />
645 <node id='-9' visible='true' changeset='#{changeset_id}' lat='51.49543761398892' lon='-0.186820684213126' />
646 <way id='-10' action='modiy' visible='true' changeset='#{changeset_id}'>
656 <tag k='highway' v='residential' />
657 <tag k='name' v='Foobar Street' />
665 post :upload, :id => changeset_id
666 assert_response :success,
667 "can't upload a diff from JOSM: #{@response.body}"
669 get :download, :id => changeset_id
670 assert_response :success
672 assert_select "osmChange", 1
673 assert_select "osmChange>create>node", 9
674 assert_select "osmChange>create>way", 1
675 assert_select "osmChange>create>way>nd", 9
676 assert_select "osmChange>create>way>tag", 2
680 # when we make some complex changes we get the same changes back from the
682 def test_diff_download_complex
683 basic_authorization(users(:normal_user).email, "test")
685 # create a temporary changeset
686 content "<osm><changeset>" +
687 "<tag k='created_by' v='osm test suite checking changesets'/>" +
690 assert_response :success
691 changeset_id = @response.body.to_i
697 <node id='1' lon='0' lat='0' changeset='#{changeset_id}' version='1'/>
700 <node id='-1' lon='9' lat='9' changeset='#{changeset_id}' version='0'/>
701 <node id='-2' lon='8' lat='9' changeset='#{changeset_id}' version='0'/>
702 <node id='-3' lon='7' lat='9' changeset='#{changeset_id}' version='0'/>
705 <node id='3' lon='20' lat='15' changeset='#{changeset_id}' version='1'/>
706 <way id='1' changeset='#{changeset_id}' version='1'>
718 post :upload, :id => changeset_id
719 assert_response :success,
720 "can't upload multiple versions of an element in a diff: #{@response.body}"
722 get :download, :id => changeset_id
723 assert_response :success
725 assert_select "osmChange", 1
726 assert_select "osmChange>create", 3
727 assert_select "osmChange>delete", 1
728 assert_select "osmChange>modify", 2
729 assert_select "osmChange>create>node", 3
730 assert_select "osmChange>delete>node", 1
731 assert_select "osmChange>modify>node", 1
732 assert_select "osmChange>modify>way", 1
736 # check that the bounding box of a changeset gets updated correctly
737 def test_changeset_bbox
738 basic_authorization "test@openstreetmap.org", "test"
740 # create a new changeset
741 content "<osm><changeset/></osm>"
743 assert_response :success, "Creating of changeset failed."
744 changeset_id = @response.body.to_i
746 # add a single node to it
747 with_controller(NodeController.new) do
748 content "<osm><node lon='1' lat='2' changeset='#{changeset_id}'/></osm>"
750 assert_response :success, "Couldn't create node."
753 # get the bounding box back from the changeset
754 get :read, :id => changeset_id
755 assert_response :success, "Couldn't read back changeset."
756 assert_select "osm>changeset[min_lon=1.0]", 1
757 assert_select "osm>changeset[max_lon=1.0]", 1
758 assert_select "osm>changeset[min_lat=2.0]", 1
759 assert_select "osm>changeset[max_lat=2.0]", 1
761 # add another node to it
762 with_controller(NodeController.new) do
763 content "<osm><node lon='2' lat='1' changeset='#{changeset_id}'/></osm>"
765 assert_response :success, "Couldn't create second node."
768 # get the bounding box back from the changeset
769 get :read, :id => changeset_id
770 assert_response :success, "Couldn't read back changeset for the second time."
771 assert_select "osm>changeset[min_lon=1.0]", 1
772 assert_select "osm>changeset[max_lon=2.0]", 1
773 assert_select "osm>changeset[min_lat=1.0]", 1
774 assert_select "osm>changeset[max_lat=2.0]", 1
776 # add (delete) a way to it
777 with_controller(WayController.new) do
778 content update_changeset(current_ways(:visible_way).to_xml,
780 put :delete, :id => current_ways(:visible_way).id
781 assert_response :success, "Couldn't delete a way."
784 # get the bounding box back from the changeset
785 get :read, :id => changeset_id
786 assert_response :success, "Couldn't read back changeset for the third time."
787 assert_select "osm>changeset[min_lon=1.0]", 1
788 assert_select "osm>changeset[max_lon=3.1]", 1
789 assert_select "osm>changeset[min_lat=1.0]", 1
790 assert_select "osm>changeset[max_lat=3.1]", 1
794 # test that the changeset :include method works as it should
795 def test_changeset_include
796 basic_authorization "test@openstreetmap.org", "test"
798 # create a new changeset
799 content "<osm><changeset/></osm>"
801 assert_response :success, "Creating of changeset failed."
802 changeset_id = @response.body.to_i
804 # NOTE: the include method doesn't over-expand, like inserting
805 # a real method does. this is because we expect the client to
806 # know what it is doing!
807 check_after_include(changeset_id, 1, 1, [ 1, 1, 1, 1])
808 check_after_include(changeset_id, 3, 3, [ 1, 1, 3, 3])
809 check_after_include(changeset_id, 4, 2, [ 1, 1, 4, 3])
810 check_after_include(changeset_id, 2, 2, [ 1, 1, 4, 3])
811 check_after_include(changeset_id, -1, -1, [-1, -1, 4, 3])
812 check_after_include(changeset_id, -2, 5, [-2, -1, 4, 5])
816 # test the query functionality of changesets
818 get :query, :bbox => "-10,-10, 10, 10"
819 assert_response :success, "can't get changesets in bbox"
820 assert_changesets [1,4,6]
822 get :query, :bbox => "4.5,4.5,4.6,4.6"
823 assert_response :success, "can't get changesets in bbox"
824 assert_changesets [1]
826 # can't get changesets of user 1 without authenticating
827 get :query, :user => users(:normal_user).id
828 assert_response :not_found, "shouldn't be able to get changesets by non-public user"
830 # but this should work
831 basic_authorization "test@openstreetmap.org", "test"
832 get :query, :user => users(:normal_user).id
833 assert_response :success, "can't get changesets by user"
834 assert_changesets [1,3,4,6]
836 get :query, :user => users(:normal_user).id, :open => true
837 assert_response :success, "can't get changesets by user and open"
838 assert_changesets [1,4]
840 get :query, :time => '2007-12-31'
841 assert_response :success, "can't get changesets by time-since"
842 assert_changesets [1,2,4,5,6]
844 get :query, :time => '2008-01-01T12:34Z'
845 assert_response :success, "can't get changesets by time-since with hour"
846 assert_changesets [1,2,4,5,6]
848 get :query, :time => '2007-12-31T23:59Z,2008-01-01T00:01Z'
849 assert_response :success, "can't get changesets by time-range"
850 assert_changesets [1,4,5,6]
852 get :query, :open => 'true'
853 assert_response :success, "can't get changesets by open-ness"
854 assert_changesets [1,2,4]
858 # check that errors are returned if garbage is inserted
860 def test_query_invalid
865 get :query, :bbox => bbox
866 assert_response :bad_request, "'#{bbox}' isn't a bbox"
871 ";drop table users;",
875 get :query, :time => time
876 assert_response :bad_request, "'#{time}' isn't a valid time range"
884 get :query, :user => uid
885 assert_response :bad_request, "'#{uid}' isn't a valid user ID"
890 # check updating tags on a changeset
891 def test_changeset_update
892 changeset = changesets(:normal_user_first_change)
893 new_changeset = changeset.to_xml
894 new_tag = XML::Node.new "tag"
895 new_tag['k'] = "tagtesting"
896 new_tag['v'] = "valuetesting"
897 new_changeset.find("//osm/changeset").first << new_tag
898 content new_changeset
900 # try without any authorization
901 put :update, :id => changeset.id
902 assert_response :unauthorized
904 # try with the wrong authorization
905 basic_authorization "test@example.com", "test"
906 put :update, :id => changeset.id
907 assert_response :conflict
909 # now this should work...
910 basic_authorization "test@openstreetmap.org", "test"
911 put :update, :id => changeset.id
912 assert_response :success
914 assert_select "osm>changeset[id=#{changeset.id}]", 1
915 assert_select "osm>changeset>tag", 2
916 assert_select "osm>changeset>tag[k=tagtesting][v=valuetesting]", 1
920 # check that a user different from the one who opened the changeset
922 def test_changeset_update_invalid
923 basic_authorization "test@example.com", "test"
925 changeset = changesets(:normal_user_first_change)
926 new_changeset = changeset.to_xml
927 new_tag = XML::Node.new "tag"
928 new_tag['k'] = "testing"
929 new_tag['v'] = "testing"
930 new_changeset.find("//osm/changeset").first << new_tag
932 content new_changeset
933 put :update, :id => changeset.id
934 assert_response :conflict
938 # check that a changeset can contain a certain max number of changes.
939 def test_changeset_limits
940 basic_authorization "test@openstreetmap.org", "test"
942 # open a new changeset
943 content "<osm><changeset/></osm>"
945 assert_response :success, "can't create a new changeset"
946 cs_id = @response.body.to_i
948 # start the counter just short of where the changeset should finish.
950 # alter the database to set the counter on the changeset directly,
951 # otherwise it takes about 6 minutes to fill all of them.
952 changeset = Changeset.find(cs_id)
953 changeset.num_changes = Changeset::MAX_ELEMENTS - offset
956 with_controller(NodeController.new) do
958 content "<osm><node changeset='#{cs_id}' lat='0.0' lon='0.0'/></osm>"
960 assert_response :success, "can't create a new node"
961 node_id = @response.body.to_i
963 get :read, :id => node_id
964 assert_response :success, "can't read back new node"
965 node_doc = XML::Parser.string(@response.body).parse
966 node_xml = node_doc.find("//osm/node").first
968 # loop until we fill the changeset with nodes
970 node_xml['lat'] = rand.to_s
971 node_xml['lon'] = rand.to_s
972 node_xml['version'] = (i+1).to_s
975 put :update, :id => node_id
976 assert_response :success, "attempt #{i} should have succeeded"
979 # trying again should fail
980 node_xml['lat'] = rand.to_s
981 node_xml['lon'] = rand.to_s
982 node_xml['version'] = offset.to_s
985 put :update, :id => node_id
986 assert_response :conflict, "final attempt should have failed"
989 changeset = Changeset.find(cs_id)
990 assert_equal Changeset::MAX_ELEMENTS + 1, changeset.num_changes
992 # check that the changeset is now closed as well
993 assert(!changeset.is_open?,
994 "changeset should have been auto-closed by exceeding " +
998 # This should display the last 20 changesets closed.
1000 @changesets = Changeset.find(:all, :order => "created_at DESC", :conditions => ['min_lat IS NOT NULL'], :limit=> 20)
1001 assert @changesets.size <= 20
1003 assert_response :success
1004 assert_template "list"
1005 # Now check that all 20 (or however many were returned) changesets are in the html
1006 assert_select "h1", :text => "Recent Changes", :count => 1
1007 assert_select "table[id='keyvalue'] tr", :count => @changesets.size + 1
1008 @changesets.each do |changeset|
1009 # FIXME this test needs rewriting - test for table contents
1013 #------------------------------------------------------------
1015 #------------------------------------------------------------
1018 # boilerplate for checking that certain changesets exist in the
1020 def assert_changesets(ids)
1021 assert_select "osm>changeset", ids.size
1023 assert_select "osm>changeset[id=#{id}]", 1
1028 # call the include method and assert properties of the bbox
1029 def check_after_include(changeset_id, lon, lat, bbox)
1030 content "<osm><node lon='#{lon}' lat='#{lat}'/></osm>"
1031 post :expand_bbox, :id => changeset_id
1032 assert_response :success, "Setting include of changeset failed: #{@response.body}"
1034 # check exactly one changeset
1035 assert_select "osm>changeset", 1
1036 assert_select "osm>changeset[id=#{changeset_id}]", 1
1039 doc = XML::Parser.string(@response.body).parse
1040 changeset = doc.find("//osm/changeset").first
1041 assert_equal bbox[0], changeset['min_lon'].to_f, "min lon"
1042 assert_equal bbox[1], changeset['min_lat'].to_f, "min lat"
1043 assert_equal bbox[2], changeset['max_lon'].to_f, "max lon"
1044 assert_equal bbox[3], changeset['max_lat'].to_f, "max lat"
1048 # update the changeset_id of a way element
1049 def update_changeset(xml, changeset_id)
1050 xml_attr_rewrite(xml, 'changeset', changeset_id)
1054 # update an attribute in a way element
1055 def xml_attr_rewrite(xml, name, value)
1056 xml.find("//osm/way").first[name] = value.to_s