Merge remote-tracking branch 'upstream/pull/3454'

[rails.git] / .rubocop_todo.yml

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 9aea439cb01f5b435f6bec0a8dce68197b5af69a..8c0827ab7d357f1bc2548d8200f27b2cc47a741a 100644 (file)
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
 # This configuration was generated by
 # `rubocop --auto-gen-config`

-# on 2021-01-11 19:00:54 UTC using RuboCop version 1.8.1.
+# on 2021-12-28 19:44:27 UTC using RuboCop version 1.24.0.

 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new


@@ -12,18 +12,33 @@ require:
   - rubocop-minitest
   - rubocop-performance
   - rubocop-rails
   - rubocop-minitest
   - rubocop-performance
   - rubocop-rails

+  - rubocop-rake

 
 # Offense count: 544
 # Cop supports --auto-correct.
 
 # Offense count: 544
 # Cop supports --auto-correct.

-# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.

 # URISchemes: http, https
 Layout/LineLength:
 # URISchemes: http, https
 Layout/LineLength:

-  Max: 248
+  Max: 270

 
 

-# Offense count: 36
+# Offense count: 62
+# Cop supports --auto-correct.
+Lint/AmbiguousOperatorPrecedence:
+  Exclude:
+    - 'app/controllers/geocoder_controller.rb'
+    - 'app/models/user.rb'
+    - 'lib/bounding_box.rb'
+    - 'lib/osm.rb'
+    - 'lib/rich_text.rb'
+    - 'lib/short_link.rb'
+    - 'test/controllers/api/old_nodes_controller_test.rb'
+    - 'test/lib/short_link_test.rb'
+
+# Offense count: 34

 # Configuration parameters: AllowSafeAssignment.
 Lint/AssignmentInCondition:
   Exclude:
 # Configuration parameters: AllowSafeAssignment.
 Lint/AssignmentInCondition:
   Exclude:

+    - 'app/controllers/accounts_controller.rb'

     - 'app/controllers/api/traces_controller.rb'
     - 'app/controllers/api/user_preferences_controller.rb'
     - 'app/controllers/application_controller.rb'
     - 'app/controllers/api/traces_controller.rb'
     - 'app/controllers/api/user_preferences_controller.rb'
     - 'app/controllers/application_controller.rb'


@@ -39,7 +54,7 @@ Lint/AssignmentInCondition:
     - 'lib/osm.rb'
     - 'script/deliver-message'
 
     - 'lib/osm.rb'
     - 'script/deliver-message'
 

-# Offense count: 8
+# Offense count: 7

 # Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches.
 Lint/DuplicateBranch:
   Exclude:
 # Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches.
 Lint/DuplicateBranch:
   Exclude:


@@ -47,14 +62,13 @@ Lint/DuplicateBranch:
     - 'app/controllers/diary_entries_controller.rb'
     - 'app/controllers/geocoder_controller.rb'
     - 'app/helpers/browse_tags_helper.rb'
     - 'app/controllers/diary_entries_controller.rb'
     - 'app/controllers/geocoder_controller.rb'
     - 'app/helpers/browse_tags_helper.rb'

-    - 'lib/password_hash.rb'

 
 

-# Offense count: 487
+# Offense count: 663

 # Configuration parameters: IgnoredMethods, CountRepeatedAttributes.
 Metrics/AbcSize:
 # Configuration parameters: IgnoredMethods, CountRepeatedAttributes.
 Metrics/AbcSize:

-  Max: 194
+  Max: 189

 
 

-# Offense count: 62
+# Offense count: 72

 # Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
 # IgnoredMethods: refine
 Metrics/BlockLength:
 # Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
 # IgnoredMethods: refine
 Metrics/BlockLength:


@@ -65,17 +79,17 @@ Metrics/BlockLength:
 Metrics/BlockNesting:
   Max: 5
 
 Metrics/BlockNesting:
   Max: 5
 

-# Offense count: 24
+# Offense count: 25

 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:
 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:

-  Max: 582
+  Max: 313

 
 

-# Offense count: 52
+# Offense count: 57

 # Configuration parameters: IgnoredMethods.
 Metrics/CyclomaticComplexity:
 # Configuration parameters: IgnoredMethods.
 Metrics/CyclomaticComplexity:

-  Max: 26
+  Max: 25

 
 

-# Offense count: 553
+# Offense count: 739

 # Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
 Metrics/MethodLength:
   Max: 179
 # Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
 Metrics/MethodLength:
   Max: 179


@@ -85,16 +99,16 @@ Metrics/MethodLength:
 Metrics/ParameterLists:
   Max: 6
 
 Metrics/ParameterLists:
   Max: 6
 

-# Offense count: 56
+# Offense count: 59

 # Configuration parameters: IgnoredMethods.
 Metrics/PerceivedComplexity:
   Max: 26
 
 # Configuration parameters: IgnoredMethods.
 Metrics/PerceivedComplexity:
   Max: 26
 

-# Offense count: 365
+# Offense count: 549

 Minitest/MultipleAssertions:
 Minitest/MultipleAssertions:

-  Max: 81
+  Max: 52

 
 

-# Offense count: 4
+# Offense count: 3

 Naming/AccessorMethodName:
   Exclude:
     - 'app/controllers/application_controller.rb'
 Naming/AccessorMethodName:
   Exclude:
     - 'app/controllers/application_controller.rb'


@@ -141,6 +155,14 @@ Rails/HelperInstanceVariable:
   Exclude:
     - 'app/helpers/title_helper.rb'
 
   Exclude:
     - 'app/helpers/title_helper.rb'
 

+# Offense count: 1
+# Configuration parameters: Include.
+# Include: app/controllers/**/*.rb
+Rails/LexicallyScopedActionFilter:
+  Exclude:
+    - 'app/controllers/oauth2_applications_controller.rb'
+    - 'app/controllers/oauth2_authorizations_controller.rb'
+

 # Offense count: 5
 # Configuration parameters: Include.
 # Include: db/migrate/*.rb
 # Offense count: 5
 # Configuration parameters: Include.
 # Include: db/migrate/*.rb


@@ -152,30 +174,45 @@ Rails/NotNullColumn:
     - 'db/migrate/025_add_end_time_to_changesets.rb'
     - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'
 
     - 'db/migrate/025_add_end_time_to_changesets.rb'
     - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'
 

-# Offense count: 8
+# Offense count: 9

 Rails/OutputSafety:
   Exclude:
 Rails/OutputSafety:
   Exclude:

+    - 'app/controllers/sessions_controller.rb'

     - 'app/controllers/users_controller.rb'
     - 'app/helpers/application_helper.rb'
     - 'lib/rich_text.rb'
     - 'test/helpers/application_helper_test.rb'
 
     - 'app/controllers/users_controller.rb'
     - 'app/helpers/application_helper.rb'
     - 'lib/rich_text.rb'
     - 'test/helpers/application_helper_test.rb'
 

-# Offense count: 80
+# Offense count: 23
+# Cop supports --auto-correct.
+Rails/RedundantPresenceValidationOnBelongsTo:
+  Enabled: false
+
+# Offense count: 90

 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: strict, flexible
 Rails/TimeZone:
   Enabled: false
 
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: strict, flexible
 Rails/TimeZone:
   Enabled: false
 

-# Offense count: 558
+# Offense count: 6
+# Cop supports --auto-correct.
+Rake/Desc:
+  Exclude:
+    - 'lib/tasks/auto_annotate_models.rake'
+    - 'lib/tasks/eslint.rake'
+    - 'lib/tasks/subscribe_diary_authors.rake'
+    - 'lib/tasks/subscribe_old_changesets.rake'
+
+# Offense count: 609

 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: always, always_true, never
 Style/FrozenStringLiteralComment:
   Enabled: false
 
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: always, always_true, never
 Style/FrozenStringLiteralComment:
   Enabled: false
 

-# Offense count: 54
+# Offense count: 72

 # Cop supports --auto-correct.
 # Cop supports --auto-correct.

-# Configuration parameters: Strict.
+# Configuration parameters: Strict, AllowedNumbers.

 Style/NumericLiterals:
   MinDigits: 15
 Style/NumericLiterals:
   MinDigits: 15