Avoid various uses of html_safe

[rails.git] / app / helpers / note_helper.rb

diff --git a/app/helpers/note_helper.rb b/app/helpers/note_helper.rb
index bfd7f493dfb8103b9d85b1b9187ce2bb7ec8b162..d85881a3111027cb3fe8f5b178deb0fc1acb6486 100644 (file)
--- a/app/helpers/note_helper.rb
+++ b/app/helpers/note_helper.rb
@@ -1,13 +1,26 @@
 module NoteHelper
-  def note_event(at, by)
+  include ActionView::Helpers::TranslationHelper
+
+  def note_event(event, at, by)
     if by.nil?
-      I18n.t("browse.note.at_html", :when => friendly_date(at)).html_safe
+      t("browse.note." + event + "_by_anonymous_html",
+        :when => friendly_date_ago(at),
+        :exact_time => l(at))
     else
-      I18n.t("browse.note.at_by_html", :when => friendly_date(at), :user => note_author(by)).html_safe
+      t("browse.note." + event + "_by_html",
+        :when => friendly_date_ago(at),
+        :exact_time => l(at),
+        :user => note_author(by))
     end
   end
 
   def note_author(author, link_options = {})
-    link_to h(author.display_name), link_options.merge({:controller => "user", :action => "view", :display_name => author.display_name})
+    if author.nil?
+      ""
+    elsif author.status == "deleted"
+      t("users.no_such_user.deleted")
+    else
+      link_to h(author.display_name), link_options.merge(:controller => "/users", :action => "show", :display_name => author.display_name)
+    end
   end
 end