Prefer keyword arguments when method has optional boolean arguments

[rails.git] / app / models / redaction.rb

diff --git a/app/models/redaction.rb b/app/models/redaction.rb
index b3c5ec5ba6753469a8b87c9cf6bb6af0fb4c36e0..f4eedde0a2daddb172843d910507494261c1b4ae 100644 (file)
--- a/app/models/redaction.rb
+++ b/app/models/redaction.rb
@@ -1,3 +1,20 @@
+# == Schema Information
+#
+# Table name: redactions
+#
+#  id                 :integer          not null, primary key
+#  title              :string
+#  description        :text
+#  created_at         :datetime
+#  updated_at         :datetime
+#  user_id            :bigint(8)        not null
+#  description_format :enum             default("markdown"), not null
+#
+# Foreign Keys
+#
+#  redactions_user_id_fkey  (user_id => users.id)
+#
+
 ##
 # Redaction represents a record associated with a particular
 # action on the database to hide revisions from the history
@@ -7,16 +24,20 @@
 # record's title and description fields, which can be
 # displayed linked from the redacted records.
 #
-class Redaction < ActiveRecord::Base
+class Redaction < ApplicationRecord
   belongs_to :user
 
   has_many :old_nodes
   has_many :old_ways
   has_many :old_relations
 
+  validates :title, :presence => true, :characters => true
+  validates :description, :presence => true, :characters => true
+  validates :description_format, :inclusion => { :in => %w[text html markdown] }
+
   # this method overrides the AR default to provide the rich
   # text object for the description field.
   def description
-    RichText.new(read_attribute(:description_format), read_attribute(:description))
+    RichText.new(self[:description_format], self[:description])
   end
 end