Be explicit in which traces are expected.

[rails.git] / .rubocop_todo.yml

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 287fcd9f9611a51f38747ca3b2f93ec969100592..95ddea8f893b186fa297cfddcc3a176a0aed2f71 100644 (file)
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
 # This configuration was generated by
 # `rubocop --auto-gen-config`

-# on 2015-08-18 20:27:49 +0100 using RuboCop version 0.33.0.
+# on 2016-10-20 21:45:27 +0100 using RuboCop version 0.44.1.

 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new


@@ -14,11 +14,11 @@ Lint/AmbiguousOperator:
     - 'test/lib/bounding_box_test.rb'
     - 'test/lib/country_test.rb'
 
     - 'test/lib/bounding_box_test.rb'
     - 'test/lib/country_test.rb'
 

-# Offense count: 115
+# Offense count: 117

 Lint/AmbiguousRegexpLiteral:
   Enabled: false
 
 Lint/AmbiguousRegexpLiteral:
   Enabled: false
 

-# Offense count: 29
+# Offense count: 30

 # Configuration parameters: AllowSafeAssignment.
 Lint/AssignmentInCondition:
   Exclude:
 # Configuration parameters: AllowSafeAssignment.
 Lint/AssignmentInCondition:
   Exclude:


@@ -36,11 +36,6 @@ Lint/AssignmentInCondition:
     - 'lib/osm.rb'
     - 'script/deliver-message'
 
     - 'lib/osm.rb'
     - 'script/deliver-message'
 

-# Offense count: 3
-Lint/FormatParameterMismatch:
-  Exclude:
-    - 'app/controllers/swf_controller.rb'
-

 # Offense count: 5
 Lint/HandleExceptions:
   Exclude:
 # Offense count: 5
 Lint/HandleExceptions:
   Exclude:


@@ -48,16 +43,19 @@ Lint/HandleExceptions:
     - 'app/controllers/user_controller.rb'
     - 'config/initializers/session.rb'
 
     - 'app/controllers/user_controller.rb'
     - 'config/initializers/session.rb'
 

-# Offense count: 8
-Lint/ParenthesesAsGroupedExpression:
+# Offense count: 2
+Lint/ShadowingOuterLocalVariable:

   Exclude:
   Exclude:

-    - 'test/controllers/amf_controller_test.rb'
-    - 'test/lib/bounding_box_test.rb'
-    - 'test/models/user_preference_test.rb'
+    - 'app/views/changeset/list.atom.builder'

 
 

-# Offense count: 671
+# Offense count: 630

 Metrics/AbcSize:
 Metrics/AbcSize:

-  Max: 277
+  Max: 271
+
+# Offense count: 35
+# Configuration parameters: CountComments.
+Metrics/BlockLength:
+  Max: 295

 
 # Offense count: 12
 Metrics/BlockNesting:
 
 # Offense count: 12
 Metrics/BlockNesting:


@@ -66,18 +64,19 @@ Metrics/BlockNesting:
 # Offense count: 62
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
 # Offense count: 62
 # Configuration parameters: CountComments.
 Metrics/ClassLength:

-  Max: 1653
+  Max: 1652

 
 

-# Offense count: 67
+# Offense count: 69

 Metrics/CyclomaticComplexity:
   Max: 20
 
 Metrics/CyclomaticComplexity:
   Max: 20
 

-# Offense count: 2535
-# Configuration parameters: AllowURI, URISchemes.
+# Offense count: 2826
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives.
+# URISchemes: http, https

 Metrics/LineLength:
   Max: 962
 
 Metrics/LineLength:
   Max: 962
 

-# Offense count: 628
+# Offense count: 612

 # Configuration parameters: CountComments.
 Metrics/MethodLength:
   Max: 179
 # Configuration parameters: CountComments.
 Metrics/MethodLength:
   Max: 179


@@ -85,26 +84,61 @@ Metrics/MethodLength:
 # Offense count: 1
 # Configuration parameters: CountComments.
 Metrics/ModuleLength:
 # Offense count: 1
 # Configuration parameters: CountComments.
 Metrics/ModuleLength:

-  Max: 126
+  Max: 147

 
 # Offense count: 4
 # Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:
   Max: 9
 
 
 # Offense count: 4
 # Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:
   Max: 9
 

-# Offense count: 69
+# Offense count: 71

 Metrics/PerceivedComplexity:
   Max: 23
 
 # Offense count: 2
 # Configuration parameters: Include.
 Metrics/PerceivedComplexity:
   Max: 23
 
 # Offense count: 2
 # Configuration parameters: Include.

+# Include: app/**/*.rb, config/**/*.rb, lib/**/*.rb
+Rails/Exit:
+  Exclude:
+    - 'lib/**/*.rake'
+    - 'lib/daemons/gpx_import.rb'
+
+# Offense count: 2
+# Configuration parameters: Include.
+# Include: app/models/**/*.rb

 Rails/HasAndBelongsToMany:
   Exclude:
     - 'app/models/changeset.rb'
     - 'app/models/user.rb'
 
 Rails/HasAndBelongsToMany:
   Exclude:
     - 'app/models/changeset.rb'
     - 'app/models/user.rb'
 

-# Offense count: 66
+# Offense count: 5
+# Configuration parameters: Include.
+# Include: db/migrate/*.rb
+Rails/NotNullColumn:
+  Exclude:
+    - 'db/migrate/002_cleanup_osm_db.rb'
+    - 'db/migrate/020_populate_node_tags_and_remove.rb'
+    - 'db/migrate/021_move_to_innodb.rb'
+    - 'db/migrate/025_add_end_time_to_changesets.rb'
+    - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'
+
+# Offense count: 17
+Rails/OutputSafety:
+  Exclude:
+    - 'app/controllers/user_controller.rb'
+    - 'app/helpers/application_helper.rb'
+    - 'app/helpers/changeset_helper.rb'
+    - 'app/helpers/geocoder_helper.rb'
+    - 'app/helpers/note_helper.rb'
+    - 'app/helpers/open_graph_helper.rb'
+    - 'app/helpers/user_blocks_helper.rb'
+    - 'app/helpers/user_roles_helper.rb'
+    - 'lib/rich_text.rb'
+    - 'test/helpers/application_helper_test.rb'
+
+# Offense count: 74

 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # Configuration parameters: EnforcedStyle, SupportedStyles.

+# SupportedStyles: strict, flexible

 Rails/TimeZone:
   Enabled: false
 
 Rails/TimeZone:
   Enabled: false
 


@@ -122,27 +156,16 @@ Style/AsciiComments:
   Exclude:
     - 'test/models/message_test.rb'
 
   Exclude:
     - 'test/models/message_test.rb'
 

-# Offense count: 310
+# Offense count: 220

 Style/Documentation:
   Enabled: false
 
 Style/Documentation:
   Enabled: false
 

-# Offense count: 38
-# Configuration parameters: MinBodyLength.
-Style/GuardClause:
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: MaxLineLength.
+Style/IfUnlessModifier:

   Exclude:
   Exclude:

-    - 'app/controllers/application_controller.rb'
-    - 'app/controllers/diary_entry_controller.rb'
-    - 'app/controllers/message_controller.rb'
-    - 'app/controllers/notes_controller.rb'
-    - 'app/controllers/site_controller.rb'
-    - 'app/controllers/user_blocks_controller.rb'
-    - 'app/controllers/user_controller.rb'
-    - 'app/controllers/user_roles_controller.rb'
-    - 'app/helpers/application_helper.rb'
-    - 'app/models/changeset.rb'
-    - 'app/models/user.rb'
-    - 'lib/diff_reader.rb'
-    - 'lib/object_metadata.rb'
+    - 'app/controllers/way_controller.rb'

 
 # Offense count: 60
 # Cop supports --auto-correct.
 
 # Offense count: 60
 # Cop supports --auto-correct.


@@ -159,27 +182,19 @@ Style/LineEndConcatenation:
     - 'test/controllers/relation_controller_test.rb'
     - 'test/controllers/way_controller_test.rb'
 
     - 'test/controllers/relation_controller_test.rb'
     - 'test/controllers/way_controller_test.rb'
 

-# Offense count: 69
+# Offense count: 71

 # Cop supports --auto-correct.
 Style/NumericLiterals:
   MinDigits: 11
 
 # Cop supports --auto-correct.
 Style/NumericLiterals:
   MinDigits: 11
 

-# Offense count: 42
-# Cop supports --auto-correct.
-Style/PerlBackrefs:
-  Exclude:
-    - 'app/controllers/amf_controller.rb'
-    - 'app/controllers/application_controller.rb'
-    - 'app/helpers/browse_helper.rb'
-    - 'config/initializers/paperclip.rb'
-    - 'lib/id.rb'
-    - 'lib/potlatch.rb'
-    - 'test/lib/i18n_test.rb'
-

 # Offense count: 8
 # Offense count: 8

-# Configuration parameters: NamePrefix, NamePrefixBlacklist.
+# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
+# NamePrefix: is_, has_, have_
+# NamePrefixBlacklist: is_, has_, have_
+# NameWhitelist: is_a?

 Style/PredicateName:
   Exclude:
 Style/PredicateName:
   Exclude:

+    - 'spec/**/*'

     - 'app/models/changeset.rb'
     - 'app/models/old_node.rb'
     - 'app/models/old_relation.rb'
     - 'app/models/changeset.rb'
     - 'app/models/old_node.rb'
     - 'app/models/old_relation.rb'


@@ -188,17 +203,14 @@ Style/PredicateName:
     - 'lib/classic_pagination/pagination.rb'
 
 # Offense count: 97
     - 'lib/classic_pagination/pagination.rb'
 
 # Offense count: 97

+# Cop supports --auto-correct.

 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # Configuration parameters: EnforcedStyle, SupportedStyles.

+# SupportedStyles: compact, exploded

 Style/RaiseArgs:
   Enabled: false
 
 # Offense count: 2
 Style/RaiseArgs:
   Enabled: false
 
 # Offense count: 2

+# Cop supports --auto-correct.

 Style/RescueModifier:
   Exclude:
     - 'app/helpers/browse_helper.rb'
 Style/RescueModifier:
   Exclude:
     - 'app/helpers/browse_helper.rb'

-
-# Offense count: 8
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/StringLiteralsInInterpolation:
-  Enabled: false