Move xml gen. into view for (old) nodes, ways, relations, map

[rails.git] / app / controllers / api / old_controller.rb

diff --git a/app/controllers/api/old_controller.rb b/app/controllers/api/old_controller.rb
index 9d9f2fabc656d6421ee6d987e94c85d63cb681ab..39bb35ca9f05757c2ac6d4df4d710c411e685010 100644 (file)
--- a/app/controllers/api/old_controller.rb
+++ b/app/controllers/api/old_controller.rb
@@ -6,7 +6,6 @@ module Api
     require "xml/libxml"
 
     before_action :setup_user_auth, :only => [:history, :version]
-    before_action :api_deny_access_handler
     before_action :authorize, :only => [:redact]
 
     authorize_resource
@@ -23,19 +22,22 @@ module Api
       # to do that ourselves.
       raise OSM::APINotFoundError if @elements.empty?
 
-      doc = OSM::API.new.get_xml_doc
-
       visible_elements = if show_redactions?
                            @elements
                          else
                            @elements.unredacted
                          end
 
+      @elems = []
+
       visible_elements.each do |element|
-        doc.root << element.to_xml_node
+        @elems << element
       end
 
-      render :xml => doc.to_s
+      # Render the result
+      respond_to do |format|
+        format.xml
+      end
     end
 
     def version
@@ -45,10 +47,12 @@ module Api
       else
         response.last_modified = @old_element.timestamp
 
-        doc = OSM::API.new.get_xml_doc
-        doc.root << @old_element.to_xml_node
+        @elems = [@old_element]
 
-        render :xml => doc.to_s
+        # Render the result
+        respond_to do |format|
+          format.xml
+        end
       end
     end