Fix new rubocop warnings

[rails.git] / test / models / note_test.rb

diff --git a/test/models/note_test.rb b/test/models/note_test.rb
index b74cebcc4cc4d2da028f451eb97e0a5bf57ff0ce..8d5a557cd4dfbbe9b8ffb043fe6047aec7f3049c 100644 (file)
--- a/test/models/note_test.rb
+++ b/test/models/note_test.rb
@@ -8,7 +8,7 @@ class NoteTest < ActiveSupport::TestCase
     ok.each do |status|
       note = create(:note)
       note.status = status
-      assert note.valid?, "#{status} is invalid, when it should be"
+      assert_predicate note, :valid?, "#{status} is invalid, when it should be"
     end
 
     bad.each do |status|
@@ -37,13 +37,13 @@ class NoteTest < ActiveSupport::TestCase
   end
 
   def test_visible?
-    assert create(:note, :status => "open").visible?
-    assert create(:note, :status => "closed").visible?
+    assert_predicate create(:note, :status => "open"), :visible?
+    assert_predicate create(:note, :status => "closed"), :visible?
     assert_not create(:note, :status => "hidden").visible?
   end
 
   def test_closed?
-    assert create(:note, :status => "closed", :closed_at => Time.now.utc).closed?
+    assert_predicate create(:note, :status => "closed", :closed_at => Time.now.utc), :closed?
     assert_not create(:note, :status => "open", :closed_at => nil).closed?
   end