Use user factories for page_locale integration tests.

[rails.git] / .rubocop_todo.yml

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 927f4078070ae9d2794dc30daf88973a9bf404f8..68a7566d9e35828e6908d85296408010bfe27d50 100644 (file)
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
 # This configuration was generated by
 # `rubocop --auto-gen-config`

-# on 2016-07-13 09:47:52 +0100 using RuboCop version 0.41.2.
+# on 2016-10-20 21:45:27 +0100 using RuboCop version 0.44.1.

 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new


@@ -14,11 +14,11 @@ Lint/AmbiguousOperator:
     - 'test/lib/bounding_box_test.rb'
     - 'test/lib/country_test.rb'
 
     - 'test/lib/bounding_box_test.rb'
     - 'test/lib/country_test.rb'
 

-# Offense count: 115
+# Offense count: 117

 Lint/AmbiguousRegexpLiteral:
   Enabled: false
 
 Lint/AmbiguousRegexpLiteral:
   Enabled: false
 

-# Offense count: 29
+# Offense count: 30

 # Configuration parameters: AllowSafeAssignment.
 Lint/AssignmentInCondition:
   Exclude:
 # Configuration parameters: AllowSafeAssignment.
 Lint/AssignmentInCondition:
   Exclude:


@@ -43,30 +43,40 @@ Lint/HandleExceptions:
     - 'app/controllers/user_controller.rb'
     - 'config/initializers/session.rb'
 
     - 'app/controllers/user_controller.rb'
     - 'config/initializers/session.rb'
 

-# Offense count: 616
+# Offense count: 2
+Lint/ShadowingOuterLocalVariable:
+  Exclude:
+    - 'app/views/changeset/list.atom.builder'
+
+# Offense count: 630

 Metrics/AbcSize:
 Metrics/AbcSize:

-  Max: 277
+  Max: 280
+
+# Offense count: 35
+# Configuration parameters: CountComments.
+Metrics/BlockLength:
+  Max: 295

 
 

-# Offense count: 11
+# Offense count: 12

 Metrics/BlockNesting:
   Max: 5
 
 # Offense count: 62
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
 Metrics/BlockNesting:
   Max: 5
 
 # Offense count: 62
 # Configuration parameters: CountComments.
 Metrics/ClassLength:

-  Max: 1650
+  Max: 1660

 
 

-# Offense count: 67
+# Offense count: 69

 Metrics/CyclomaticComplexity:
   Max: 20
 
 Metrics/CyclomaticComplexity:
   Max: 20
 

-# Offense count: 2485
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes.
+# Offense count: 2826
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives.

 # URISchemes: http, https
 Metrics/LineLength:
 # URISchemes: http, https
 Metrics/LineLength:

-  Max: 962
+  Max: 1072

 
 

-# Offense count: 596
+# Offense count: 612

 # Configuration parameters: CountComments.
 Metrics/MethodLength:
   Max: 179
 # Configuration parameters: CountComments.
 Metrics/MethodLength:
   Max: 179


@@ -74,14 +84,14 @@ Metrics/MethodLength:
 # Offense count: 1
 # Configuration parameters: CountComments.
 Metrics/ModuleLength:
 # Offense count: 1
 # Configuration parameters: CountComments.
 Metrics/ModuleLength:

-  Max: 139
+  Max: 147

 
 # Offense count: 4
 # Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:
   Max: 9
 
 
 # Offense count: 4
 # Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:
   Max: 9
 

-# Offense count: 70
+# Offense count: 71

 Metrics/PerceivedComplexity:
   Max: 23
 
 Metrics/PerceivedComplexity:
   Max: 23
 


@@ -101,6 +111,17 @@ Rails/HasAndBelongsToMany:
     - 'app/models/changeset.rb'
     - 'app/models/user.rb'
 
     - 'app/models/changeset.rb'
     - 'app/models/user.rb'
 

+# Offense count: 5
+# Configuration parameters: Include.
+# Include: db/migrate/*.rb
+Rails/NotNullColumn:
+  Exclude:
+    - 'db/migrate/002_cleanup_osm_db.rb'
+    - 'db/migrate/020_populate_node_tags_and_remove.rb'
+    - 'db/migrate/021_move_to_innodb.rb'
+    - 'db/migrate/025_add_end_time_to_changesets.rb'
+    - 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'
+

 # Offense count: 17
 Rails/OutputSafety:
   Exclude:
 # Offense count: 17
 Rails/OutputSafety:
   Exclude:


@@ -115,7 +136,7 @@ Rails/OutputSafety:
     - 'lib/rich_text.rb'
     - 'test/helpers/application_helper_test.rb'
 
     - 'lib/rich_text.rb'
     - 'test/helpers/application_helper_test.rb'
 

-# Offense count: 65
+# Offense count: 74

 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # SupportedStyles: strict, flexible
 Rails/TimeZone:
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # SupportedStyles: strict, flexible
 Rails/TimeZone:


@@ -135,10 +156,17 @@ Style/AsciiComments:
   Exclude:
     - 'test/models/message_test.rb'
 
   Exclude:
     - 'test/models/message_test.rb'
 

-# Offense count: 217
+# Offense count: 220

 Style/Documentation:
   Enabled: false
 
 Style/Documentation:
   Enabled: false
 

+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: MaxLineLength.
+Style/IfUnlessModifier:
+  Exclude:
+    - 'app/controllers/way_controller.rb'
+

 # Offense count: 60
 # Cop supports --auto-correct.
 Style/LineEndConcatenation:
 # Offense count: 60
 # Cop supports --auto-correct.
 Style/LineEndConcatenation:


@@ -154,22 +182,11 @@ Style/LineEndConcatenation:
     - 'test/controllers/relation_controller_test.rb'
     - 'test/controllers/way_controller_test.rb'
 
     - 'test/controllers/relation_controller_test.rb'
     - 'test/controllers/way_controller_test.rb'
 

-# Offense count: 69
+# Offense count: 71

 # Cop supports --auto-correct.
 Style/NumericLiterals:
   MinDigits: 11
 
 # Cop supports --auto-correct.
 Style/NumericLiterals:
   MinDigits: 11
 

-# Offense count: 38
-# Cop supports --auto-correct.
-Style/PerlBackrefs:
-  Exclude:
-    - 'app/controllers/amf_controller.rb'
-    - 'app/helpers/browse_helper.rb'
-    - 'config/initializers/paperclip.rb'
-    - 'lib/id.rb'
-    - 'lib/potlatch.rb'
-    - 'test/lib/i18n_test.rb'
-

 # Offense count: 8
 # Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
 # NamePrefix: is_, has_, have_
 # Offense count: 8
 # Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
 # NamePrefix: is_, has_, have_


@@ -197,15 +214,3 @@ Style/RaiseArgs:
 Style/RescueModifier:
   Exclude:
     - 'app/helpers/browse_helper.rb'
 Style/RescueModifier:
   Exclude:
     - 'app/helpers/browse_helper.rb'

-
-# Offense count: 8
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: single_quotes, double_quotes
-Style/StringLiteralsInInterpolation:
-  Exclude:
-    - 'app/controllers/amf_controller.rb'
-    - 'app/models/node.rb'
-    - 'app/models/way.rb'
-    - 'lib/migrate.rb'
-    - 'test/controllers/changeset_controller_test.rb'