Merge remote-tracking branch 'upstream/pull/2597'

[rails.git] / .rubocop.yml

diff --git a/.rubocop.yml b/.rubocop.yml
index e12437e080c3d8f0d81731537acf0847ecfbf8bf..d9fcce7c67a9abe93226b4f6df91b67c799533fa 100644 (file)
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -1,5 +1,16 @@
 inherit_from: .rubocop_todo.yml
 
+require:
+  - rubocop-minitest
+  - rubocop-performance
+  - rubocop-rails
+
+AllCops:
+  TargetRubyVersion: 2.5
+  NewCops: enable
+  Exclude:
+    - 'vendor/**/*'
+
 Rails:
   Enabled: true
 
@@ -12,19 +23,30 @@ Lint/PercentStringArray:
     - 'app/controllers/application_controller.rb'
     - 'app/controllers/site_controller.rb'
 
+Metrics/BlockLength:
+  Exclude:
+    - 'config/routes.rb'
+
+Metrics/ClassLength:
+  Exclude:
+    - 'test/**/*'
+
+Metrics/ModuleLength:
+  Max: 150
+
 Naming/FileName:
   Exclude:
     - 'script/deliver-message'
     - 'script/locale/reload-languages'
     - 'script/update-spam-blocks'
 
-Naming/UncommunicativeMethodParamName:
+Naming/MethodParameterName:
   Enabled: false
 
-Rails/ApplicationRecord:
+Rails/CreateTableWithTimestamps:
   Enabled: false
 
-Rails/CreateTableWithTimestamps:
+Rails/FindEach:
   Enabled: false
 
 Rails/HasManyOrHasOneDependent:
@@ -39,10 +61,10 @@ Rails/InverseOf:
 Rails/SkipsModelValidations:
   Exclude:
     - 'db/migrate/*.rb'
-    - 'app/controllers/user_controller.rb'
+    - 'app/controllers/users_controller.rb'
 
-Style/BracesAroundHashParameters:
-  EnforcedStyle: context_dependent
+Style/Documentation:
+  Enabled: false
 
 Style/FormatStringToken:
   EnforcedStyle: template
@@ -50,19 +72,29 @@ Style/FormatStringToken:
 Style/IfInsideElse:
   Enabled: false
 
-Style/GlobalVars:
-  Exclude:
-    - 'lib/quad_tile/extconf.rb'
-
 Style/GuardClause:
   Enabled: false
 
+Style/HashEachMethods:
+  Enabled: true
+
 Style/HashSyntax:
   EnforcedStyle: hash_rockets
   Exclude:
     - 'lib/tasks/testing.rake'
     - 'config/initializers/wrap_parameters.rb'
 
+Style/HashTransformKeys:
+  Enabled: true
+
+Style/HashTransformValues:
+  Enabled: true
+
+Style/MixinUsage:
+  Exclude:
+    - 'bin/setup'
+    - 'bin/update'
+
 Style/StringLiterals:
   EnforcedStyle: double_quotes