# This configuration was generated by
# `rubocop --auto-gen-config`
-# on 2019-10-19 16:05:52 +0000 using RuboCop version 0.75.0.
+# on 2021-01-11 19:00:54 UTC using RuboCop version 1.8.1.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# Work around erblint issues.
# https://github.com/openstreetmap/openstreetmap-website/issues/2472
require:
+ - rubocop-minitest
- rubocop-performance
- rubocop-rails
-# Offense count: 3338
+# Offense count: 544
# Cop supports --auto-correct.
# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
# URISchemes: http, https
Layout/LineLength:
- Max: 260
+ Max: 254
-# Offense count: 35
+# Offense count: 36
# Configuration parameters: AllowSafeAssignment.
Lint/AssignmentInCondition:
Exclude:
- 'app/controllers/users_controller.rb'
- 'app/helpers/application_helper.rb'
- 'app/helpers/browse_tags_helper.rb'
- - 'app/mailers/notifier.rb'
+ - 'app/mailers/user_mailer.rb'
- 'app/models/client_application.rb'
- 'lib/nominatim.rb'
- 'lib/osm.rb'
- 'script/deliver-message'
-# Offense count: 4
-# Configuration parameters: AllowComments.
-Lint/SuppressedException:
+# Offense count: 8
+# Configuration parameters: IgnoreLiteralBranches, IgnoreConstantBranches.
+Lint/DuplicateBranch:
Exclude:
- - 'app/controllers/api/amf_controller.rb'
- - 'app/controllers/users_controller.rb'
- - 'app/controllers/site_controller.rb'
+ - 'app/controllers/api_controller.rb'
+ - 'app/controllers/diary_entries_controller.rb'
+ - 'app/controllers/geocoder_controller.rb'
+ - 'app/helpers/browse_tags_helper.rb'
+ - 'lib/password_hash.rb'
-# Offense count: 701
+# Offense count: 487
+# Configuration parameters: IgnoredMethods, CountRepeatedAttributes.
Metrics/AbcSize:
- Max: 189
+ Max: 234
-# Offense count: 39
-# Configuration parameters: CountComments, ExcludedMethods.
-# ExcludedMethods: refine
+# Offense count: 62
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
+# IgnoredMethods: refine
Metrics/BlockLength:
Max: 71
Metrics/BlockNesting:
Max: 5
-# Offense count: 25
-# Configuration parameters: CountComments.
+# Offense count: 24
+# Configuration parameters: CountComments, CountAsOne.
Metrics/ClassLength:
- Max: 645
+ Max: 582
-# Offense count: 74
+# Offense count: 52
+# Configuration parameters: IgnoredMethods.
Metrics/CyclomaticComplexity:
- Max: 22
+ Max: 26
-# Offense count: 722
-# Configuration parameters: CountComments, ExcludedMethods.
+# Offense count: 553
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
Metrics/MethodLength:
Max: 179
-# Offense count: 2
-# Configuration parameters: CountComments.
-Metrics/ModuleLength:
- Max: 117
-
-# Offense count: 4
-# Configuration parameters: CountKeywordArgs.
+# Offense count: 1
+# Configuration parameters: CountKeywordArgs, MaxOptionalParameters.
Metrics/ParameterLists:
- Max: 9
+ Max: 6
-# Offense count: 72
+# Offense count: 56
+# Configuration parameters: IgnoredMethods.
Metrics/PerceivedComplexity:
- Max: 25
-
-# Offense count: 2
-# Cop supports --auto-correct.
-Minitest/AssertEmpty:
- Exclude:
- - 'test/controllers/api/amf_controller_test.rb'
-
-# Offense count: 6
-# Cop supports --auto-correct.
-Minitest/AssertEqual:
- Exclude:
- - 'test/controllers/api/amf_controller_test.rb'
-
-# Offense count: 27
-# Cop supports --auto-correct.
-Minitest/AssertIncludes:
- Exclude:
- - 'test/controllers/api/amf_controller_test.rb'
- - 'test/controllers/api/nodes_controller_test.rb'
- - 'test/helpers/browse_helper_test.rb'
- - 'test/lib/i18n_test.rb'
- - 'test/models/node_test.rb'
- - 'test/models/old_node_test.rb'
- - 'test/models/user_test.rb'
-
-# Offense count: 104
-# Cop supports --auto-correct.
-Minitest/AssertTruthy:
- Enabled: false
+ Max: 26
-# Offense count: 110
-# Cop supports --auto-correct.
-Minitest/RefuteFalse:
- Enabled: false
+# Offense count: 365
+Minitest/MultipleAssertions:
+ Max: 97
-# Offense count: 6
+# Offense count: 4
Naming/AccessorMethodName:
Exclude:
- 'app/controllers/application_controller.rb'
- 'app/helpers/title_helper.rb'
- - 'app/models/old_way.rb'
- 'lib/osm.rb'
- - 'lib/potlatch.rb'
# Offense count: 8
-# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros.
+# Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros.
# NamePrefix: is_, has_, have_
-# NamePrefixBlacklist: is_, has_, have_
-# NameWhitelist: is_a?
+# ForbiddenPrefixes: is_, has_, have_
+# AllowedMethods: is_a?
# MethodDefinitionMacros: define_method, define_singleton_method
Naming/PredicateName:
Exclude:
- - 'spec/**/*'
- 'app/models/changeset.rb'
- 'app/models/old_node.rb'
- 'app/models/old_relation.rb'
- 'lib/classic_pagination/pagination.rb'
# Offense count: 5
-# Cop supports --auto-correct.
-Performance/RegexpMatch:
- Exclude:
- - 'app/helpers/browse_tags_helper.rb'
- - 'app/validators/characters_validator.rb'
- - 'app/validators/whitespace_validator.rb'
-
-# Offense count: 6
# Configuration parameters: Database, Include.
# SupportedDatabases: mysql, postgresql
# Include: db/migrate/*.rb
Rails/BulkChangeTable:
Exclude:
- 'db/migrate/20111116184519_update_oauth.rb'
- - 'db/migrate/20120208122334_merge_acl_address_and_mask.rb'
- 'db/migrate/20120208194454_add_domain_to_acl.rb'
- 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'
- 'app/models/changeset.rb'
- 'app/models/user.rb'
-# Offense count: 11
+# Offense count: 3
# Configuration parameters: Include.
# Include: app/helpers/**/*.rb
Rails/HelperInstanceVariable:
Exclude:
- - 'app/helpers/application_helper.rb'
- 'app/helpers/title_helper.rb'
- - 'app/helpers/trace_helper.rb'
# Offense count: 5
# Configuration parameters: Include.
- 'db/migrate/025_add_end_time_to_changesets.rb'
- 'db/migrate/20120404205604_add_user_and_description_to_redaction.rb'
-# Offense count: 18
+# Offense count: 8
Rails/OutputSafety:
Exclude:
- 'app/controllers/users_controller.rb'
- 'app/helpers/application_helper.rb'
- - 'app/helpers/changesets_helper.rb'
- - 'app/helpers/geocoder_helper.rb'
- - 'app/helpers/note_helper.rb'
- - 'app/helpers/open_graph_helper.rb'
- - 'app/helpers/user_blocks_helper.rb'
- 'lib/rich_text.rb'
- 'test/helpers/application_helper_test.rb'
-# Offense count: 94
+# Offense count: 80
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: strict, flexible
Rails/TimeZone:
Enabled: false
-# Offense count: 1
-# Configuration parameters: AllowedChars.
-Style/AsciiComments:
- Exclude:
- - 'test/models/message_test.rb'
-
-# Offense count: 27
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: annotated, template, unannotated
-Style/FormatStringToken:
- Exclude:
- - 'app/models/concerns/geo_record.rb'
- - 'app/views/api/map/_bounds.xml.builder'
- - 'lib/bounding_box.rb'
- - 'test/controllers/api/map_controller_test.rb'
- - 'test/controllers/api/relations_controller_test.rb'
- - 'test/controllers/api/ways_controller_test.rb'
- - 'test/lib/bounding_box_test.rb'
-
-# Offense count: 539
+# Offense count: 558
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
-# SupportedStyles: always, never
+# SupportedStyles: always, always_true, never
Style/FrozenStringLiteralComment:
Enabled: false
-# Offense count: 2
-# Cop supports --auto-correct.
-Style/IfUnlessModifier:
- Exclude:
- - 'app/controllers/api/ways_controller.rb'
-
-# Offense count: 70
+# Offense count: 54
# Cop supports --auto-correct.
# Configuration parameters: Strict.
Style/NumericLiterals:
- MinDigits: 11
+ MinDigits: 15
projects / rails.git / blobdiff