Avoid mass assignment error in spam observer
[rails.git] / app / models / spam_observer.rb
index 21561f6718fd330704d528de86a2805ddbbbc262..07fa84ffd07c6975d0043c71b086d62cbbda2fc2 100644 (file)
@@ -3,13 +3,13 @@ class SpamObserver < ActiveRecord::Observer
 
   def after_save(record)
     case
-    when record.is_a?(User): user = record
-    when record.is_a?(DiaryEntry): user = record.user
-    when record.is_a?(DiaryComment): user = record.user
+    when record.is_a?(User) then user = record
+    when record.is_a?(DiaryEntry) then user = record.user
+    when record.is_a?(DiaryComment) then user = record.user
     end
 
-    if user.status == "active" and user.spam_score > APP_CONFIG['spam_threshold']
-      user.update_attributes(:status => "suspended")
+    if user.status == "active" and user.spam_score > SPAM_THRESHOLD
+      user.update_column(:status, "suspended")
     end
   end
 end