Fix rubocop lint issues

[rails.git] / lib / rich_text.rb

diff --git a/lib/rich_text.rb b/lib/rich_text.rb
index 9c4a24fd54a11c18e7d50d3b65e8b137e768dc24..503ecedbd5af1780727265b42ead375c8607c250 100644 (file)
--- a/lib/rich_text.rb
+++ b/lib/rich_text.rb
@@ -1,14 +1,25 @@
 module RichText
   def self.new(format, text)
     case format
-    when "html"; HTML.new(text || "")
-    when "markdown"; Markdown.new(text || "")
-    when "text"; Text.new(text || "")
+    when "html" then HTML.new(text || "")
+    when "markdown" then Markdown.new(text || "")
+    when "text" then Text.new(text || "")
     else; nil
     end
   end
 
+  class SimpleFormat
+    include ActionView::Helpers::TextHelper
+    include ActionView::Helpers::OutputSafetyHelper
+
+    def sanitize(text)
+      Sanitize.clean(text, Sanitize::Config::OSM).html_safe
+    end
+  end
+
   class Base < String
+    include ActionView::Helpers::TagHelper
+
     def spam_score
       link_count = 0
       link_size = 0
@@ -26,10 +37,14 @@ module RichText
         link_proportion = 0
       end
 
-      return [link_proportion - 0.2, 0.0].max * 200 + link_count * 20
+      [link_proportion - 0.2, 0.0].max * 200 + link_count * 40
     end
 
-  protected
+    protected
+
+    def simple_format(text)
+      SimpleFormat.new.simple_format(text)
+    end
 
     def linkify(text)
       if text.html_safe?
@@ -41,18 +56,15 @@ module RichText
   end
 
   class HTML < Base
-    include ActionView::Helpers::TextHelper
-    include ActionView::Helpers::TagHelper
-
     def to_html
       linkify(sanitize(simple_format(self)))
     end
 
     def to_text
-      self
+      to_s
     end
 
-  private
+    private
 
     def sanitize(text)
       Sanitize.clean(text, Sanitize::Config::OSM).html_safe
@@ -65,30 +77,38 @@ module RichText
     end
 
     def to_text
-      self
+      to_s
     end
 
-  private
+    private
 
     def html_parser
-      @@html_renderer ||= Redcarpet::Render::XHTML.new({
-        :filter_html => true, :safe_links_only => true
-      })
-      @@html_parser ||= Redcarpet::Markdown.new(@@html_renderer, {
-        :no_intra_emphasis => true, :autolink => true, :space_after_headers => true
-      })
+      @@html_renderer ||= Renderer.new(:filter_html => true, :safe_links_only => true)
+      @@html_parser ||= Redcarpet::Markdown.new(@@html_renderer,         :no_intra_emphasis => true, :autolink => true, :space_after_headers => true)
+    end
+
+    class Renderer < Redcarpet::Render::XHTML
+      def link(link, _title, alt_text)
+        "<a rel=\"nofollow\" href=\"#{link}\">#{alt_text}</a>"
+      end
+
+      def autolink(link, link_type)
+        if link_type == :email
+          "<a rel=\"nofollow\" href=\"mailto:#{link}\">#{link}</a>"
+        else
+          "<a rel=\"nofollow\" href=\"#{link}\">#{link}</a>"
+        end
+      end
     end
   end
 
   class Text < Base
-    include ActionView::Helpers::TextHelper
-
     def to_html
       linkify(simple_format(ERB::Util.html_escape(self)))
     end
 
     def to_text
-      self
+      to_s
     end
   end
 end