changeset = create(:changeset)
key = "k"
- (0..255).each do |i|
+ [0, 255].each do |i|
tag = ChangesetTag.new
tag.changeset_id = changeset.id
tag.k = key * i
tag.v = "v"
- assert tag.valid?
+ assert_predicate tag, :valid?
end
end
changeset = create(:changeset)
val = "v"
- (0..255).each do |i|
+ [0, 255].each do |i|
tag = ChangesetTag.new
tag.changeset_id = changeset.id
tag.k = "k"
tag.v = val * i
- assert tag.valid?
+ assert_predicate tag, :valid?
end
end
tag.changeset_id = 1
tag.k = k
tag.v = "v"
- assert !tag.valid?, "Key #{k} should be too long"
- assert tag.errors[:k].any?
+ assert_not tag.valid?, "Key #{k} should be too long"
+ assert_predicate tag.errors[:k], :any?
end
end
tag.changeset_id = 1
tag.k = "k"
tag.v = v
- assert !tag.valid?, "Value #{v} should be too long"
- assert tag.errors[:v].any?
+ assert_not tag.valid?, "Value #{v} should be too long"
+ assert_predicate tag.errors[:v], :any?
end
end
- def test_empty_tag_invalid
- tag = ChangesetTag.new
- assert !tag.valid?, "Empty tag should be invalid"
- assert tag.errors[:changeset].any?
+ def test_orphaned_tag_invalid
+ tag = create(:changeset_tag)
+ tag.changeset = nil
+ assert_not tag.valid?, "Orphaned tag should be invalid"
+ assert_predicate tag.errors[:changeset], :any?
end
def test_uniqueness
tag.changeset_id = existing.changeset_id
tag.k = existing.k
tag.v = existing.v
- assert tag.new_record?
- assert !tag.valid?
+ assert_predicate tag, :new_record?
+ assert_not tag.valid?
assert_raise(ActiveRecord::RecordInvalid) { tag.save! }
- assert tag.new_record?
+ assert_predicate tag, :new_record?
end
end