Use String#tr instead of String.split(foo).join(bar)

[rails.git] / lib / osm_community_index / local_chapter.rb

diff --git a/lib/osm_community_index/local_chapter.rb b/lib/osm_community_index/local_chapter.rb
index 178d3437d334e3ac9a93a0dfd71b132179a0d750..6df3c1bc9edcd37340c33c994c6c3bf2b9bc969e 100644 (file)
--- a/lib/osm_community_index/local_chapter.rb
+++ b/lib/osm_community_index/local_chapter.rb
@@ -28,6 +28,7 @@ module OsmCommunityIndex
       community_index["resources"].each do |id, resource|
         resource.each do |key, value|
           next unless key == "type" && value == "osm-lc" && id != "OSMF"
+
           raw_local_chapters.push({ :id => id, :resource => resource })
         end
       end
@@ -38,10 +39,10 @@ module OsmCommunityIndex
       raw_local_chapters = load_raw_local_chapters
       files = Dir.glob(Rails.root.join("node_modules/osm-community-index/i18n/*"))
       files.each do |file|
-        locale = File.basename(file,".yaml")
+        locale = File.basename(file, ".yaml")
         community_index_yaml = YAML.safe_load(File.read(file))[locale]
         # rails wants en-GB but osm-community-index has en_GB
-        locale_rails = locale.split("_").join("-")
+        locale_rails = locale.tr("_", "-")
         data = {}
 
         raw_local_chapters.each do |chapter|
@@ -51,9 +52,9 @@ module OsmCommunityIndex
           strings = community_index_yaml[id] || {}
           # if the name isn't defined then fall back on community,
           # as per discussion here: https://github.com/osmlab/osm-community-index/issues/483
-          strings['name'] = strings['name'] || resource["strings"]["name"] || resource["strings"]["community"]
+          strings["name"] = strings["name"] || resource["strings"]["name"] || resource["strings"]["community"]
 
-          data.deep_merge!({"osm_community_index" => {"local_chapter" => {id => strings}}})
+          data.deep_merge!({ "osm_community_index" => { "local_chapter" => { id => strings } } })
         end
 
         I18n.backend.store_translations locale_rails, data