some changes suggested by SteveC / yet untested

[rails.git] / app / controllers / search_controller.rb

diff --git a/app/controllers/search_controller.rb b/app/controllers/search_controller.rb
index de305fca3e6e8f2b7d7a49a5a26afbf08cd86b9b..b3e7ca97b63a2068ba18e7ff206e52b3b1893862 100644 (file)
--- a/app/controllers/search_controller.rb
+++ b/app/controllers/search_controller.rb
@@ -1,26 +1,23 @@
 class SearchController < ApplicationController
-  # Support searching for nodes, segments, ways, or all
+  # Support searching for nodes, ways, or all
   # Can search by tag k, v, or both (type->k,value->v)
   # Can search by name (k=name,v=....)
 
   after_filter :compress_output
 
   def search_all
-    do_search(true,true,true)
+    do_search(true,true)
   end
 
   def search_ways
-    do_search(true,false,false)
-  end
-  def search_segments
-    do_search(false,true,false)
+    do_search(true,false)
   end
   def search_nodes
-    do_search(false,false,true)
+    do_search(false,true)
   end
 
 
-  def do_search(do_ways,do_segments,do_nodes)
+  def do_search(do_ways,do_nodes)
     type = params['type']
     value = params['value']
     unless type or value
@@ -33,7 +30,6 @@ class SearchController < ApplicationController
 
     way_ids = Array.new
     ways = Array.new
-    segments = Array.new
     nodes = Array.new
 
     # Matching for tags table
@@ -75,21 +71,13 @@ class SearchController < ApplicationController
       ways = Way.find(:all, :conditions => cond_tbl, :limit => 100)
     end
 
-    # Now, segments matching
-    if do_segments
-      segments = Segment.find(:all, :conditions => cond_tags, :limit => 500)
-    end
-
     # Now, nodes
     if do_nodes
       nodes = Node.find(:all, :conditions => cond_tags, :limit => 2000)
     end
 
-    # Fetch any segments needed for our ways (only have matching segments so far)
-    segments += Segment.find(ways.collect { |w| w.segs }.uniq)
-
-    # Fetch any nodes needed for our segments (only have matching nodes so far)
-    nodes += Node.find(segments.collect { |s| [s.node_a, s.node_b] }.flatten.uniq)
+    # Fetch any node needed for our ways (only have matching nodes so far)
+    nodes += Node.find(ways.collect { |w| w.nds }.uniq)
 
     # Print
     user_display_name_cache = {}
@@ -98,10 +86,6 @@ class SearchController < ApplicationController
       doc.root << node.to_xml_node(user_display_name_cache)
     end
 
-    segments.each do |segment|
-      doc.root << segment.to_xml_node(user_display_name_cache)
-    end 
-
     ways.each do |way|
       doc.root << way.to_xml_node(user_display_name_cache)
     end