Avoid double render error

[rails.git] / app / controllers / node_controller.rb

diff --git a/app/controllers/node_controller.rb b/app/controllers/node_controller.rb
index 27c21c4815a78fea0da3c0846ac8d72559ba82b1..5064a3c0b64a41e3069144e47678df91f69deda3 100644 (file)
--- a/app/controllers/node_controller.rb
+++ b/app/controllers/node_controller.rb
@@ -1,105 +1,78 @@
+# The NodeController is the RESTful interface to Node objects
+
 class NodeController < ApplicationController
   require 'xml/libxml'
 
-  before_filter :authorize
+  skip_before_filter :verify_authenticity_token
+  before_filter :authorize, :only => [:create, :update, :delete]
+  before_filter :require_allow_write_api, :only => [:create, :update, :delete]
+  before_filter :require_public_data, :only => [:create, :update, :delete]
+  before_filter :check_api_writable, :only => [:create, :update, :delete]
+  before_filter :check_api_readable, :except => [:create, :update, :delete]
   after_filter :compress_output
+  around_filter :api_call_handle_error, :api_call_timeout
 
+  # Create a node from XML.
   def create
-    response.headers["Content-Type"] = 'application/xml'
-    if request.put?
-      node = nil
-      begin
-        node = Node.from_xml(request.raw_post, true)
-      rescue
-        render :text => "XML didn't parse", :status => 400 # if we got here the doc didnt parse
-        return
-      end
-
-      if node
-        node.user_id = @user.id
-        node.visible = 1
-        if node.save_with_history
-          render :text => node.id
-        else
-          render :nothing => true, :status => 500
-        end
-        return
+    assert_method :put
 
-      else
-        render :nothing => true, :status => 400 # if we got here the doc didnt parse
-        return
-      end
-    end
+    node = Node.from_xml(request.raw_post, true)
 
-    render :nothing => true, :status => 500 # something went very wrong
+    # Assume that Node.from_xml has thrown an exception if there is an error parsing the xml
+    node.create_with_history @user
+    render :text => node.id.to_s, :content_type => "text/plain"
   end
 
-  def rest
-    response.headers["Content-Type"] = 'application/xml'
-    unless Node.exists?(params[:id])
-      render :nothing => true, :status => 404
-      return
+  # Dump the details on a node given in params[:id]
+  def read
+    node = Node.find(params[:id])
+    if node.visible?
+      response.last_modified = node.timestamp
+      render :text => node.to_xml.to_s, :content_type => "text/xml"
+    else
+      render :text => "", :status => :gone
     end
-
+  end
+  
+  # Update a node from given XML
+  def update
     node = Node.find(params[:id])
-
-    case request.method
-
-    when :get
-      unless node
-        render :nothing => true, :status => 500
-        return
-      end
-
-      unless node.visible
-        render :nothing => true, :status => 410
-        return
-      end
-
-      render :text => node.to_xml.to_s
-      return
-
-    when :delete
-      if node.visible
-        node.visible = 0
-        node.save_with_history
-        render :nothing => true
-      else
-        render :nothing => true, :status => 410
-      end
-
-    when :put
-      new_node = Node.from_xml(request.raw_post)
-
-      node.timestamp = Time.now
-      node.user_id = @user.id
-
-      node.latitude = new_node.latitude 
-      node.longitude = new_node.longitude
-      node.tags = new_node.tags
-
-      if node.id == new_node.id and node.save_with_history
-        render :nothing => true, :status => 200
-      else
-        render :nothing => true, :status => 500
-      end
-      return
+    new_node = Node.from_xml(request.raw_post)
+       
+    unless new_node and new_node.id == node.id
+      raise OSM::APIBadUserInput.new("The id in the url (#{node.id}) is not the same as provided in the xml (#{new_node.id})")
     end
+    node.update_from(new_node, @user)
+    render :text => node.version.to_s, :content_type => "text/plain"
+  end
 
+  # Delete a node. Doesn't actually delete it, but retains its history 
+  # in a wiki-like way. We therefore treat it like an update, so the delete
+  # method returns the new version number.
+  def delete
+    node = Node.find(params[:id])
+    new_node = Node.from_xml(request.raw_post)
+    
+    unless new_node and new_node.id == node.id
+      raise OSM::APIBadUserInput.new("The id in the url (#{node.id}) is not the same as provided in the xml (#{new_node.id})")
+    end
+    node.delete_with_history!(new_node, @user)
+    render :text => node.version.to_s, :content_type => "text/plain"
   end
 
+  # Dump the details on many nodes whose ids are given in the "nodes" parameter.
   def nodes
-    response.headers["Content-Type"] = 'application/xml'
-    ids = params['nodes'].split(',').collect {|n| n.to_i }
-    if ids.length > 0
-      nodelist = Node.find(ids)
-      doc = get_xml_doc
-      nodelist.each do |node|
-        doc.root << node.to_xml_node
-      end 
-      render :text => doc.to_s
-    else
-      render :nothing => true, :status => 400
+    ids = params['nodes'].split(',').collect { |n| n.to_i }
+
+    if ids.length == 0
+      raise OSM::APIBadUserInput.new("No nodes were given to search for")
     end
+    doc = OSM::API.new.get_xml_doc
+
+    Node.find(ids).each do |node|
+      doc.root << node.to_xml_node
+    end
+
+    render :text => doc.to_s, :content_type => "text/xml"
   end
 end